| Message ID | 20161118163704.1236495-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 53cab9f3323b..b135ff1ab12d 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -366,6 +366,7 @@ config PHY_ROCKCHIP_INNO_USB2 depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF depends on COMMON_CLK depends on USB_SUPPORT + depends on EXTCON select GENERIC_PHY select USB_COMMON help
If extcon is a loadable module and rockchip-inno-usb2 is built-in, we get a link failure: drivers/phy/phy-rockchip-inno-usb2.o: In function `rockchip_usb2phy_probe': phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x1ec): undefined reference to `extcon_get_edev_by_phandle' phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x25c): undefined reference to `devm_extcon_dev_allocate' phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x2a8): undefined reference to `devm_extcon_dev_register' phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0xa28): undefined reference to `extcon_register_notifier' Adding a hard dependency avoids the problem. Alternatively we could use "depends on EXTCON || !EXTCON" to allow building with extcon disabled completely, but the other PHY drivers with extcon support also just have a dependency, so this is more consistent. Fixes: 0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/phy/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0