[11/13] fs: fix unsigned enum warning with gcc-4.2

Message ID	20161216105634.235457-12-arnd@arndb.de
State	Accepted
Commit	cbfd0c1001bedb4b051cf4a1f5df24f1500381bc
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; From: Arnd Bergmann <arnd@arndb.de> To: linux-arch@vger.kernel.org Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@vger.kernel.org, Russell King <rmk+kernel@armlinux.org.uk>, Andrew Morton <akpm@linux-foundation.org>, kernel-build-reports@lists.linaro.org, kvmarm@lists.cs.columbia.edu, Arnd Bergmann <arnd@arndb.de> Subject: [PATCH 11/13] fs: fix unsigned enum warning with gcc-4.2 Date: Fri, 16 Dec 2016 11:56:32 +0100 Message-Id: <20161216105634.235457-12-arnd@arndb.de> In-Reply-To: <20161216105634.235457-1-arnd@arndb.de> References: <20161216105634.235457-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk
Series	[01/13,HACK] gcc-4.5: avoid link errors for unused function pointers \| expand [01/13,HACK] gcc-4.5: avoid link errors for unused function pointers [02/13] KVM: arm: fix gcc-4.5 build [03/13] ARM: div64: fix building with gcc-4.5 and lower [04/13] vfio-pci: use 32-bit comparisons for register address for gcc-4.5 [05/13] clk: pxa: fix gcc-4.4 build [06/13] ARM: atomic: fix gcc-4.4 build [07/13] watchdog: kempld: fix gcc-4.3 build [08/13] arm/arm64: xen: avoid gcc-4.4 warning [09/13] ARM: mark cmpxchg and xchg __always_inline for gcc-4.3 [10/13] asm-generic: mark cmpxchg as __always_inline for gcc-4.3 [11/13] fs: fix unsigned enum warning with gcc-4.2 [12/13] KVM: arm: avoid binary number literals for gcc-4.2 [13/13] ARM: avoid 'Q' asm constraint for gcc-4.1 and earlier

Message ID

20161216105634.235457-12-arnd@arndb.de

State

Accepted

Commit

cbfd0c1001bedb4b051cf4a1f5df24f1500381bc

Headers

Received-SPF: pass (google.com: best guess record for domain of
	linux-kernel-owner@vger.kernel.org designates 209.132.180.67
	as permitted sender) client-ip=209.132.180.67; 
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arch@vger.kernel.org
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@vger.kernel.org,
	Russell King <rmk+kernel@armlinux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	kernel-build-reports@lists.linaro.org,
	kvmarm@lists.cs.columbia.edu, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH 11/13] fs: fix unsigned enum warning with gcc-4.2
Date: Fri, 16 Dec 2016 11:56:32 +0100
Message-Id: <20161216105634.235457-12-arnd@arndb.de>
In-Reply-To: <20161216105634.235457-1-arnd@arndb.de>
References: <20161216105634.235457-1-arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Series

[01/13,HACK] gcc-4.5: avoid link errors for unused function pointers | expand

Commit Message

Arnd Bergmann Dec. 16, 2016, 10:56 a.m. UTC

With arm-linux-gcc-4.2, almost every file we build in the kernel ends
up with this warning:

include/linux/fs.h:2648: warning: comparison of unsigned expression < 0 is always false

Later versions don't have this problem, but it's easy enough to
work around.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 include/linux/fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.9.0

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 398cf20a706d..782c2a292fd7 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2645,7 +2645,7 @@  static const char * const kernel_read_file_str[] = {
 
 static inline const char *kernel_read_file_id_str(enum kernel_read_file_id id)
 {
-	if (id < 0 || id >= READING_MAX_ID)
+	if ((unsigned)id >= READING_MAX_ID)
 		return kernel_read_file_str[READING_UNKNOWN];
 
 	return kernel_read_file_str[id];

[11/13] fs: fix unsigned enum warning with gcc-4.2

Commit Message

Patch