[06/13] ARM: atomic: fix gcc-4.4 build

Message ID	20161216105634.235457-7-arnd@arndb.de
State	New
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; From: Arnd Bergmann <arnd@arndb.de> To: linux-arch@vger.kernel.org Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@vger.kernel.org, Russell King <rmk+kernel@armlinux.org.uk>, Andrew Morton <akpm@linux-foundation.org>, kernel-build-reports@lists.linaro.org, kvmarm@lists.cs.columbia.edu, Arnd Bergmann <arnd@arndb.de> Subject: [PATCH 06/13] ARM: atomic: fix gcc-4.4 build Date: Fri, 16 Dec 2016 11:56:27 +0100 Message-Id: <20161216105634.235457-7-arnd@arndb.de> In-Reply-To: <20161216105634.235457-1-arnd@arndb.de> References: <20161216105634.235457-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk
Series	[01/13,HACK] gcc-4.5: avoid link errors for unused function pointers \| expand [01/13,HACK] gcc-4.5: avoid link errors for unused function pointers [02/13] KVM: arm: fix gcc-4.5 build [03/13] ARM: div64: fix building with gcc-4.5 and lower [04/13] vfio-pci: use 32-bit comparisons for register address for gcc-4.5 [05/13] clk: pxa: fix gcc-4.4 build [06/13] ARM: atomic: fix gcc-4.4 build [07/13] watchdog: kempld: fix gcc-4.3 build [08/13] arm/arm64: xen: avoid gcc-4.4 warning [09/13] ARM: mark cmpxchg and xchg __always_inline for gcc-4.3 [10/13] asm-generic: mark cmpxchg as __always_inline for gcc-4.3 [11/13] fs: fix unsigned enum warning with gcc-4.2 [12/13] KVM: arm: avoid binary number literals for gcc-4.2 [13/13] ARM: avoid 'Q' asm constraint for gcc-4.1 and earlier

Message ID

20161216105634.235457-7-arnd@arndb.de

State

New

Headers

Received-SPF: pass (google.com: best guess record for domain of
	linux-kernel-owner@vger.kernel.org designates 209.132.180.67
	as permitted sender) client-ip=209.132.180.67; 
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arch@vger.kernel.org
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@vger.kernel.org,
	Russell King <rmk+kernel@armlinux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	kernel-build-reports@lists.linaro.org,
	kvmarm@lists.cs.columbia.edu, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH 06/13] ARM: atomic: fix gcc-4.4 build
Date: Fri, 16 Dec 2016 11:56:27 +0100
Message-Id: <20161216105634.235457-7-arnd@arndb.de>
In-Reply-To: <20161216105634.235457-1-arnd@arndb.de>
References: <20161216105634.235457-1-arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Series

[01/13,HACK] gcc-4.5: avoid link errors for unused function pointers | expand

Commit Message

Arnd Bergmann Dec. 16, 2016, 10:56 a.m. UTC

gcc-4.4 fails to build some files with this constraint, which was
added to help out with gcc-4.6 and higher:

fs/btrfs/delayed-ref.c: In function 'add_delayed_tree_ref':
arch/arm/include/asm/atomic.h:280: error: 'asm' operand requires impossible reload

Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44492
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 arch/arm/include/asm/atomic.h | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

-- 
2.9.0

diff --git a/arch/arm/include/asm/atomic.h b/arch/arm/include/asm/atomic.h
index 66d0e215a773..65d5b843831a 100644
--- a/arch/arm/include/asm/atomic.h
+++ b/arch/arm/include/asm/atomic.h
@@ -280,7 +280,10 @@  static inline long long atomic64_read(const atomic64_t *v)
 	__asm__ __volatile__("@ atomic64_read\n"
 "	ldrd	%0, %H0, [%1]"
 	: "=&r" (result)
-	: "r" (&v->counter), "Qo" (v->counter)
+	: "r" (&v->counter)
+#if GCC_VERSION >= 40600
+	, "Qo" (v->counter)
+#endif
 	);
 
 	return result;
@@ -302,7 +305,10 @@  static inline long long atomic64_read(const atomic64_t *v)
 	__asm__ __volatile__("@ atomic64_read\n"
 "	ldrexd	%0, %H0, [%1]"
 	: "=&r" (result)
-	: "r" (&v->counter), "Qo" (v->counter)
+	: "r" (&v->counter)
+#if GCC_VERSION >= 40600
+	, "Qo" (v->counter)
+#endif
 	);
 
 	return result;

[06/13] ARM: atomic: fix gcc-4.4 build

Commit Message

Patch