mbox series

[net-next,v2,0/8] Devmem TCP minor cleanups and ksft improvements

Message ID 20250523230524.1107879-1-almasrymina@google.com
Headers show
Series Devmem TCP minor cleanups and ksft improvements | expand

Message

Mina Almasry May 23, 2025, 11:05 p.m. UTC 
v2: https://lore.kernel.org/netdev/20250519023517.4062941-1-almasrymina@google.com/

Changelog:
- Collect acks and tested-bys (Thanks!)
- Drop the patch that removed ksft_disruptive. That seems to not have
  any relation to behavior when test fails.
- Address comments.

---

Minor cleanups to the devmem tcp code, and not-so-minor improvements to
the ksft.

For the cleanups:
- Address comment from Paolo post-merge.
- Fix whitespace.
- Add improvement dropped from Taehee's fix patch.

For the ksft:
- Add support for ipv4 environment.
- Add support for drivers that are limited to 5-tuple flow steering.
- Improve test by sending 1K data instead of just "hello\nworld"

Cc: sdf@fomichev.me
Cc: ap420073@gmail.com
Cc: praan@google.com
Cc: shivajikant@google.com


Mina Almasry (8):
  net: devmem: move list_add to net_devmem_bind_dmabuf.
  page_pool: fix ugly page_pool formatting
  net: devmem: preserve sockc_err
  net: devmem: ksft: add ipv4 support
  net: devmem: ksft: add exit_wait to make rx test pass
  net: devmem: ksft: add 5 tuple FS support
  net: devmem: ksft: upgrade rx test to send 1K data
  net: devmem: ncdevmem: remove unused variable

 net/core/devmem.c                             |  5 +++-
 net/core/devmem.h                             |  5 +++-
 net/core/netdev-genl.c                        |  8 ++-----
 net/core/page_pool.c                          |  4 ++--
 net/ipv4/tcp.c                                | 24 ++++++++-----------
 .../selftests/drivers/net/hw/devmem.py        | 18 +++++++-------
 .../selftests/drivers/net/hw/ncdevmem.c       | 16 ++++++++++---
 7 files changed, 44 insertions(+), 36 deletions(-)


base-commit: ea15e046263b19e91ffd827645ae5dfa44ebd044

Comments

Stanislav Fomichev May 27, 2025, 3:34 p.m. UTC | #1 
On 05/23, Mina Almasry wrote:
> Preserve the error code returned by sock_cmsg_send and return that on
> err.
> 
> Signed-off-by: Mina Almasry <almasrymina@google.com>

Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Stanislav Fomichev May 27, 2025, 3:34 p.m. UTC | #2 
On 05/23, Mina Almasry wrote:
> It's annoying for the list_add to be outside net_devmem_bind_dmabuf, but
> the list_del is in net_devmem_unbind_dmabuf. Make it consistent by
> having both the list_add/del be inside the net_devmem_[un]bind_dmabuf.
> 
> Cc: ap420073@gmail.com
> Signed-off-by: Mina Almasry <almasrymina@google.com>
> Tested-by: Taehee Yoo <ap420073@gmail.com>

Acked-by: Stanislav Fomichev <sdf@fomichev.me>
patchwork-bot+netdevbpf@kernel.org May 28, 2025, 2:30 a.m. UTC | #3 
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 23 May 2025 23:05:16 +0000 you wrote:
> v2: https://lore.kernel.org/netdev/20250519023517.4062941-1-almasrymina@google.com/
> 
> Changelog:
> - Collect acks and tested-bys (Thanks!)
> - Drop the patch that removed ksft_disruptive. That seems to not have
>   any relation to behavior when test fails.
> - Address comments.
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/8] net: devmem: move list_add to net_devmem_bind_dmabuf.
    https://git.kernel.org/netdev/net-next/c/88e47c93b3a2
  - [net-next,v2,2/8] page_pool: fix ugly page_pool formatting
    https://git.kernel.org/netdev/net-next/c/170ebc60b79a
  - [net-next,v2,3/8] net: devmem: preserve sockc_err
    https://git.kernel.org/netdev/net-next/c/85cea17d15c9
  - [net-next,v2,4/8] net: devmem: ksft: add ipv4 support
    https://git.kernel.org/netdev/net-next/c/12d31142e63a
  - [net-next,v2,5/8] net: devmem: ksft: add exit_wait to make rx test pass
    https://git.kernel.org/netdev/net-next/c/57605ae8e1b6
  - [net-next,v2,6/8] net: devmem: ksft: add 5 tuple FS support
    https://git.kernel.org/netdev/net-next/c/243d47a5e1e4
  - [net-next,v2,7/8] net: devmem: ksft: upgrade rx test to send 1K data
    https://git.kernel.org/netdev/net-next/c/baa18bc5353f
  - [net-next,v2,8/8] net: devmem: ncdevmem: remove unused variable
    https://git.kernel.org/netdev/net-next/c/affffcbb8726

You are awesome, thank you!