diff mbox series

[1/4] dt-bindings: arm: qcom: Add Lenovo Thinkbook 16

Message ID 20250515-tb16-dt-v1-1-dc5846a25c48@oldschoolsolutions.biz
State New
Headers show
Series arm64: dts: qcom: x1p42100-lenovo-thinkbook-16: dt definition for Thinkbook 16 | expand

Commit Message

Jens Glathe via B4 Relay May 15, 2025, 8:38 p.m. UTC 
From: Jens Glathe <jens.glathe@oldschoolsolutions.biz>

Document the x1p-42-100/x1-26-100 variants of the Thinkbook 16 G7 QOY.

[1]: https://psref.lenovo.com/syspool/Sys/PDF/ThinkBook/ThinkBook_16_G7_QOY/ThinkBook_16_G7_QOY_Spec.pdf

Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jens Glathe May 21, 2025, 9:37 a.m. UTC | #1 
On 21.05.25 11:31, Krzysztof Kozlowski wrote:
> On Thu, May 15, 2025 at 10:38:55PM GMT, Jens Glathe wrote:
>> Document the x1p-42-100/x1-26-100 variants of the Thinkbook 16 G7 QOY.
>>
>> [1]: https://psref.lenovo.com/syspool/Sys/PDF/ThinkBook/ThinkBook_16_G7_QOY/ThinkBook_16_G7_QOY_Spec.pdf
>>
>> Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
>> ---
>>   Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index a61c85a47e2e759c7c86f3bd49f8597fc5054929..42d22e2fb7817810742a15226807bd6a984e6acd 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -1152,8 +1152,10 @@ properties:
>>         - items:
>>             - enum:
>>                 - asus,zenbook-a14-ux3407qa
>> +              - lenovo,thinkbook-16
>>                 - qcom,x1p42100-crd
>>             - const: qcom,x1p42100
>> +          - const: qcom,x1e80100
> You break existing DTS without any explanation in commit msg. What's
> more, your commit msg says something quite different than you are doing
> here.

My bad, v2 is also still wrong. Preparing a v3 which will only add the 
Thinkbook 16 to qcom.yaml and only say compatible to qcom, x1p42100.

with best regards

Jens
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index a61c85a47e2e759c7c86f3bd49f8597fc5054929..42d22e2fb7817810742a15226807bd6a984e6acd 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -1152,8 +1152,10 @@  properties:
       - items:
           - enum:
               - asus,zenbook-a14-ux3407qa
+              - lenovo,thinkbook-16
               - qcom,x1p42100-crd
           - const: qcom,x1p42100
+          - const: qcom,x1e80100
 
   # Board compatibles go above