| Message ID | 20250518220707.669515-6-jonas@kwiboo.se |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Sun, May 18, 2025 at 10:06:52PM +0000, Jonas Karlman wrote: > The commit 7e856617a1f3 ("dt-bindings: mmc: Add support for rk3576 > eMMC") limited use of power-domains to Rockchip RK3576. > > Remove the power-domains: false to allow use of power-domains with more > controllers, e.g. with SDHCI on Rockchip RK3528. Meanwhile, you're allowing it for all devices, even ones where it is not valid. I'm not keen on that. > > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> > --- > Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > index 5fb347167004..f882219a0a26 100644 > --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > @@ -120,10 +120,6 @@ allOf: > required: > - power-domains > > - else: > - properties: > - power-domains: false > - > unevaluatedProperties: false > > examples: > -- > 2.49.0 >
Hi Conor, On 2025-05-19 18:12, Conor Dooley wrote: > On Sun, May 18, 2025 at 10:06:52PM +0000, Jonas Karlman wrote: >> The commit 7e856617a1f3 ("dt-bindings: mmc: Add support for rk3576 >> eMMC") limited use of power-domains to Rockchip RK3576. >> >> Remove the power-domains: false to allow use of power-domains with more >> controllers, e.g. with SDHCI on Rockchip RK3528. > > Meanwhile, you're allowing it for all devices, even ones where it is not > valid. I'm not keen on that. All Rockchip variants technically belong to a power-domain, not just the RK3576. E.g. for RK3588 a PD_NVM0 domain (not described in DT), for RK3568 a VD_LOGIC ALIVE / BIU_SECURE_FLASH idle-only domain, and as shown in this series for the RK3528 the PD_VPU idle-only domain. Any suggestion on how to best allow describing these links? Regards, Jonas > >> >> Signed-off-by: Jonas Karlman <jonas@kwiboo.se> >> --- >> Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml >> index 5fb347167004..f882219a0a26 100644 >> --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml >> +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml >> @@ -120,10 +120,6 @@ allOf: >> required: >> - power-domains >> >> - else: >> - properties: >> - power-domains: false >> - >> unevaluatedProperties: false >> >> examples: >> -- >> 2.49.0 >>
On Mon, May 19, 2025 at 07:03:37PM +0200, Jonas Karlman wrote: > Hi Conor, > > On 2025-05-19 18:12, Conor Dooley wrote: > > On Sun, May 18, 2025 at 10:06:52PM +0000, Jonas Karlman wrote: > >> The commit 7e856617a1f3 ("dt-bindings: mmc: Add support for rk3576 > >> eMMC") limited use of power-domains to Rockchip RK3576. > >> > >> Remove the power-domains: false to allow use of power-domains with more > >> controllers, e.g. with SDHCI on Rockchip RK3528. > > > > Meanwhile, you're allowing it for all devices, even ones where it is not > > valid. I'm not keen on that. > > All Rockchip variants technically belong to a power-domain, not just the > RK3576. E.g. for RK3588 a PD_NVM0 domain (not described in DT), for > RK3568 a VD_LOGIC ALIVE / BIU_SECURE_FLASH idle-only domain, and as > shown in this series for the RK3528 the PD_VPU idle-only domain. If they all do, that's fine. Acked-by: Conor Dooley <conor.dooley@microchip.com>
diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml index 5fb347167004..f882219a0a26 100644 --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml @@ -120,10 +120,6 @@ allOf: required: - power-domains - else: - properties: - power-domains: false - unevaluatedProperties: false examples:
The commit 7e856617a1f3 ("dt-bindings: mmc: Add support for rk3576 eMMC") limited use of power-domains to Rockchip RK3576. Remove the power-domains: false to allow use of power-domains with more controllers, e.g. with SDHCI on Rockchip RK3528. Signed-off-by: Jonas Karlman <jonas@kwiboo.se> --- Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 4 ---- 1 file changed, 4 deletions(-)