mbox series

[0/5] media: atomisp: stream start/stop error handling improvements

Message ID 20250505210008.152659-1-hdegoede@redhat.com
Headers show
Series media: atomisp: stream start/stop error handling improvements | expand

Message

Hans de Goede May 5, 2025, 9 p.m. UTC 
Hi All,

While working on the mt9m114 driver I introduced a problem where
the sensor's s_stream callback would fail, which turned out to be a good
test-case for the stream start/stop error handling in the atomisp driver.

This series is the result of fixing various error-handling issues which
popped up using this (and other) test-cases.

Regards,

Hans


Hans de Goede (5):
  media: atomisp: Move atomisp_stop_streaming() above
    atomisp_start_streaming()
  media: atomisp: Properly stop the ISP stream on sensor streamon errors
  media: atomisp: Stop pipeline on atomisp_css_start() failure
  media: atomisp: Always free MIPI / CSI-receiver buffers from
    ia_css_uninit()
  media: atomisp: Fix "stop stream timeout." error

 .../media/atomisp/pci/atomisp_compat_css20.c  |   2 +-
 .../staging/media/atomisp/pci/atomisp_fops.c  |   5 +-
 .../staging/media/atomisp/pci/atomisp_ioctl.c | 129 ++++++++----------
 .../media/atomisp/pci/atomisp_subdev.h        |   3 -
 .../staging/media/atomisp/pci/ia_css_pipe.h   |   2 -
 .../pipeline/interface/ia_css_pipeline.h      |   1 -
 .../pci/runtime/pipeline/src/pipeline.c       |   2 -
 drivers/staging/media/atomisp/pci/sh_css.c    |  27 ----
 .../staging/media/atomisp/pci/sh_css_mipi.c   |  11 --
 .../staging/media/atomisp/pci/sh_css_mipi.h   |   2 -
 10 files changed, 62 insertions(+), 122 deletions(-)

Comments

Andy Shevchenko May 7, 2025, 6:18 a.m. UTC | #1 
On Tue, May 6, 2025 at 12:00 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi All,
>
> While working on the mt9m114 driver I introduced a problem where
> the sensor's s_stream callback would fail, which turned out to be a good
> test-case for the stream start/stop error handling in the atomisp driver.
>
> This series is the result of fixing various error-handling issues which
> popped up using this (and other) test-cases.

LGTM,
Reviewed-by: Andy Shevchenko <andy@kernel.org>