mbox series

[v3,0/5] media: intel/ipu6: continue on ipu7 code sharing preparation

Message ID 20250502154446.88965-1-stanislaw.gruszka@linux.intel.com
Headers show
Series media: intel/ipu6: continue on ipu7 code sharing preparation | expand

Message

Stanislaw Gruszka May 2, 2025, 3:44 p.m. UTC 
Cleanups and code sharing preparation with ipu7 driver.

This is on top of:
https://git.linuxtv.org/sailus/media_tree.git/log/?h=devel
Plus:
https://lore.kernel.org/linux-media/20250317073856.162147-1-stanislaw.gruszka@linux.intel.com/
https://lore.kernel.org/linux-media/20250428161643.321617-1-stanislaw.gruszka@linux.intel.com/#t

v2 -> v3:
 - Change comment instead of remove it

v1 -> v2:
 - use ipu_isys_ prefix
 - new patch: remove pin_ready function pointer
 - drop accessor macros for now
Stanislaw Gruszka (5):
  media: intel/ipu6: Remove pin_ready function pointer
  media: intel/ipu6: Remove line_align
  media: intel/ipu6: Change deprecated lock comment
  media: intel/ipu6: Move common structures definitions to ipu-isys.h
  media: intel/ipu6: Rename common structures

 drivers/media/pci/intel/ipu6/ipu-isys.h       |  92 +++++++++
 drivers/media/pci/intel/ipu6/ipu6-isys-csi2.c |   4 +-
 drivers/media/pci/intel/ipu6/ipu6-isys-csi2.h |   6 +-
 .../media/pci/intel/ipu6/ipu6-isys-queue.c    | 178 +++++++++---------
 .../media/pci/intel/ipu6/ipu6-isys-queue.h    |  69 +------
 .../media/pci/intel/ipu6/ipu6-isys-video.c    |  58 +++---
 .../media/pci/intel/ipu6/ipu6-isys-video.h    |  78 +-------
 drivers/media/pci/intel/ipu6/ipu6-isys.c      |  23 ++-
 drivers/media/pci/intel/ipu6/ipu6-isys.h      |   8 +-
 9 files changed, 242 insertions(+), 274 deletions(-)

Comments

Stanislaw Gruszka May 9, 2025, 4:25 a.m. UTC | #1 
Hi Sakari,

On Mon, May 05, 2025 at 08:13:02AM +0000, Sakari Ailus wrote:
> Hi Stanislaw,
> 
> On Fri, May 02, 2025 at 05:44:41PM +0200, Stanislaw Gruszka wrote:
> > Cleanups and code sharing preparation with ipu7 driver.
> > 
> > This is on top of:
> > https://git.linuxtv.org/sailus/media_tree.git/log/?h=devel
> > Plus:
> > https://lore.kernel.org/linux-media/20250317073856.162147-1-stanislaw.gruszka@linux.intel.com/
> > https://lore.kernel.org/linux-media/20250428161643.321617-1-stanislaw.gruszka@linux.intel.com/#t
> 
> Thanks for these. I've applied patches from 1 to 3 for now.
> 
> Going forward, could you post cleanups and reorganising the code into
> common bits in separate sets? 

I don't know what can be cleaned up before I start modifying the code.
And since I change a lot of code during refactoring, changing patches order
and separate the changes is not that easy, I would prefer to do this.

> It'll be easier to see where this is going
> when all related patches are in the same set. Cleanups and fixes we can
> merge earlier on anyway.

I can post bigger sets.

Regards
Stanislaw