| Message ID | 20250507234241.957746-1-pierrick.bouvier@linaro.org |
|---|---|
| Headers | show |
| Series | single-binary: compile target/arm twice | expand |
On Thu, 8 May 2025 at 00:42, Pierrick Bouvier <pierrick.bouvier@linaro.org> wrote: > > More work toward single-binary. > > Some files have external dependencies for the single-binary: > - target/arm/gdbstub.c: gdbhelpers > - target/arm/arm-qmp-cmds.c: qapi > - target/arm/tcg/translate*: need deep cleanup in include/tcg > - target/arm/tcg/cpu*: need TargetInfo implemented for arm/aarch64 > - target/arm/tcg/*-helper*: need deeper split between aarch64 and arm code > They will not be ported in this series. > > Built on {linux, windows, macos} x {x86_64, aarch64} > Fully tested on linux x {x86_64, aarch64} > > Series is now tested and fully reviewed. Thanks for pulling it. Do you/Philippe have a plan for how you want this to go into the tree? I know Philippe has been taking a lot of the single-binary related patches. Let me know if you want me to pick it up via target-arm. -- PMM
Hi Peter, On 5/11/25 6:40 AM, Peter Maydell wrote: > On Thu, 8 May 2025 at 00:42, Pierrick Bouvier > <pierrick.bouvier@linaro.org> wrote: >> >> More work toward single-binary. >> >> Some files have external dependencies for the single-binary: >> - target/arm/gdbstub.c: gdbhelpers >> - target/arm/arm-qmp-cmds.c: qapi >> - target/arm/tcg/translate*: need deep cleanup in include/tcg >> - target/arm/tcg/cpu*: need TargetInfo implemented for arm/aarch64 >> - target/arm/tcg/*-helper*: need deeper split between aarch64 and arm code >> They will not be ported in this series. >> >> Built on {linux, windows, macos} x {x86_64, aarch64} >> Fully tested on linux x {x86_64, aarch64} >> >> Series is now tested and fully reviewed. Thanks for pulling it. > > Do you/Philippe have a plan for how you want this to go into > the tree? I know Philippe has been taking a lot of the > single-binary related patches. Let me know if you want me > to pick it up via target-arm. > During the release code freeze, we mostly used tcg-next. However, now everything is back to normal, we simply work upstream, with a simple "first pulled, first in" strategy, fixing the occasional conflicts on our respective sides. So if you could pull this, that would be appreciated. Thanks! Pierrick > -- PMM
On Mon, 12 May 2025 at 17:53, Pierrick Bouvier <pierrick.bouvier@linaro.org> wrote: > > Hi Peter, > > On 5/11/25 6:40 AM, Peter Maydell wrote: > > On Thu, 8 May 2025 at 00:42, Pierrick Bouvier > > <pierrick.bouvier@linaro.org> wrote: > >> > >> More work toward single-binary. > >> > >> Some files have external dependencies for the single-binary: > >> - target/arm/gdbstub.c: gdbhelpers > >> - target/arm/arm-qmp-cmds.c: qapi > >> - target/arm/tcg/translate*: need deep cleanup in include/tcg > >> - target/arm/tcg/cpu*: need TargetInfo implemented for arm/aarch64 > >> - target/arm/tcg/*-helper*: need deeper split between aarch64 and arm code > >> They will not be ported in this series. > >> > >> Built on {linux, windows, macos} x {x86_64, aarch64} > >> Fully tested on linux x {x86_64, aarch64} > >> > >> Series is now tested and fully reviewed. Thanks for pulling it. > > > > Do you/Philippe have a plan for how you want this to go into > > the tree? I know Philippe has been taking a lot of the > > single-binary related patches. Let me know if you want me > > to pick it up via target-arm. > > > > During the release code freeze, we mostly used tcg-next. > However, now everything is back to normal, we simply work upstream, with > a simple "first pulled, first in" strategy, fixing the occasional > conflicts on our respective sides. > > So if you could pull this, that would be appreciated. I had a go, but it seems to depend on some other patch or series that isn't in upstream git yet. Specifically, the changes to include/system/hvf.h assume it has an include of "cpu.h": you can see it in the context in patch 2: https://lore.kernel.org/qemu-devel/20250507234241.957746-3-pierrick.bouvier@linaro.org/ but that include isn't there in upstream git yet, so the patches touching that file eventually fail to apply cleanly. I assume that's "accel/hvf: Include missing 'hw/core/cpu.h' header", but is there anything else this series was based on? thanks -- PMM
On 5/12/25 10:05 AM, Peter Maydell wrote: > > I had a go, but it seems to depend on some other patch > or series that isn't in upstream git yet. Specifically, > the changes to include/system/hvf.h assume it has an > include of "cpu.h": you can see it in the context in > patch 2: > https://lore.kernel.org/qemu-devel/20250507234241.957746-3-pierrick.bouvier@linaro.org/ > but that include isn't there in upstream git yet, so the > patches touching that file eventually fail to apply cleanly. > I assume that's "accel/hvf: Include missing 'hw/core/cpu.h' header", > but is there anything else this series was based on? > Sorry about that, and wasting your time. I rebased, checked patches apply, built, and sent v8: https://lore.kernel.org/qemu-devel/20250512180502.2395029-1-pierrick.bouvier@linaro.org/T/#mc1b30cb98e11932458c1566ebe50a4efbc10473e Regards, Pierrick > thanks > -- PMM
More work toward single-binary. Some files have external dependencies for the single-binary: - target/arm/gdbstub.c: gdbhelpers - target/arm/arm-qmp-cmds.c: qapi - target/arm/tcg/translate*: need deep cleanup in include/tcg - target/arm/tcg/cpu*: need TargetInfo implemented for arm/aarch64 - target/arm/tcg/*-helper*: need deeper split between aarch64 and arm code They will not be ported in this series. Built on {linux, windows, macos} x {x86_64, aarch64} Fully tested on linux x {x86_64, aarch64} Series is now tested and fully reviewed. Thanks for pulling it. v7 -- - rebase on top of master - removed patch to apply target config for picking files in libsystem/libuser, since it was the only one not reviewed. v6 -- CI: https://github.com/pbo-linaro/qemu/actions/runs/14844742069/job/41675865456 - Replace target_ulong -> vaddr for HWBreakpoint (Philippe) - build target/arm/tcg/crypto_helper.c once (Richard) - build target/arm/tcg/tlb-insns for system only (Richard) - build target/arm/tcg/arith_helper once (Richard) v5 -- CI: https://github.com/pbo-linaro/qemu/actions/runs/14825451208/job/41617949501 - Do not define a separate vaddr type in tcg, simply alias to i32/i64 (Richard) - target/arm/tcg/crypto_helper.c - target/arm/tcg/hflags.c - target/arm/tcg/iwmmxt_helper.c - target/arm/tcg/neon_helper.c - target/arm/tcg/tlb_helper.c - target/arm/tcg/tlb-insns.c - target/arm/tcg/arith_helper.c - target/arm/tcg/vfp_helper.c v4 -- CI: https://github.com/pbo-linaro/qemu/actions/runs/14816460393/job/41597560792 - add patch to apply target config for picking files in libsystem/libuser Useful for Philippe series for semihosting: https://lore.kernel.org/qemu-devel/20250502220524.81548-1-philmd@linaro.org/T/#me750bbaeeba4d16791121fe98b44202afaec4068 - update some patches description (Philippe & Richard) - tcg: introduce vaddr type (Richard) - modify concerned helpers to use vaddr instead of i64 (Richard) - use int64_t instead of uint64_t for top_bits in ptw.c (Philippe) - arm_casq_ptw: use CONFIG_ATOMIC64 instead of TARGET_AARCH64 and comment why (Richard) - target/arm/machine.c v3 -- CI: https://github.com/pbo-linaro/qemu/actions/runs/14765763846/job/41456754153 - Add missing license for new files (Richard) - target/arm/debug_helper.c - target/arm/helper.c - target/arm/vfp_fpscr.c - target/arm/arch_dump.c - target/arm/arm-powerctl.c - target/arm/cortex-regs.c - target/arm/ptw.c - target/arm/kvm-stub.c v2 -- - Remove duplication of kvm struct and constant (Alex) - Use target_big_endian() (Anton) v1 -- - target/arm/cpu.c Philippe Mathieu-Daudé (1): target/arm: Replace target_ulong -> vaddr for HWBreakpoint Pierrick Bouvier (48): include/system/hvf: missing vaddr include meson: add common libs for target and target_system target/arm: move kvm stubs and remove CONFIG_KVM from kvm_arm.h target/arm/kvm-stub: add kvm_arm_reset_vcpu stub target/arm/cpu: move arm_cpu_kvm_set_irq to kvm.c accel/hvf: add hvf_enabled() for common code target/arm/cpu: remove TARGET_BIG_ENDIAN dependency target/arm/cpu: remove TARGET_AARCH64 around aarch64_cpu_dump_state common target/arm/cpu: remove TARGET_AARCH64 in arm_cpu_finalize_features target/arm/cpu: compile file twice (user, system) only target/arm/cpu32-stubs.c: compile file twice (user, system) tcg: add vaddr type for helpers target/arm/helper: use vaddr instead of target_ulong for exception_pc_alignment target/arm/helper: use vaddr instead of target_ulong for probe_access target/arm/helper: extract common helpers target/arm/debug_helper: only include common helpers target/arm/debug_helper: remove target_ulong target/arm/debug_helper: compile file twice (user, system) target/arm/helper: restrict include to common helpers target/arm/helper: replace target_ulong by vaddr target/arm/helper: expose aarch64 cpu registration target/arm/helper: remove remaining TARGET_AARCH64 target/arm/helper: compile file twice (user, system) target/arm/vfp_fpscr: compile file twice (user, system) target/arm/arch_dump: remove TARGET_AARCH64 conditionals target/arm/arch_dump: compile file once (system) target/arm/arm-powerctl: compile file once (system) target/arm/cortex-regs: compile file once (system) target/arm/ptw: replace target_ulong with int64_t target/arm/ptw: replace TARGET_AARCH64 by CONFIG_ATOMIC64 from arm_casq_ptw target/arm/ptw: compile file once (system) target/arm/meson: accelerator files are not needed in user mode target/arm/kvm-stub: compile file once (system) target/arm/machine: reduce migration include to avoid target specific definitions target/arm/machine: remove TARGET_AARCH64 from migration state target/arm/machine: move cpu_post_load kvm bits to kvm_arm_cpu_post_load function target/arm/kvm-stub: add missing stubs target/arm/machine: compile file once (system) target/arm/tcg/vec_internal: use forward declaration for CPUARMState target/arm/tcg/crypto_helper: compile file once target/arm/tcg/hflags: compile file twice (system, user) target/arm/tcg/iwmmxt_helper: compile file twice (system, user) target/arm/tcg/neon_helper: compile file twice (system, user) target/arm/tcg/tlb_helper: compile file twice (system, user) target/arm/helper: restrict define_tlb_insn_regs to system target target/arm/tcg/tlb-insns: compile file once (system) target/arm/tcg/arith_helper: compile file once target/arm/tcg/vfp_helper: compile file twice (system, user) meson.build | 78 ++- include/system/hvf.h | 15 +- include/tcg/tcg-op-common.h | 1 + include/tcg/tcg.h | 14 + target/arm/helper.h | 1152 +------------------------------ target/arm/internals.h | 6 +- target/arm/kvm_arm.h | 87 +-- target/arm/tcg/helper.h | 1153 ++++++++++++++++++++++++++++++++ target/arm/tcg/vec_internal.h | 2 + include/exec/helper-head.h.inc | 11 + accel/hvf/hvf-stub.c | 5 + target/arm/arch_dump.c | 6 - target/arm/cpu.c | 47 +- target/arm/cpu32-stubs.c | 26 + target/arm/debug_helper.c | 6 +- target/arm/helper.c | 24 +- target/arm/hyp_gdbstub.c | 6 +- target/arm/kvm-stub.c | 97 +++ target/arm/kvm.c | 42 +- target/arm/machine.c | 15 +- target/arm/ptw.c | 6 +- target/arm/tcg/arith_helper.c | 5 +- target/arm/tcg/crypto_helper.c | 6 +- target/arm/tcg/hflags.c | 4 +- target/arm/tcg/iwmmxt_helper.c | 4 +- target/arm/tcg/neon_helper.c | 4 +- target/arm/tcg/op_helper.c | 2 +- target/arm/tcg/tlb-insns.c | 7 - target/arm/tcg/tlb_helper.c | 5 +- target/arm/tcg/translate-a64.c | 2 +- target/arm/tcg/translate.c | 2 +- target/arm/tcg/vfp_helper.c | 4 +- tcg/tcg.c | 5 + accel/hvf/meson.build | 1 + target/arm/meson.build | 41 +- target/arm/tcg/meson.build | 29 +- 36 files changed, 1534 insertions(+), 1386 deletions(-) create mode 100644 target/arm/tcg/helper.h create mode 100644 accel/hvf/hvf-stub.c create mode 100644 target/arm/cpu32-stubs.c