| Message ID | 20250506092206.46143-1-ziyao@disroot.org |
|---|---|
| Headers | show |
| Series | Support SD/SDIO controllers on RK3528 | expand |
On Tue, 06 May 2025 09:22:01 +0000, Yao Zi wrote: > RK3528 features two SDIO controllers and one SD/MMC controller. This > series adds essential support for their tuning clocks and brings the > SD/MMC one up on Radxa E20C board. Both HS and SDR104 mode are verified. > > - Changed from v4 > - rk3528 clock driver > - Switch to auxiliary GRF > - drop rockchip_clk_register_grf_branches > - Rename branch_mmc_grf to branch_grf_mmc to make style consistent > (with branch_grf_gate) > - Link to v4: https://lore.kernel.org/all/20250417143647.43860-1-ziyao@disroot.org/ > - Changed from v3 > - Drop applied binding patch of MMC controller > - Rebase on top of linux-rockchip/for-next > - Link to v3: https://lore.kernel.org/all/20250309055348.9299-1-ziyao@disroot.org/ > - Changed from v2 > - Apply review tags > - Rebase on top of linux-rockchip/for-next and drop applied patches > - RK3528 devicetree > - Fix accidentally dropped status property of saradc node > - drop det and pwren pinctrls for SDIO{0,1} according to the > reference design > - Correct max-frequency for SDIO{0,1} > - rk3528-radxa-e20c devicetree > - Don't disable sdio for sdmmc as claimed in the hw design guide > - Link to v2: https://lore.kernel.org/all/20250305194217.47052-1-ziyao@disroot.org/ > - Changed from v1 > - Apply review tags > - Rebase on top of linux-rockchip/for-next and saradc v2 series > - rk3528 clock driver: > - explicitly include minmax.h, replace MAX() with more robust max() > - readability improvements > - fix error checks: ERR_PTR(-ENODEV), instead of ERR_PTR(ENODEV), is > returned when syscon_regmap_lookup_by_compatible() fails for missing > such syscon > - RK3528 devicetree > - Add default pinctrl > - Move the per-SoC property, rockchip,default-sample-phase, into the > SoC devicetree > - rk3528-radxa-e20c devicetree > - Assign sdcard to mmc1 > - Add missing regulators > - Apply no-sdio for the sdmmc controller > - Sort nodes > - Link to v1: https://lore.kernel.org/all/20250301104250.36295-1-ziyao@disroot.org/ > > [...] Applied, thanks! [1/5] dt-bindings: clock: Add GRF clock definition for RK3528 commit: 8a023e86f3d999007f2687952afe78ef34a6aa91 [2/5] clk: rockchip: Support MMC clocks in GRF region commit: 621ba4d9f6db560a7406fd732af1b495ff5aa103 [3/5] clk: rockchip: rk3528: Add SD/SDIO tuning clocks in GRF region commit: 306d2f5ddaa765f04ffb54fc9437a6318f904b53 Best regards,
RK3528 features two SDIO controllers and one SD/MMC controller. This series adds essential support for their tuning clocks and brings the SD/MMC one up on Radxa E20C board. Both HS and SDR104 mode are verified. - Changed from v4 - rk3528 clock driver - Switch to auxiliary GRF - drop rockchip_clk_register_grf_branches - Rename branch_mmc_grf to branch_grf_mmc to make style consistent (with branch_grf_gate) - Link to v4: https://lore.kernel.org/all/20250417143647.43860-1-ziyao@disroot.org/ - Changed from v3 - Drop applied binding patch of MMC controller - Rebase on top of linux-rockchip/for-next - Link to v3: https://lore.kernel.org/all/20250309055348.9299-1-ziyao@disroot.org/ - Changed from v2 - Apply review tags - Rebase on top of linux-rockchip/for-next and drop applied patches - RK3528 devicetree - Fix accidentally dropped status property of saradc node - drop det and pwren pinctrls for SDIO{0,1} according to the reference design - Correct max-frequency for SDIO{0,1} - rk3528-radxa-e20c devicetree - Don't disable sdio for sdmmc as claimed in the hw design guide - Link to v2: https://lore.kernel.org/all/20250305194217.47052-1-ziyao@disroot.org/ - Changed from v1 - Apply review tags - Rebase on top of linux-rockchip/for-next and saradc v2 series - rk3528 clock driver: - explicitly include minmax.h, replace MAX() with more robust max() - readability improvements - fix error checks: ERR_PTR(-ENODEV), instead of ERR_PTR(ENODEV), is returned when syscon_regmap_lookup_by_compatible() fails for missing such syscon - RK3528 devicetree - Add default pinctrl - Move the per-SoC property, rockchip,default-sample-phase, into the SoC devicetree - rk3528-radxa-e20c devicetree - Assign sdcard to mmc1 - Add missing regulators - Apply no-sdio for the sdmmc controller - Sort nodes - Link to v1: https://lore.kernel.org/all/20250301104250.36295-1-ziyao@disroot.org/ Thanks for your time and review. Yao Zi (5): dt-bindings: clock: Add GRF clock definition for RK3528 clk: rockchip: Support MMC clocks in GRF region clk: rockchip: rk3528: Add SD/SDIO tuning clocks in GRF region arm64: dts: rockchip: Add SDMMC/SDIO controllers for RK3528 arm64: dts: rockchip: Enable SD-card interface on Radxa E20C .../boot/dts/rockchip/rk3528-radxa-e20c.dts | 30 +++++++ arch/arm64/boot/dts/rockchip/rk3528.dtsi | 69 ++++++++++++++++ drivers/clk/rockchip/clk-mmc-phase.c | 24 +++++- drivers/clk/rockchip/clk-rk3528.c | 82 +++++++++++++++++-- drivers/clk/rockchip/clk.c | 17 +++- drivers/clk/rockchip/clk.h | 22 ++++- .../dt-bindings/clock/rockchip,rk3528-cru.h | 6 ++ 7 files changed, 236 insertions(+), 14 deletions(-)