| Message ID | 20250508134635.1627031-1-mukesh.ojha@oss.qualcomm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/2] soc: qcom: socinfo: add SM8750 SoC ID | expand |
On 5/8/2025 6:46 AM, Mukesh Ojha wrote: > Add the unique ID for Qualcomm SM8750 SoC. > This value is used to differentiate the SoC across qcom targets. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com> > Reviewed-by: Melody Olvera <melody.olvera@oss.qualcomm.com> Thanks, Melody
On Thu, May 08, 2025 at 07:16:34PM +0530, Mukesh Ojha wrote: > Update soc_id table for the Qualcomm SM8750 SoC to represent > SM8750 machine. > > Signed-off-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com> > --- > Changes in v2: > - corrected the order. I believe the feedback given related to two different issues with "order", and you fixed the sort order of soc_id[] but not the other one. Patch 1 can not be compiled without patch 2, so applying this series would break "git bisect" of the master branch. I'm applying the two patches in opposite order, but please do make sure that the kernel is buildable and functional after each patch in the future. Regards, Bjorn > > drivers/soc/qcom/socinfo.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c > index 18d7f1be9093..8c4147737c35 100644 > --- a/drivers/soc/qcom/socinfo.c > +++ b/drivers/soc/qcom/socinfo.c > @@ -444,6 +444,7 @@ static const struct soc_id soc_id[] = { > { qcom_board_id(IPQ5302) }, > { qcom_board_id(QCS8550) }, > { qcom_board_id(QCM8550) }, > + { qcom_board_id(SM8750) }, > { qcom_board_id(IPQ5300) }, > { qcom_board_id(IPQ5321) }, > { qcom_board_id(IPQ5424) }, > -- > 2.34.1 >
On Thu, 08 May 2025 19:16:34 +0530, Mukesh Ojha wrote: > Update soc_id table for the Qualcomm SM8750 SoC to represent > SM8750 machine. > > Applied, thanks! [1/2] soc: qcom: socinfo: add SM8750 SoC ID commit: b7fc42fb0e6fd5c786e7e0eebe44ee44646ef47c [2/2] dt-bindings: cache: qcom,llcc: Document SM8750 LLCC block commit: 85c5d9b9464b17eb2f5a00edd145f45a12ae31ba But in reverse order... Best regards,
diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c index 18d7f1be9093..8c4147737c35 100644 --- a/drivers/soc/qcom/socinfo.c +++ b/drivers/soc/qcom/socinfo.c @@ -444,6 +444,7 @@ static const struct soc_id soc_id[] = { { qcom_board_id(IPQ5302) }, { qcom_board_id(QCS8550) }, { qcom_board_id(QCM8550) }, + { qcom_board_id(SM8750) }, { qcom_board_id(IPQ5300) }, { qcom_board_id(IPQ5321) }, { qcom_board_id(IPQ5424) },
Update soc_id table for the Qualcomm SM8750 SoC to represent SM8750 machine. Signed-off-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com> --- Changes in v2: - corrected the order. drivers/soc/qcom/socinfo.c | 1 + 1 file changed, 1 insertion(+)