| Message ID | 20250502-qcom-iris-hevc-vp9-v3-7-552158a10a7d@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,01/23] media: iris: Skip destroying internal buffer if not dequeued | expand |
On 01/05/2025 20:13, Dikshita Agarwal wrote: > The function pointers responsible for setting firmware properties were > never initialized in the instance capability structure, causing it to > remain NULL. As a result, the firmware properties were not being set > correctly. > > Fix this by properly assigning the function pointers from the core > capability to the instance capability, ensuring that the properties are > correctly applied to the firmware. > > Cc: stable@vger.kernel.org > Fixes: 3a19d7b9e08b ("media: iris: implement set properties to firmware during streamon") > Acked-by: Vikash Garodia <quic_vgarodia@quicinc.com> > Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com> > --- > drivers/media/platform/qcom/iris/iris_ctrls.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c > index 915de101fcba..13f5cf0d0e8a 100644 > --- a/drivers/media/platform/qcom/iris/iris_ctrls.c > +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c > @@ -157,6 +157,7 @@ void iris_session_init_caps(struct iris_core *core) > core->inst_fw_caps[cap_id].value = caps[i].value; > core->inst_fw_caps[cap_id].flags = caps[i].flags; > core->inst_fw_caps[cap_id].hfi_id = caps[i].hfi_id; > + core->inst_fw_caps[cap_id].set = caps[i].set; > } > } > > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c index 915de101fcba..13f5cf0d0e8a 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.c +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c @@ -157,6 +157,7 @@ void iris_session_init_caps(struct iris_core *core) core->inst_fw_caps[cap_id].value = caps[i].value; core->inst_fw_caps[cap_id].flags = caps[i].flags; core->inst_fw_caps[cap_id].hfi_id = caps[i].hfi_id; + core->inst_fw_caps[cap_id].set = caps[i].set; } }
The function pointers responsible for setting firmware properties were never initialized in the instance capability structure, causing it to remain NULL. As a result, the firmware properties were not being set correctly. Fix this by properly assigning the function pointers from the core capability to the instance capability, ensuring that the properties are correctly applied to the firmware. Cc: stable@vger.kernel.org Fixes: 3a19d7b9e08b ("media: iris: implement set properties to firmware during streamon") Acked-by: Vikash Garodia <quic_vgarodia@quicinc.com> Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com> --- drivers/media/platform/qcom/iris/iris_ctrls.c | 1 + 1 file changed, 1 insertion(+)