mbox series

[v5,0/8] hw/hyperv: remove duplication compilation units

Message ID 20250424232829.141163-1-pierrick.bouvier@linaro.org
Headers show
Series hw/hyperv: remove duplication compilation units | expand

Message

Pierrick Bouvier April 24, 2025, 11:28 p.m. UTC
Work towards having a single binary, by removing duplicated object files.

v2
- remove osdep from header
- use hardcoded buffer size for syndbg, assuming page size is always 4Kb.

v3
- fix assert for page size.

v4
- use KiB unit

v5
- rebase on top of system memory common series
- make hw/hyperv/hyperv common

v6
- rebase on top of master (now contains all changes needed for memory access)
- finish making hw/hyperv/hyperv common (hw/hyperv/hyperv.c)

Pierrick Bouvier (8):
  hw/hyperv/hv-balloon-stub: common compilation unit
  hw/hyperv/hyperv.h: header cleanup
  hw/hyperv/vmbus: common compilation unit
  hw/hyperv/syndbg: common compilation unit
  hw/hyperv/balloon: common balloon compilation units
  hw/hyperv/hyperv_testdev: common compilation unit
  include/system: make functions accessible from common code
  hw/hyperv/hyperv: common compilation unit

 include/hw/hyperv/hyperv.h |  3 ++-
 include/system/kvm.h       |  8 ++++----
 hw/hyperv/hyperv.c         |  3 ++-
 hw/hyperv/syndbg.c         |  9 ++++++---
 hw/hyperv/vmbus.c          |  2 +-
 hw/hyperv/meson.build      | 11 ++++++-----
 6 files changed, 21 insertions(+), 15 deletions(-)

Comments

Pierrick Bouvier April 24, 2025, 11:30 p.m. UTC | #1
On 4/24/25 16:28, Pierrick Bouvier wrote:
> Work towards having a single binary, by removing duplicated object files.
> 
> v2
> - remove osdep from header
> - use hardcoded buffer size for syndbg, assuming page size is always 4Kb.
> 
> v3
> - fix assert for page size.
> 
> v4
> - use KiB unit
> 
> v5
> - rebase on top of system memory common series
> - make hw/hyperv/hyperv common
> 
> v6
> - rebase on top of master (now contains all changes needed for memory access)
> - finish making hw/hyperv/hyperv common (hw/hyperv/hyperv.c)
> 
> Pierrick Bouvier (8):
>    hw/hyperv/hv-balloon-stub: common compilation unit
>    hw/hyperv/hyperv.h: header cleanup
>    hw/hyperv/vmbus: common compilation unit
>    hw/hyperv/syndbg: common compilation unit
>    hw/hyperv/balloon: common balloon compilation units
>    hw/hyperv/hyperv_testdev: common compilation unit
>    include/system: make functions accessible from common code
>    hw/hyperv/hyperv: common compilation unit
> 
>   include/hw/hyperv/hyperv.h |  3 ++-
>   include/system/kvm.h       |  8 ++++----
>   hw/hyperv/hyperv.c         |  3 ++-
>   hw/hyperv/syndbg.c         |  9 ++++++---
>   hw/hyperv/vmbus.c          |  2 +-
>   hw/hyperv/meson.build      | 11 ++++++-----
>   6 files changed, 21 insertions(+), 15 deletions(-)
> 

@Maciej, this is now ready to be tested :)

Regards,
Pierrick
Maciej S. Szmigiero April 29, 2025, 4:39 p.m. UTC | #2
On 25.04.2025 01:30, Pierrick Bouvier wrote:
> On 4/24/25 16:28, Pierrick Bouvier wrote:
>> Work towards having a single binary, by removing duplicated object files.
>>
>> v2
>> - remove osdep from header
>> - use hardcoded buffer size for syndbg, assuming page size is always 4Kb.
>>
>> v3
>> - fix assert for page size.
>>
>> v4
>> - use KiB unit
>>
>> v5
>> - rebase on top of system memory common series
>> - make hw/hyperv/hyperv common
>>
>> v6
>> - rebase on top of master (now contains all changes needed for memory access)
>> - finish making hw/hyperv/hyperv common (hw/hyperv/hyperv.c)
>>
>> Pierrick Bouvier (8):
>>    hw/hyperv/hv-balloon-stub: common compilation unit
>>    hw/hyperv/hyperv.h: header cleanup
>>    hw/hyperv/vmbus: common compilation unit
>>    hw/hyperv/syndbg: common compilation unit
>>    hw/hyperv/balloon: common balloon compilation units
>>    hw/hyperv/hyperv_testdev: common compilation unit
>>    include/system: make functions accessible from common code
>>    hw/hyperv/hyperv: common compilation unit
>>
>>   include/hw/hyperv/hyperv.h |  3 ++-
>>   include/system/kvm.h       |  8 ++++----
>>   hw/hyperv/hyperv.c         |  3 ++-
>>   hw/hyperv/syndbg.c         |  9 ++++++---
>>   hw/hyperv/vmbus.c          |  2 +-
>>   hw/hyperv/meson.build      | 11 ++++++-----
>>   6 files changed, 21 insertions(+), 15 deletions(-)
>>
> 
> @Maciej, this is now ready to be tested :)

Tested this patch set on a Windows VM with hv-balloon QEMU device
(which uses VMBus, which in turn uses basic Hyper-V host support).

No problems encountered, so:
Tested-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>

> Regards,
> Pierrick
Thanks,
Maciej
Philippe Mathieu-Daudé April 29, 2025, 4:44 p.m. UTC | #3
On 29/4/25 18:39, Maciej S. Szmigiero wrote:
> On 25.04.2025 01:30, Pierrick Bouvier wrote:


>>> Pierrick Bouvier (8):
>>>    hw/hyperv/hv-balloon-stub: common compilation unit
>>>    hw/hyperv/hyperv.h: header cleanup
>>>    hw/hyperv/vmbus: common compilation unit
>>>    hw/hyperv/syndbg: common compilation unit
>>>    hw/hyperv/balloon: common balloon compilation units
>>>    hw/hyperv/hyperv_testdev: common compilation unit
>>>    include/system: make functions accessible from common code
>>>    hw/hyperv/hyperv: common compilation unit
>>>
>>>   include/hw/hyperv/hyperv.h |  3 ++-
>>>   include/system/kvm.h       |  8 ++++----
>>>   hw/hyperv/hyperv.c         |  3 ++-
>>>   hw/hyperv/syndbg.c         |  9 ++++++---
>>>   hw/hyperv/vmbus.c          |  2 +-
>>>   hw/hyperv/meson.build      | 11 ++++++-----
>>>   6 files changed, 21 insertions(+), 15 deletions(-)
>>>
>>
>> @Maciej, this is now ready to be tested :)
> 
> Tested this patch set on a Windows VM with hv-balloon QEMU device
> (which uses VMBus, which in turn uses basic Hyper-V host support).
> 
> No problems encountered, so:
> Tested-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>

Thank you!

Series queued.