| Message ID | 20250424-sm8750-display-dts-v1-0-6fb22ca95f38@linaro.org |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: sm8750: Enable display | expand |
On 24/04/2025 15:04, Krzysztof Kozlowski wrote: > MTP8750 does not have audio jack connected and relies on USB mux > (WCD9395). Add necessary nodes for proper audio headset support along > with USB Type-C altmode and orientation. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 58 +++++++++++++++++++++++++++++++++ > 1 file changed, 58 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts > index bd0918e8a7a7e03530eea577c7609454fecfdaf7..c3470e1daa6b7f31196645759be23fb168ce8eb7 100644 > --- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts > @@ -53,6 +53,15 @@ wcd939x: audio-codec { > vdd-mic-bias-supply = <&vreg_bob1>; > > #sound-dai-cells = <1>; > + > + mode-switch; > + orientation-switch; > + > + port { > + wcd_codec_headset_in: endpoint { > + remote-endpoint = <&wcd_usbss_headset_out>; > + }; > + }; > }; > > chosen { > @@ -220,6 +229,14 @@ port@1 { > pmic_glink_ss_in: endpoint { port@0 and port@1 need updates for endpoints as well. I will do that in v2. Best regards, Krzysztof
On Thu, Apr 24, 2025 at 03:04:24PM +0200, Krzysztof Kozlowski wrote: > DTS is ready and I consider it ready for review, but still RFC because: > 1. Display has unresolved issues which might result in change in > bindings (clock parents), > 2. I did not test it since some time on my board... > 3. Just want to share it fast to unblock any dependent work. > > DTS build dependencies - as in b4 deps, so: > https://lore.kernel.org/r/20250421-sm8750_usb_master-v5-0-25c79ed01d02@oss.qualcomm.com/ > https://lore.kernel.org/r/20250424-sm8750-audio-part-2-v1-0-50133a0ec35f@linaro.org/ > https://lore.kernel.org/r/20250113-sm8750_gpmic_master-v1-2-ef45cf206979@quicinc.com/ > > Bindings: > 1. Panel: https://github.com/krzk/linux/tree/b4/sm8750-display-panel > 2. MDSS: https://lore.kernel.org/r/20250311-b4-sm8750-display-v4-0-da6b3e959c76@linaro.org/ > > Patchset based on next-20250424. If the DisplayPort works on this platform, I'd kindly ask to send separate DP+DPU only series (both driver and arm64/dts). It would make it much easier (at least for me) to land the series, while you and Qualcomm engineers are working on the DSI issues.
On 4/25/2025 12:34 PM, Dmitry Baryshkov wrote: > On Thu, Apr 24, 2025 at 03:04:24PM +0200, Krzysztof Kozlowski wrote: >> DTS is ready and I consider it ready for review, but still RFC because: >> 1. Display has unresolved issues which might result in change in >> bindings (clock parents), >> 2. I did not test it since some time on my board... >> 3. Just want to share it fast to unblock any dependent work. >> >> DTS build dependencies - as in b4 deps, so: >> https://lore.kernel.org/r/20250421-sm8750_usb_master-v5-0-25c79ed01d02@oss.qualcomm.com/ >> https://lore.kernel.org/r/20250424-sm8750-audio-part-2-v1-0-50133a0ec35f@linaro.org/ >> https://lore.kernel.org/r/20250113-sm8750_gpmic_master-v1-2-ef45cf206979@quicinc.com/ >> >> Bindings: >> 1. Panel: https://github.com/krzk/linux/tree/b4/sm8750-display-panel >> 2. MDSS: https://lore.kernel.org/r/20250311-b4-sm8750-display-v4-0-da6b3e959c76@linaro.org/ >> >> Patchset based on next-20250424. > > If the DisplayPort works on this platform, I'd kindly ask to send > separate DP+DPU only series (both driver and arm64/dts). It would make > it much easier (at least for me) to land the series, while you and > Qualcomm engineers are working on the DSI issues. > Afaik, DP does not work yet on sm8750. Thats the next thing which needs bringup.
On 25/04/2025 21:34, Dmitry Baryshkov wrote: > On Thu, Apr 24, 2025 at 03:04:24PM +0200, Krzysztof Kozlowski wrote: >> DTS is ready and I consider it ready for review, but still RFC because: >> 1. Display has unresolved issues which might result in change in >> bindings (clock parents), >> 2. I did not test it since some time on my board... >> 3. Just want to share it fast to unblock any dependent work. >> >> DTS build dependencies - as in b4 deps, so: >> https://lore.kernel.org/r/20250421-sm8750_usb_master-v5-0-25c79ed01d02@oss.qualcomm.com/ >> https://lore.kernel.org/r/20250424-sm8750-audio-part-2-v1-0-50133a0ec35f@linaro.org/ >> https://lore.kernel.org/r/20250113-sm8750_gpmic_master-v1-2-ef45cf206979@quicinc.com/ >> >> Bindings: >> 1. Panel: https://github.com/krzk/linux/tree/b4/sm8750-display-panel >> 2. MDSS: https://lore.kernel.org/r/20250311-b4-sm8750-display-v4-0-da6b3e959c76@linaro.org/ >> >> Patchset based on next-20250424. > > If the DisplayPort works on this platform, I'd kindly ask to send > separate DP+DPU only series (both driver and arm64/dts). It would make > it much easier (at least for me) to land the series, while you and > Qualcomm engineers are working on the DSI issues. DP has also issues - link training failures, although it feels as different one, because DSI issue Jessica narrowed to DSI PHY PLL VCO rate and I have a working display (just don't know how to actually solve this). Best regards, Krzysztof
On Fri, Apr 25, 2025 at 09:54:47PM +0200, Krzysztof Kozlowski wrote: > On 25/04/2025 21:34, Dmitry Baryshkov wrote: > > On Thu, Apr 24, 2025 at 03:04:24PM +0200, Krzysztof Kozlowski wrote: > >> DTS is ready and I consider it ready for review, but still RFC because: > >> 1. Display has unresolved issues which might result in change in > >> bindings (clock parents), > >> 2. I did not test it since some time on my board... > >> 3. Just want to share it fast to unblock any dependent work. > >> > >> DTS build dependencies - as in b4 deps, so: > >> https://lore.kernel.org/r/20250421-sm8750_usb_master-v5-0-25c79ed01d02@oss.qualcomm.com/ > >> https://lore.kernel.org/r/20250424-sm8750-audio-part-2-v1-0-50133a0ec35f@linaro.org/ > >> https://lore.kernel.org/r/20250113-sm8750_gpmic_master-v1-2-ef45cf206979@quicinc.com/ > >> > >> Bindings: > >> 1. Panel: https://github.com/krzk/linux/tree/b4/sm8750-display-panel > >> 2. MDSS: https://lore.kernel.org/r/20250311-b4-sm8750-display-v4-0-da6b3e959c76@linaro.org/ > >> > >> Patchset based on next-20250424. > > > > If the DisplayPort works on this platform, I'd kindly ask to send > > separate DP+DPU only series (both driver and arm64/dts). It would make > > it much easier (at least for me) to land the series, while you and > > Qualcomm engineers are working on the DSI issues. > DP has also issues - link training failures, Some of the platforms have DP lanes inverted between DP and PHY. See patches posted for QCS615. Might it be that it is the case for SM8750 too? > although it feels as > different one, because DSI issue Jessica narrowed to DSI PHY PLL VCO > rate and I have a working display (just don't know how to actually solve > this). > > Best regards, > Krzysztof
DTS is ready and I consider it ready for review, but still RFC because: 1. Display has unresolved issues which might result in change in bindings (clock parents), 2. I did not test it since some time on my board... 3. Just want to share it fast to unblock any dependent work. DTS build dependencies - as in b4 deps, so: https://lore.kernel.org/r/20250421-sm8750_usb_master-v5-0-25c79ed01d02@oss.qualcomm.com/ https://lore.kernel.org/r/20250424-sm8750-audio-part-2-v1-0-50133a0ec35f@linaro.org/ https://lore.kernel.org/r/20250113-sm8750_gpmic_master-v1-2-ef45cf206979@quicinc.com/ Bindings: 1. Panel: https://github.com/krzk/linux/tree/b4/sm8750-display-panel 2. MDSS: https://lore.kernel.org/r/20250311-b4-sm8750-display-v4-0-da6b3e959c76@linaro.org/ Patchset based on next-20250424. Best regards, Krzysztof --- Krzysztof Kozlowski (4): arm64: dts: qcom: sm8750: Add display (MDSS) with Display CC arm64: dts: qcom: sm8750-mtp: Enable display arm64: dts: qcom: sm8750-mtp: Enable USB headset and Type-C altmode arm64: dts: qcom: sm8750-mtp: Enable DisplayPort over USB arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 136 +++++++++++ arch/arm64/boot/dts/qcom/sm8750.dtsi | 417 ++++++++++++++++++++++++++++++++ 2 files changed, 553 insertions(+) --- base-commit: 393d0c54cae31317deaa9043320c5fd9454deabc change-id: 20250424-sm8750-display-dts-447473a33fff prerequisite-change-id: 20241223-sm8750_usb_master-f27aed7f6d40:v5 prerequisite-patch-id: 6fdfd47703ddaf8ffcea30d75c3f91767e595008 prerequisite-patch-id: b0269b582b3685213a83fd382a67767e6bcd2213 prerequisite-patch-id: 893493ba5d45ba4a46dfe587839e0383c5a10e63 prerequisite-patch-id: 7c016dcb0fbab838c2b76252c6cb18443c80af3c prerequisite-patch-id: 33b17dd5e4b6e45f183d9ff8fded66e4caf230d6 prerequisite-patch-id: 1d8327cb2680216cd858d90a224004856b750ebd prerequisite-patch-id: 0f100a5cd47aabada80060836a04c7ccac0a8859 prerequisite-patch-id: 2d05f8df51501b5490d0c6732706f56e58e7429f prerequisite-patch-id: e33a6bfeecfb0ebf2c2b3790d02538562f72902f prerequisite-patch-id: 001d38f8ce89e3e03d2a13de71453b47212ad567 prerequisite-change-id: 20241122-sm8750-audio-part-2-943277d85302:v1 prerequisite-patch-id: acf4c9f30842e1389e0611694483e8acfa7fd5ef prerequisite-patch-id: b7dcdb6373238d8af4c5a505edf7bb3bd391a677 prerequisite-message-id: 20250113-sm8750_gpmic_master-v1-2-ef45cf206979@quicinc.com prerequisite-patch-id: f2c73e0f8946071eb798d71a195a1061dad3cf9e prerequisite-patch-id: 7b0af9008faf4b191f69fe88fb7b404ed7d4831f Best regards,