| Message ID | 20250311084203.516205-1-hao.yao@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | media: ipu6: Remove workaround for Meteor Lake ES2 | expand |
On Tue, Mar 11, 2025 at 04:41:55PM +0800, Hao Yao wrote: > There was a hardware bug which need IPU6 driver to disable the ATS. > This workaround is not needed anymore as the bug was fixed in > hardware level. > > Signed-off-by: Hao Yao <hao.yao@intel.com> Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> Regards Stanislaw > --- > drivers/media/pci/intel/ipu6/ipu6.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c > index 277af7cda8ee..b00d0705fefa 100644 > --- a/drivers/media/pci/intel/ipu6/ipu6.c > +++ b/drivers/media/pci/intel/ipu6/ipu6.c > @@ -464,11 +464,6 @@ static int ipu6_pci_config_setup(struct pci_dev *dev, u8 hw_ver) > { > int ret; > > - /* disable IPU6 PCI ATS on mtl ES2 */ > - if (is_ipu6ep_mtl(hw_ver) && boot_cpu_data.x86_stepping == 0x2 && > - pci_ats_supported(dev)) > - pci_disable_ats(dev); > - > /* No PCI msi capability for IPU6EP */ > if (is_ipu6ep(hw_ver) || is_ipu6ep_mtl(hw_ver)) { > /* likely do nothing as msi not enabled by default */ > -- > 2.43.0 > >
Hi Bingbu, On Thu, Apr 24, 2025 at 12:18:06PM +0800, Bingbu Cao wrote: > Hao, > > On 3/11/25 4:41 PM, Hao Yao wrote: > > There was a hardware bug which need IPU6 driver to disable the ATS. > > This workaround is not needed anymore as the bug was fixed in > > hardware level. > > > > It is better to send v2 with fixes tag here: > > Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver") Is this worth backporting? Nothing is broken because of this, is it? > > > Signed-off-by: Hao Yao <hao.yao@intel.com> > > --- > > drivers/media/pci/intel/ipu6/ipu6.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c > > index 277af7cda8ee..b00d0705fefa 100644 > > --- a/drivers/media/pci/intel/ipu6/ipu6.c > > +++ b/drivers/media/pci/intel/ipu6/ipu6.c > > @@ -464,11 +464,6 @@ static int ipu6_pci_config_setup(struct pci_dev *dev, u8 hw_ver) > > { > > int ret; > > > > - /* disable IPU6 PCI ATS on mtl ES2 */ > > - if (is_ipu6ep_mtl(hw_ver) && boot_cpu_data.x86_stepping == 0x2 && > > - pci_ats_supported(dev)) > > - pci_disable_ats(dev); > > - > > /* No PCI msi capability for IPU6EP */ > > if (is_ipu6ep(hw_ver) || is_ipu6ep_mtl(hw_ver)) { > > /* likely do nothing as msi not enabled by default */ > > >
diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c index 277af7cda8ee..b00d0705fefa 100644 --- a/drivers/media/pci/intel/ipu6/ipu6.c +++ b/drivers/media/pci/intel/ipu6/ipu6.c @@ -464,11 +464,6 @@ static int ipu6_pci_config_setup(struct pci_dev *dev, u8 hw_ver) { int ret; - /* disable IPU6 PCI ATS on mtl ES2 */ - if (is_ipu6ep_mtl(hw_ver) && boot_cpu_data.x86_stepping == 0x2 && - pci_ats_supported(dev)) - pci_disable_ats(dev); - /* No PCI msi capability for IPU6EP */ if (is_ipu6ep(hw_ver) || is_ipu6ep_mtl(hw_ver)) { /* likely do nothing as msi not enabled by default */
There was a hardware bug which need IPU6 driver to disable the ATS. This workaround is not needed anymore as the bug was fixed in hardware level. Signed-off-by: Hao Yao <hao.yao@intel.com> --- drivers/media/pci/intel/ipu6/ipu6.c | 5 ----- 1 file changed, 5 deletions(-)