mbox series

[V4,0/3] tty: serial: fsl_lpuart: cleanup lpuart driver

Message ID 20250321073950.108820-1-sherry.sun@nxp.com
Headers show
Series tty: serial: fsl_lpuart: cleanup lpuart driver | expand

Message

Sherry Sun March 21, 2025, 7:39 a.m. UTC 
Do some cleanup for lpuart driver, no functionality change.

Changes in V4:
1. Fix unused variable 'sport' warning in patch#2 reported by kernel test robot.

Changes in V3:
1. Add the change to covert unsigned char to u8 in the first patch as Jiri suggested.

Changes in V2:
1. Add the third patch to rename the register variables as Jiri suggested.

Sherry Sun (3):
  tty: serial: fsl_lpuart: Use u32 and u8 for register variables
  tty: serial: fsl_lpuart: use port struct directly to simply code
  tty: serial: fsl_lpuart: rename register variables more specifically

 drivers/tty/serial/fsl_lpuart.c | 472 ++++++++++++++++----------------
 1 file changed, 231 insertions(+), 241 deletions(-)

Comments

Greg KH April 11, 2025, 2:51 p.m. UTC | #1 
On Fri, Mar 21, 2025 at 03:39:47PM +0800, Sherry Sun wrote:
> Do some cleanup for lpuart driver, no functionality change.
> 
> Changes in V4:
> 1. Fix unused variable 'sport' warning in patch#2 reported by kernel test robot.
> 
> Changes in V3:
> 1. Add the change to covert unsigned char to u8 in the first patch as Jiri suggested.
> 
> Changes in V2:
> 1. Add the third patch to rename the register variables as Jiri suggested.
> 
> Sherry Sun (3):
>   tty: serial: fsl_lpuart: Use u32 and u8 for register variables
>   tty: serial: fsl_lpuart: use port struct directly to simply code
>   tty: serial: fsl_lpuart: rename register variables more specifically
> 
>  drivers/tty/serial/fsl_lpuart.c | 472 ++++++++++++++++----------------
>  1 file changed, 231 insertions(+), 241 deletions(-)
> 
> -- 
> 2.34.1
> 

None of this applies to 6.15-rc1, what went wrong?
Sherry Sun April 13, 2025, 11:56 a.m. UTC | #2 
> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Friday, April 11, 2025 10:51 PM
> To: Sherry Sun <sherry.sun@nxp.com>
> Cc: jirislaby@kernel.org; linux-serial@vger.kernel.org; linux-
> kernel@vger.kernel.org; imx@lists.linux.dev; Shenwei Wang
> <shenwei.wang@nxp.com>
> Subject: Re: [PATCH V4 0/3] tty: serial: fsl_lpuart: cleanup lpuart driver
> 
> On Fri, Mar 21, 2025 at 03:39:47PM +0800, Sherry Sun wrote:
> > Do some cleanup for lpuart driver, no functionality change.
> >
> > Changes in V4:
> > 1. Fix unused variable 'sport' warning in patch#2 reported by kernel test
> robot.
> >
> > Changes in V3:
> > 1. Add the change to covert unsigned char to u8 in the first patch as Jiri
> suggested.
> >
> > Changes in V2:
> > 1. Add the third patch to rename the register variables as Jiri suggested.
> >
> > Sherry Sun (3):
> >   tty: serial: fsl_lpuart: Use u32 and u8 for register variables
> >   tty: serial: fsl_lpuart: use port struct directly to simply code
> >   tty: serial: fsl_lpuart: rename register variables more specifically
> >
> >  drivers/tty/serial/fsl_lpuart.c | 472 ++++++++++++++++----------------
> >  1 file changed, 231 insertions(+), 241 deletions(-)
> >
> > --
> > 2.34.1
> >
> 
> None of this applies to 6.15-rc1, what went wrong?


Hi Greg,
I can see above patches are applied to L6.15-rc1 tree, please check
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/tty/serial/fsl_lpuart.c?h=v6.15-rc1

Best Regards
Sherry