Message ID | 20250407102528.1048589-1-parvathi@couthit.com |
---|---|
Headers | show |
Series | PRU-ICSSM Ethernet Driver | expand |
On Mon, 7 Apr 2025 15:55:17 +0530 Parvathi Pudi wrote: > The Programmable Real-Time Unit Industrial Communication Sub-system (PRU-ICSS) > is available on the TI SOCs in two flavors: Gigabit ICSS (ICSSG) and the older > Megabit ICSS (ICSSM). > > Support for ICSSG Dual-EMAC mode has already been mainlined [1] and the > fundamental components/drivers such as PRUSS driver, Remoteproc driver, > PRU-ICSS INTC, and PRU-ICSS IEP drivers are already available in the mainline > Linux kernel. The current set of patch series builds on top of these components > and introduces changes to support the Dual-EMAC using ICSSM on the TI AM57xx, > AM437x and AM335x devices. > > AM335x, AM437x and AM57xx devices may have either one or two PRU-ICSS instances > with two 32-bit RISC PRU cores. Each PRU core has (a) dedicated Ethernet interface > (MII, MDIO), timers, capture modules, and serial communication interfaces, and > (b) dedicated data and instruction RAM as well as shared RAM for inter PRU > communication within the PRU-ICSS. This was posted prior to the "net-next is OPEN" announcement: https://lore.kernel.org/all/20250407055403.7a8f40df@kernel.org/ In the interest of fairness towards those who correctly wait for the tree to be open I will ask you to repost this again, in a couple of days. Thanks!
> +#define PRUETH_MODULE_VERSION "0.2" > +static void icssm_emac_get_drvinfo(struct net_device *ndev, > + struct ethtool_drvinfo *info) > +{ > + strscpy(info->driver, PRUETH_MODULE_DESCRIPTION, sizeof(info->driver)); > + strscpy(info->version, PRUETH_MODULE_VERSION, sizeof(info->version)); Driver version numbers are pointless, they never change, but the kernel is changing all the time. Leave version blank, and the core will fill in the kernel version, which is useful. Andrew
> -----Original Message----- > From: Andrew Lunn <andrew@lunn.ch> > Sent: Monday, April 7, 2025 1:19 PM > To: Parvathi Pudi <parvathi@couthit.com> > Cc: danishanwar@ti.com; rogerq@kernel.org; andrew+netdev@lunn.ch; > davem@davemloft.net; Dumazet, Eric <edumazet@google.com>; > kuba@kernel.org; pabeni@redhat.com; robh@kernel.org; krzk+dt@kernel.org; > conor+dt@kernel.org; nm@ti.com; ssantosh@kernel.org; tony@atomide.com; > richardcochran@gmail.com; glaroque@baylibre.com; schnelle@linux.ibm.com; > m-karicheri2@ti.com; rdunlap@infradead.org; diogo.ivo@siemens.com; > basharath@couthit.com; horms@kernel.org; Keller, Jacob E > <jacob.e.keller@intel.com>; m-malladi@ti.com; javier.carrasco.cruz@gmail.com; > afd@ti.com; s-anna@ti.com; linux-arm-kernel@lists.infradead.org; > netdev@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-omap@vger.kernel.org; pratheesh@ti.com; > prajith@ti.com; vigneshr@ti.com; praneeth@ti.com; srk@ti.com; rogerq@ti.com; > krishna@couthit.com; pmohan@couthit.com; mohan@couthit.com > Subject: Re: [PATCH net-next v4 05/11] net: ti: prueth: Adds ethtool support for > ICSSM PRUETH Driver > > > +#define PRUETH_MODULE_VERSION "0.2" > > > +static void icssm_emac_get_drvinfo(struct net_device *ndev, > > + struct ethtool_drvinfo *info) > > +{ > > + strscpy(info->driver, PRUETH_MODULE_DESCRIPTION, sizeof(info- > >driver)); > > + strscpy(info->version, PRUETH_MODULE_VERSION, sizeof(info->version)); > > Driver version numbers are pointless, they never change, but the > kernel is changing all the time. Leave version blank, and the core > will fill in the kernel version, which is useful. > > Andrew It is also a long standing policy that in-tree drivers should not have versions separate from the kernel version. Thanks, Jake
Hi, > On Mon, 7 Apr 2025 15:55:17 +0530 Parvathi Pudi wrote: >> The Programmable Real-Time Unit Industrial Communication Sub-system (PRU-ICSS) >> is available on the TI SOCs in two flavors: Gigabit ICSS (ICSSG) and the older >> Megabit ICSS (ICSSM). >> >> Support for ICSSG Dual-EMAC mode has already been mainlined [1] and the >> fundamental components/drivers such as PRUSS driver, Remoteproc driver, >> PRU-ICSS INTC, and PRU-ICSS IEP drivers are already available in the mainline >> Linux kernel. The current set of patch series builds on top of these components >> and introduces changes to support the Dual-EMAC using ICSSM on the TI AM57xx, >> AM437x and AM335x devices. >> >> AM335x, AM437x and AM57xx devices may have either one or two PRU-ICSS instances >> with two 32-bit RISC PRU cores. Each PRU core has (a) dedicated Ethernet >> interface >> (MII, MDIO), timers, capture modules, and serial communication interfaces, and >> (b) dedicated data and instruction RAM as well as shared RAM for inter PRU >> communication within the PRU-ICSS. > > This was posted prior to the "net-next is OPEN" announcement: > https://lore.kernel.org/all/20250407055403.7a8f40df@kernel.org/ > > In the interest of fairness towards those who correctly wait > for the tree to be open I will ask you to repost this again, > in a couple of days. > Sure, we will resubmit the patches along with changes based on the feedback received from Andrew Lunn and Keller, Jacob E shortly. Thanks and Regards, Parvathi.
Hi, >> +#define PRUETH_MODULE_VERSION "0.2" > >> +static void icssm_emac_get_drvinfo(struct net_device *ndev, >> + struct ethtool_drvinfo *info) >> +{ >> + strscpy(info->driver, PRUETH_MODULE_DESCRIPTION, sizeof(info->driver)); >> + strscpy(info->version, PRUETH_MODULE_VERSION, sizeof(info->version)); > > Driver version numbers are pointless, they never change, but the > kernel is changing all the time. Leave version blank, and the core > will fill in the kernel version, which is useful. > Understood. We will address this in the next version. Thanks and Regards, Parvathi.
Hi, >> > +#define PRUETH_MODULE_VERSION "0.2" >> >> > +static void icssm_emac_get_drvinfo(struct net_device *ndev, >> > + struct ethtool_drvinfo *info) >> > +{ >> > + strscpy(info->driver, PRUETH_MODULE_DESCRIPTION, sizeof(info- >> >driver)); >> > + strscpy(info->version, PRUETH_MODULE_VERSION, sizeof(info->version)); >> >> Driver version numbers are pointless, they never change, but the >> kernel is changing all the time. Leave version blank, and the core >> will fill in the kernel version, which is useful. >> >> Andrew > > It is also a long standing policy that in-tree drivers should not have versions > separate from the kernel version. > Ok. We will leave the version field blank as suggested by Andrew and cleanup version will be resubmitted shortly. Thanks and Regards, Parvathi.