| Message ID | 20250327-a5-pinctrl-v1-0-49320349c463@amlogic.com |
|---|---|
| Headers | show |
| Series | Pinctrl: add amlogic a5 pinctrl node | expand |
Hi Conor,
Thanks for your advice.
On 2025/3/28 00:37, Conor Dooley wrote:
>
> ForwardedMessage.eml
>
> Subject:
> Re: [PATCH 1/2] dt-bindings: pinctl: amlogic,pinctrl-a4: Add compatible
> string for A5
> From:
> Conor Dooley <conor@kernel.org>
> Date:
> 2025/3/28 00:37
>
> To:
> xianwei.zhao@amlogic.com
> CC:
> Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh@kernel.org>,
> Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley
> <conor+dt@kernel.org>, Neil Armstrong <neil.armstrong@linaro.org>, Kevin
> Hilman <khilman@baylibre.com>, Jerome Brunet <jbrunet@baylibre.com>,
> Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
> linux-amlogic@lists.infradead.org, linux-gpio@vger.kernel.org,
> devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
> linux-arm-kernel@lists.infradead.org
>
>
> On Thu, Mar 27, 2025 at 05:26:35PM +0800, Xianwei Zhao via B4 Relay wrote:
>> From: Xianwei Zhao<xianwei.zhao@amlogic.com>
>>
>> Amlogic A5 SoCs uses the same pintrl controller as A4 SoCs. There is
>> no need for an extra compatible line in the driver, but add A5
>> compatible line for documentation.
>>
>> Signed-off-by: Xianwei Zhao<xianwei.zhao@amlogic.com>
>> ---
>> .../devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml | 9 +++++++--
>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml b/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml
>> index 8eb50cad61d5..a94f4dfb9a7f 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml
>> @@ -14,8 +14,13 @@ allOf:
>>
>> properties:
>> compatible:
>> - const: amlogic,pinctrl-a4
>> -
>> + oneOf:
>> + - enum:
>> + - amlogic,pinctrl-a4
> This one here only has a single entry, so could just be
> - const: amlogic,pinctrl-a4.
>
Will do.
> With that,
> Acked-by: Conor Dooley<conor.dooley@microchip.com>
>
>> + - items:
>> + - enum:
>> + - amlogic,pinctrl-a5
>> + - const: amlogic,pinctrl-a4
>> "#address-cells":
>> const: 2
>>
>>
>> --
>> 2.37.1
Add A5 pinctrl compatible string and device node. Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com> --- Xianwei Zhao (2): dt-bindings: pinctl: amlogic,pinctrl-a4: Add compatible string for A5 dts: arm64: amlogic: add a5 pinctrl node .../bindings/pinctrl/amlogic,pinctrl-a4.yaml | 9 ++- arch/arm64/boot/dts/amlogic/amlogic-a5.dtsi | 90 ++++++++++++++++++++++ 2 files changed, 97 insertions(+), 2 deletions(-) --- base-commit: 73a143e436311183186ab4b365a84c662f2c9651 change-id: 20250318-a5-pinctrl-f3c6c6aa0e7f Best regards,