diff mbox series

dt-bindings: soc: qcom,wcnss: Document local-mac-address

Message ID 20250317-wcnss-local-mac-v1-1-c7c60d4427be@ixit.cz
State New
Headers show
Series dt-bindings: soc: qcom,wcnss: Document local-mac-address | expand

Commit Message

David Heidelberg via B4 Relay March 17, 2025, 8:26 p.m. UTC 
From: David Heidelberg <david@ixit.cz>

The device and driver do support setting a custom MAC address.

Fixes: c49e9e95f4d1 ("dt: binding: Add Qualcomm WCNSS control binding")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml | 2 ++
 1 file changed, 2 insertions(+)


---
base-commit: e94bd4ec45ac156616da285a0bf03056cd7430fc
change-id: 20250317-wcnss-local-mac-57da1ca5feb9

Best regards,

Comments

Rob Herring March 18, 2025, 2:26 p.m. UTC | #1 
On Tue, Mar 18, 2025 at 10:07:22AM +0100, David Heidelberg wrote:
> On 18/03/2025 09:49, Krzysztof Kozlowski wrote:
> > On Mon, Mar 17, 2025 at 09:26:05PM +0100, David Heidelberg wrote:
> > > The device and driver do support setting a custom MAC address.
> > > 
> > > Fixes: c49e9e95f4d1 ("dt: binding: Add Qualcomm WCNSS control binding")
> > > Signed-off-by: David Heidelberg <david@ixit.cz>
> > > ---
> > >   Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml | 2 ++
> > >   1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
> > > index fd6db0ca98eb7e56d7399f55c408844d5e782805..6938dc4ccc2175a65f6f53c6d073fb72cf498b2c 100644
> > > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
> > > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
> > > @@ -68,6 +68,8 @@ properties:
> > >             - const: tx
> > >             - const: rx
> > > +      local-mac-address: true
> > 
> > Which referenced binding provides the definition of this property (its
> > type)? AFAIK, that's not a property of Wifi nodes.
> 
> Good catch!
> 
> Would you find reasonable to add the property to  wireless/ieee80211.yaml ?
> 
> I feel like this could be "shared" between ethernet and ieee80211, but have
> it twice in these two sounds acceptable to me.

Can you pick up and finish this series[1].

Rob

[1] https://lore.kernel.org/all/20230220140201.20450889@kernel.org/#r
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
index fd6db0ca98eb7e56d7399f55c408844d5e782805..6938dc4ccc2175a65f6f53c6d073fb72cf498b2c 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
@@ -68,6 +68,8 @@  properties:
           - const: tx
           - const: rx
 
+      local-mac-address: true
+
       qcom,smem-states:
         $ref: /schemas/types.yaml#/definitions/phandle-array
         maxItems: 2