mbox series

[0/2] arm64: dts: qcom: sm8550: camcc: Manage MMCX and MXC

Message ID 20250303225521.1780611-1-vladimir.zapolskiy@linaro.org
Headers show
Series arm64: dts: qcom: sm8550: camcc: Manage MMCX and MXC | expand

Message

Vladimir Zapolskiy March 3, 2025, 10:55 p.m. UTC
It was discovered that on SM8550 platform Camera Clock controller shall
manage MMCX and MXC power domains, otherwise MMIO access to CCI or CAMSS
breaks the execution, the problem has been discussed with Jagadeesh at
https://lore.kernel.org/all/a5540676-9402-45c4-b647-02fdc2b92233@quicinc.com/

Since 'power-domains' property becomes generalized, Rob asked to remove
its description, which is done in the first patch of the series, see
https://lore.kernel.org/all/20240927224833.GA159707-robh@kernel.org/

Vladimir Zapolskiy (2):
  dt-bindings: clock: qcom: sm8450-camcc: Allow to specify two power domains
  arm64: dts: qcom: sm8550: Additionally manage MXC power domain in camcc

 .../devicetree/bindings/clock/qcom,sm8450-camcc.yaml          | 4 +---
 arch/arm64/boot/dts/qcom/sm8550.dtsi                          | 3 ++-
 2 files changed, 3 insertions(+), 4 deletions(-)

Comments

Taniya Das March 13, 2025, 11:38 a.m. UTC | #1
On 3/4/2025 4:25 AM, Vladimir Zapolskiy wrote:
> It was discovered that on SM8550 platform Camera Clock controller shall
> manage MMCX and MXC power domains, otherwise MMIO access to CCI or CAMSS
> breaks the execution, the problem has been discussed with Jagadeesh at
> https://lore.kernel.org/all/a5540676-9402-45c4-b647-02fdc2b92233@quicinc.com/
> 
> Since 'power-domains' property becomes generalized, Rob asked to remove
> its description, which is done in the first patch of the series, see
> https://lore.kernel.org/all/20240927224833.GA159707-robh@kernel.org/
> 
> Vladimir Zapolskiy (2):
>   dt-bindings: clock: qcom: sm8450-camcc: Allow to specify two power domains
>   arm64: dts: qcom: sm8550: Additionally manage MXC power domain in camcc
> 

Hi Vladimir, as we are preparing to submit the code for multi-power
domain support for the clock controller in our series
(https://lore.kernel.org/all/20250306-videocc-pll-multi-pd-voting-v2-0-0cd00612bc0e@quicinc.com),
there has been a request to incorporate the CAMCC-related changes as
well. If you are okay with us including this series changes(maintaining
your authorship) in our series, then we can integrate them and address
any comments in our next submission.

>  .../devicetree/bindings/clock/qcom,sm8450-camcc.yaml          | 4 +---
>  arch/arm64/boot/dts/qcom/sm8550.dtsi                          | 3 ++-
>  2 files changed, 3 insertions(+), 4 deletions(-)
>
Jagadeesh Kona March 26, 2025, 11:46 a.m. UTC | #2
On 3/13/2025 5:08 PM, Taniya Das wrote:
> 
> 
> On 3/4/2025 4:25 AM, Vladimir Zapolskiy wrote:
>> It was discovered that on SM8550 platform Camera Clock controller shall
>> manage MMCX and MXC power domains, otherwise MMIO access to CCI or CAMSS
>> breaks the execution, the problem has been discussed with Jagadeesh at
>> https://lore.kernel.org/all/a5540676-9402-45c4-b647-02fdc2b92233@quicinc.com/
>>
>> Since 'power-domains' property becomes generalized, Rob asked to remove
>> its description, which is done in the first patch of the series, see
>> https://lore.kernel.org/all/20240927224833.GA159707-robh@kernel.org/
>>
>> Vladimir Zapolskiy (2):
>>   dt-bindings: clock: qcom: sm8450-camcc: Allow to specify two power domains
>>   arm64: dts: qcom: sm8550: Additionally manage MXC power domain in camcc
>>
> 
> Hi Vladimir, as we are preparing to submit the code for multi-power
> domain support for the clock controller in our series
> (https://lore.kernel.org/all/20250306-videocc-pll-multi-pd-voting-v2-0-0cd00612bc0e@quicinc.com),
> there has been a request to incorporate the CAMCC-related changes as
> well. If you are okay with us including this series changes(maintaining
> your authorship) in our series, then we can integrate them and address
> any comments in our next submission.
> 

Hi Vladimir,

I will be including your above 2 patches in the next version of my series[1] which adds
MXC PD support for SM8450, SM8650 camcc DT nodes since my series is dependent on above
bindings change. Doing so will fix the bot warnings reported[2] in this series as well
and I will fix if there are still any more warnings left and post.

[1] https://lore.kernel.org/all/cd092022-cf6d-421a-a29d-69f7f4f068b6@quicinc.com/
[2] https://lore.kernel.org/all/174105227313.195955.8409784191665720030.robh@kernel.org/

Thanks,
Jagadeesh

>>  .../devicetree/bindings/clock/qcom,sm8450-camcc.yaml          | 4 +---
>>  arch/arm64/boot/dts/qcom/sm8550.dtsi                          | 3 ++-
>>  2 files changed, 3 insertions(+), 4 deletions(-)
>>
> 
>