| Message ID | cover.1740932040.git.christophe.jaillet@wanadoo.fr |
|---|---|
| Headers | show |
| Series | bus: qcom-ssc-block-bus: Fix some error handling paths | expand |
On Sun, 02 Mar 2025 17:21:33 +0100, Christophe JAILLET wrote: > Patch 1 should be straight forward. It removes some ioumap() from > resources allocated with devm_ioremap_resource(). > > Patch 2 is more speculative. It releases some resources in the error > handling path of the probe, as done in the .remove() function. > > > [...] Applied, thanks! [1/2] bus: qcom-ssc-block-bus: Remove some duplicated iounmap() calls commit: a9ac4ba7dcace2b3b91e7b87bf0ba97c47edd94f [2/2] bus: qcom-ssc-block-bus: Fix the error handling path of qcom_ssc_block_bus_probe() commit: f41658cd081ad7697796b3dacd9a717a57919268 Best regards,
Patch 1 should be straight forward. It removes some ioumap() from resources allocated with devm_ioremap_resource(). Patch 2 is more speculative. It releases some resources in the error handling path of the probe, as done in the .remove() function. Finally, the .remove() function also has some pm_runtime_disable(&pdev->dev); pm_clk_destroy(&pdev->dev); calls. Usually pm_runtime_disable() is paired with pm_runtime_enable() and I would expect some pm_clk_add(() calls related to pm_clk_destroy(). Neither exists. So I wonder if these 2 calls are correct in the .remove() function. Thought? Christophe JAILLET (2): bus: qcom-ssc-block-bus: Remove some duplicated iounmap() calls bus: qcom-ssc-block-bus: Fix the error handling path of qcom_ssc_block_bus_probe() drivers/bus/qcom-ssc-block-bus.c | 34 ++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 15 deletions(-)