mbox series

[0/2] target/arm: SME vs FP enable fixes

Message ID 20250307190415.982049-1-richard.henderson@linaro.org
Headers show
Series target/arm: SME vs FP enable fixes | expand

Message

Richard Henderson March 7, 2025, 7:04 p.m. UTC 
If SME Streaming Mode is enabled, but FP is disabled, we get two
assertion failures within the translator.  Beyond the assertions,
this combination should succeed because we're executing on the
SME co-processor's registers, not the core cpu's AdvSIMD registers.


r~


Richard Henderson (2):
  target/arm: Make DisasContext.{fp,sve}_access_checked tristate
  target/arm: Simplify pstate_sm check in sve_access_check

 target/arm/tcg/translate-a64.h |  2 +-
 target/arm/tcg/translate.h     | 10 +++++++---
 target/arm/tcg/translate-a64.c | 35 +++++++++++++++++-----------------
 3 files changed, 25 insertions(+), 22 deletions(-)

Comments

Peter Maydell March 12, 2025, 2:39 p.m. UTC | #1 
On Fri, 7 Mar 2025 at 19:05, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> If SME Streaming Mode is enabled, but FP is disabled, we get two
> assertion failures within the translator.  Beyond the assertions,
> this combination should succeed because we're executing on the
> SME co-processor's registers, not the core cpu's AdvSIMD registers.

Patch 2 has a 'bool ret' declaration that needs to move to
the top of its block. Otherwise

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

and applied to target-arm.next with that minor tweak.

thanks
-- PMM