| Message ID | 20250228162359.14029-1-lima.gabriel.luz@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | staging: sm750fb: Fix CamelCase variable naming | expand |
Em sex, 2025-02-28 às 20:40 +0300, Dan Carpenter escreveu: > On Fri, Feb 28, 2025 at 01:23:54PM -0300, Gabriel Lima Luz wrote: > > Adhere to Linux kernel coding style. > > > > Reported by checkpatch: > > > > CHECK: Avoid CamelCase > > > > Signed-off-by: Gabriel Lima Luz <lima.gabriel.luz@gmail.com> > > --- > > drivers/staging/sm750fb/ddk750_power.h | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/staging/sm750fb/ddk750_power.h > > b/drivers/staging/sm750fb/ddk750_power.h > > index 63c9e8b6ffb3..33e852fe6949 100644 > > --- a/drivers/staging/sm750fb/ddk750_power.h > > +++ b/drivers/staging/sm750fb/ddk750_power.h > > @@ -3,10 +3,10 @@ > > #define DDK750_POWER_H__ > > > > enum dpms { > > - crtDPMS_ON = 0x0, > > - crtDPMS_STANDBY = 0x1, > > - crtDPMS_SUSPEND = 0x2, > > - crtDPMS_OFF = 0x3, > > + crt_DPMS_ON = 0x0, > > + crt_DPMS_STANDBY = 0x1, > > + crt_DPMS_SUSPEND = 0x2, > > + crt_DPMS_OFF = 0x3, > > }; > > > > It seems these are not used. Just delete them. > > regards, > dan carpenter > The dpms enum is used in the definition of the ddk750_set_dpms function in ddk750_power.h file and this function is called in ddk750_display.c on line 158. If I were to delete it, what changes should I make to the function mentioned above ? this is my first contribution, thanks for all the help. best regards, Gabriel Lima
diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h index 63c9e8b6ffb3..33e852fe6949 100644 --- a/drivers/staging/sm750fb/ddk750_power.h +++ b/drivers/staging/sm750fb/ddk750_power.h @@ -3,10 +3,10 @@ #define DDK750_POWER_H__ enum dpms { - crtDPMS_ON = 0x0, - crtDPMS_STANDBY = 0x1, - crtDPMS_SUSPEND = 0x2, - crtDPMS_OFF = 0x3, + crt_DPMS_ON = 0x0, + crt_DPMS_STANDBY = 0x1, + crt_DPMS_SUSPEND = 0x2, + crt_DPMS_OFF = 0x3, }; #define set_DAC(off) { \
Adhere to Linux kernel coding style. Reported by checkpatch: CHECK: Avoid CamelCase Signed-off-by: Gabriel Lima Luz <lima.gabriel.luz@gmail.com> --- drivers/staging/sm750fb/ddk750_power.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)