| Message ID | 20250303074552.3335186-1-zhoubinbin@loongson.cn |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: gpio: loongson: Add new loongson gpio chip compatible | expand |
On Mon, Mar 3, 2025 at 8:46 AM Binbin Zhou <zhoubinbin@loongson.cn> wrote: > The Loongson-7A2000 and Loongson-3A6000 share the same gpio chip model. > Just add them through driver_data. > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Tue, Mar 4, 2025 at 4:36 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Mon, Mar 3, 2025 at 8:46 AM Binbin Zhou <zhoubinbin@loongson.cn> wrote: > > > The Loongson-7A2000 and Loongson-3A6000 share the same gpio chip model. > > Just add them through driver_data. > > > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Acked-by: Huacai Chen <chenhuacai@loongson.cn> > > Yours, > Linus Walleij
On Tue, Mar 4, 2025 at 12:55 PM Binbin Zhou <zhoubb.aaron@gmail.com> wrote: > > > > > The naming convention here is a bit confusing, can't we have the > > naming of variables reflect the compatibles they refer to? > > > Emm... > > I named them that way to be consistent with the previous naming. > Of course, we could name them something like > “ls7a2000_acpi_gpio_data”, which might be better understood. > Also, do we need to rename all instances of “loongson_gpio_chip_data”? > Ah, nevermind then. I will apply it as is but yeah, we could consider something better in the future. Bart
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> On Mon, 03 Mar 2025 15:45:51 +0800, Binbin Zhou wrote: > Add the devicetree compatibles for Loongson-7A2000 and Loongson-3A6000 > gpio chip. > > Applied, thanks! [1/2] dt-bindings: gpio: loongson: Add new loongson gpio chip compatible commit: e4a345c55e1b9b5ab5212a93b081f666f71b303b [2/2] gpio: loongson-64bit: Add more gpio chip support commit: 44fe79020b91a1a8620e44d4f361b389e8fc552f Best regards,
diff --git a/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml b/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml index cf3b1b270aa8..b68159600e2b 100644 --- a/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml +++ b/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml @@ -20,7 +20,10 @@ properties: - loongson,ls2k2000-gpio1 - loongson,ls2k2000-gpio2 - loongson,ls3a5000-gpio + - loongson,ls3a6000-gpio # Loongson-3A6000 node GPIO - loongson,ls7a-gpio + - loongson,ls7a2000-gpio1 # LS7A2000 chipset GPIO + - loongson,ls7a2000-gpio2 # LS7A2000 ACPI GPIO - items: - const: loongson,ls2k1000-gpio - const: loongson,ls2k-gpio
Add the devicetree compatibles for Loongson-7A2000 and Loongson-3A6000 gpio chip. Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> --- Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml | 3 +++ 1 file changed, 3 insertions(+) base-commit: 8a5680bffb2f681688b5788751c767fc380ff9b7