diff mbox series

[4/5] coresight-tnoc: add node to configure flag type

Message ID 20250221-trace-noc-driver-v1-4-0a23fc643217@quicinc.com
State Superseded
Headers show
Series coresight: Add Coresight Trace NOC driver | expand

Commit Message

Yuanfang Zhang Feb. 21, 2025, 7:40 a.m. UTC 
flag_type：used to set the type of issued ATB FLAG packets.
0: 'FLAG' packets; 1: 'FLAG_TS' packets.

Signed-off-by: Yuanfang Zhang <quic_yuanfang@quicinc.com>
---
 drivers/hwtracing/coresight/coresight-tnoc.c | 42 +++++++++++++++++++++++++++-
 1 file changed, 41 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Feb. 22, 2025, 10:55 a.m. UTC | #1 
On 21/02/2025 08:40, Yuanfang Zhang wrote:
> +
> +static ssize_t flag_type_show(struct device *dev,
> +			      struct device_attribute *attr,
> +			      char *buf)
> +{
> +	struct trace_noc_drvdata *drvdata = dev_get_drvdata(dev->parent);
> +
> +	return sysfs_emit(buf, "%u\n", drvdata->flag_type);
> +}
> +static DEVICE_ATTR_RW(flag_type);
> +
>  static struct attribute *trace_noc_attrs[] = {
>  	&dev_attr_flush_req.attr,
>  	&dev_attr_flush_status.attr,
> +	&dev_attr_flag_type.attr,

Where is the ABI documentation?

Best regards,
Krzysztof
Yuanfang Zhang Feb. 28, 2025, 7:44 a.m. UTC | #2 
On 2/22/2025 6:55 PM, Krzysztof Kozlowski wrote:
> On 21/02/2025 08:40, Yuanfang Zhang wrote:
>> +
>> +static ssize_t flag_type_show(struct device *dev,
>> +			      struct device_attribute *attr,
>> +			      char *buf)
>> +{
>> +	struct trace_noc_drvdata *drvdata = dev_get_drvdata(dev->parent);
>> +
>> +	return sysfs_emit(buf, "%u\n", drvdata->flag_type);
>> +}
>> +static DEVICE_ATTR_RW(flag_type);
>> +
>>  static struct attribute *trace_noc_attrs[] = {
>>  	&dev_attr_flush_req.attr,
>>  	&dev_attr_flush_status.attr,
>> +	&dev_attr_flag_type.attr,
> 
> Where is the ABI documentation?
will update in V3.
> 
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/drivers/hwtracing/coresight/coresight-tnoc.c b/drivers/hwtracing/coresight/coresight-tnoc.c
index 25962af3850af106f7a8b7e1738ad93d44b81ee7..3ff3504603f66bd595484374f1cdac90c528b665 100644
--- a/drivers/hwtracing/coresight/coresight-tnoc.c
+++ b/drivers/hwtracing/coresight/coresight-tnoc.c
@@ -26,7 +26,7 @@  static ssize_t flush_req_store(struct device *dev,
 	unsigned long val;
 	u32 reg;
 
-	if (kstrtoul(buf, 10, &val))
+	if (kstrtoul(buf, 0, &val))
 		return -EINVAL;
 
 	if (val != 1)
@@ -73,9 +73,49 @@  static ssize_t flush_status_show(struct device *dev,
 }
 static DEVICE_ATTR_RO(flush_status);
 
+/*
+ * Sets the type of issued ATB FLAG packets:
+ * 0: 'FLAG' packets;
+ * 1: 'FLAG_TS' packets.
+ */
+static ssize_t flag_type_store(struct device *dev,
+			       struct device_attribute *attr,
+			       const char *buf,
+			       size_t size)
+{
+	struct trace_noc_drvdata *drvdata = dev_get_drvdata(dev->parent);
+	unsigned long val;
+
+	if (kstrtoul(buf, 10, &val))
+		return -EINVAL;
+
+	if (val != 1 && val != 0)
+		return -EINVAL;
+
+	spin_lock(&drvdata->spinlock);
+	if (val)
+		drvdata->flag_type = FLAG_TS;
+	else
+		drvdata->flag_type = FLAG;
+	spin_unlock(&drvdata->spinlock);
+
+	return size;
+}
+
+static ssize_t flag_type_show(struct device *dev,
+			      struct device_attribute *attr,
+			      char *buf)
+{
+	struct trace_noc_drvdata *drvdata = dev_get_drvdata(dev->parent);
+
+	return sysfs_emit(buf, "%u\n", drvdata->flag_type);
+}
+static DEVICE_ATTR_RW(flag_type);
+
 static struct attribute *trace_noc_attrs[] = {
 	&dev_attr_flush_req.attr,
 	&dev_attr_flush_status.attr,
+	&dev_attr_flag_type.attr,
 	NULL,
 };