| Message ID | CWLP123MB5473933B9B97137828ACC6A6C5EB2@CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM |
|---|---|
| Headers | show |
| Series | LED1202 / leds-st1202 fixes and improvements | expand |
On Sat, 01 Feb 2025, Manuel Fombuena wrote: > Collection of patches for the recently added leds-st1202 driver. It is the > same patchset sent on 2025-01-17. The cover letter wasn't properly threaded > with the patches that time, so apologies for that. > > Obvious from the individual descriptions, but as a summary: > > - 0001: fix a NULL pointer access error that occurs when LEDs are > registered but the LED driver is not fully initialized > - 0002: initialize the LED driver before any DT LED initialization is done > - 0003: some spacing and typo edits > - 0004: include the appropriate select in Kconfig to make sure the > required Pattern trigger driver is available. > - 0005: remove .rst extension on Documentation/leds/index.rst Stripping the separators from patch file names and pasting them culminates in a terrible summary. In no way does this cover-letter describe what you're trying to achieve, why you're trying to achieve it and the consequences for not applying the set. Nor does it communicate any merge intentions (which is required due to the assumptions made, as described in our previous conversation).
On Thu, 13 Feb 2025, Lee Jones wrote: > Stripping the separators from patch file names and pasting them > culminates in a terrible summary. In no way does this cover-letter > describe what you're trying to achieve, why you're trying to achieve it > and the consequences for not applying the set. Nor does it communicate > any merge intentions (which is required due to the assumptions made, as > described in our previous conversation). Do the messages in the diff section of the patches need similar improvements? -- Manuel Fombuena
Collection of patches for the recently added leds-st1202 driver. It is the same patchset sent on 2025-01-17. The cover letter wasn't properly threaded with the patches that time, so apologies for that. Obvious from the individual descriptions, but as a summary: - 0001: fix a NULL pointer access error that occurs when LEDs are registered but the LED driver is not fully initialized - 0002: initialize the LED driver before any DT LED initialization is done - 0003: some spacing and typo edits - 0004: include the appropriate select in Kconfig to make sure the required Pattern trigger driver is available. - 0005: remove .rst extension on Documentation/leds/index.rst Manuel Fombuena (5): leds: leds-st1202: fix NULL pointer access on race condition leds: leds-st1202: initialize hardware before DT node child operations leds: leds-st1202: spacing and proofreading editing leds: Kconfig: leds-st1202: add select for required LEDS_TRIGGER_PATTERN Documentation: leds: remove .rst extension for leds-st1202 on index Documentation/leds/index.rst | 2 +- drivers/leds/Kconfig | 1 + drivers/leds/leds-st1202.c | 73 ++++++++++++++++++------------------ 3 files changed, 38 insertions(+), 38 deletions(-)