| Message ID | f5ea6c5c-1904-22a4-72f2-d4050878dd26@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [RESEND,v2] Bluetooth: hci_uart: fix race during initialization | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=929721 ---Test result--- Test Summary: CheckPatch PENDING 0.29 seconds GitLint PENDING 0.19 seconds SubjectPrefix PASS 0.09 seconds BuildKernel PASS 24.53 seconds CheckAllWarning PASS 27.01 seconds CheckSparse PASS 30.67 seconds BuildKernel32 PASS 24.47 seconds TestRunnerSetup PASS 428.20 seconds TestRunner_l2cap-tester PASS 23.35 seconds TestRunner_iso-tester PASS 33.47 seconds TestRunner_bnep-tester PASS 4.72 seconds TestRunner_mgmt-tester FAIL 118.88 seconds TestRunner_rfcomm-tester PASS 7.58 seconds TestRunner_sco-tester PASS 9.33 seconds TestRunner_ioctl-tester PASS 7.97 seconds TestRunner_mesh-tester PASS 5.85 seconds TestRunner_smp-tester PASS 6.93 seconds TestRunner_userchan-tester PASS 4.97 seconds IncrementalBuild PENDING 0.76 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: TestRunner_mgmt-tester - FAIL Desc: Run mgmt-tester with test-runner Output: Total: 490, Passed: 484 (98.8%), Failed: 2, Not Run: 4 Failed Test Cases LL Privacy - Add Device 2 (2 Devices to AL) Failed 0.162 seconds LL Privacy - Add Device 3 (AL is full) Failed 0.193 seconds ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Sat, 1 Feb 2025 19:24:31 +0300 you wrote: > 'hci_register_dev()' calls power up function, which is executed by > kworker - 'hci_power_on()'. This function does access to bluetooth chip > using callbacks from 'hci_ldisc.c', for example 'hci_uart_send_frame()'. > Now 'hci_uart_send_frame()' checks 'HCI_UART_PROTO_READY' bit set, and > if not - it fails. Problem is that 'HCI_UART_PROTO_READY' is set after > 'hci_register_dev()', and there is tiny chance that 'hci_power_on()' will > be executed before setting this bit. In that case HCI init logic fails. > > [...] Here is the summary with links: - [RESEND,v2] Bluetooth: hci_uart: fix race during initialization https://git.kernel.org/bluetooth/bluetooth-next/c/c411c62cc133 You are awesome, thank you!
diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c index 30192bb083549..07b9aa09bbe2e 100644 --- a/drivers/bluetooth/hci_ldisc.c +++ b/drivers/bluetooth/hci_ldisc.c @@ -704,12 +704,13 @@ static int hci_uart_set_proto(struct hci_uart *hu, int id) hu->proto = p; + set_bit(HCI_UART_PROTO_READY, &hu->flags); + err = hci_uart_register_dev(hu); if (err) { return err; } - set_bit(HCI_UART_PROTO_READY, &hu->flags); return 0; }
'hci_register_dev()' calls power up function, which is executed by kworker - 'hci_power_on()'. This function does access to bluetooth chip using callbacks from 'hci_ldisc.c', for example 'hci_uart_send_frame()'. Now 'hci_uart_send_frame()' checks 'HCI_UART_PROTO_READY' bit set, and if not - it fails. Problem is that 'HCI_UART_PROTO_READY' is set after 'hci_register_dev()', and there is tiny chance that 'hci_power_on()' will be executed before setting this bit. In that case HCI init logic fails. Patch moves setting of 'HCI_UART_PROTO_READY' before calling function 'hci_uart_register_dev()'. Signed-off-by: Arseniy Krasnov <oxffffaa@gmail.com> --- Changelog v1->v2: * Move 'set_bit()' before 'hci_uart_register_dev()' instead of adding new bit 'HCI_UART_PROTO_INIT'. drivers/bluetooth/hci_ldisc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)