| Message ID | 20250129212328.1627891-1-alexeymin@postmarketos.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/3] dt-bindings: clock: gcc-sdm660: Add missing SDCC resets | expand |
On Thu, Jan 30, 2025 at 12:23:25AM +0300, Alexey Minnekhanov wrote: > Add resets for eMMC/SD card blocks that were missed during initial > driver submission. > > Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org> > Fixes: f2a76a2955c0 ("clk: qcom: Add Global Clock controller (GCC) driver for SDM660") Your SoB is always the last tag, but repeating what I asked during previous review - what sort of bug is here? Missing feature is not a bug per se. Best regards, Krzysztof
On 1/30/25 11:35 AM, Krzysztof Kozlowski wrote: > On Thu, Jan 30, 2025 at 12:23:25AM +0300, Alexey Minnekhanov wrote: >> Add resets for eMMC/SD card blocks that were missed during initial >> driver submission. >> >> Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org> >> Fixes: f2a76a2955c0 ("clk: qcom: Add Global Clock controller (GCC) driver for SDM660") > > Your SoB is always the last tag, but repeating what I asked during > previous review - what sort of bug is here? Missing feature is not a bug > per se. > > Best regards, > Krzysztof > I was hesitant about adding fixes tag myself, because there is no any user-observable bug being fixed here. In fact the behavior is unchanged, eMMC and SD worked fine before this and still work fine with this patch. From Linux side this is mostly for consistency with other younger/sibling SoCs, like MSM8998 & 8996 all have these resets specified. This will probably be much more useful for U-Boot port. Perhaps fixes tag should be removed completely? -- Regards, Alexey
diff --git a/include/dt-bindings/clock/qcom,gcc-sdm660.h b/include/dt-bindings/clock/qcom,gcc-sdm660.h index df8a6f3d367e..74c22f67da21 100644 --- a/include/dt-bindings/clock/qcom,gcc-sdm660.h +++ b/include/dt-bindings/clock/qcom,gcc-sdm660.h @@ -153,5 +153,7 @@ #define GCC_USB_30_BCR 7 #define GCC_USB_PHY_CFG_AHB2PHY_BCR 8 #define GCC_MSS_RESTART 9 +#define GCC_SDCC1_BCR 10 +#define GCC_SDCC2_BCR 11 #endif
Add resets for eMMC/SD card blocks that were missed during initial driver submission. Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org> Fixes: f2a76a2955c0 ("clk: qcom: Add Global Clock controller (GCC) driver for SDM660") --- include/dt-bindings/clock/qcom,gcc-sdm660.h | 2 ++ 1 file changed, 2 insertions(+)