| Message ID | 20250125165804.11486-1-deaner92@yahoo.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Bluetooth: Unnecessary braces around single line statment. | expand |
Dear Paul, I have changed the subject. Fixes: Coding style, unnecessary braces On Sun, Jan 26, 2025 at 09:02:04AM +0100, Paul Menzel wrote: > Dear Jeremy, > > > Thank you for your patch. Could you please make the summary/title a > statement, and remove the dot/period at the end: > > Bluetooth: Remove unnecessary braces around single line statement > > Am 25.01.25 um 17:58 schrieb deaner92@yahoo.com: > > From: Jeremy Clifton <deaner92@yahoo.com> > > > > Warning found with checkpatch.pl script. Removed unnecessary braces. > > I’d use imperative mood for the second sentence: > > Remove unnecessary braces. > > Also please add a Fixes: tag. > > > Signed-off-by: Jeremy Clifton <deaner92@yahoo.com> > > --- > > drivers/bluetooth/bfusb.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c > > index cab93935cc7f..0d6ad50da046 100644 > > --- a/drivers/bluetooth/bfusb.c > > +++ b/drivers/bluetooth/bfusb.c > > @@ -365,9 +365,8 @@ static void bfusb_rx_complete(struct urb *urb) > > buf += 3; > > } > > - if (count < len) { > > + if (count < len) > > bt_dev_err(data->hdev, "block extends over URB buffer ranges"); > > - } > > if ((hdr & 0xe1) == 0xc1) > > bfusb_recv_block(data, hdr, buf, len); > > Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> > > > Kind regards, > > Paul
> I have changed the subject. > > Fixes: Coding style, unnecessary braces See also once more: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n145 Is such a tag really relevant for a coding style adjustment? https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22 Regards, Markus
On Mon, Jan 27, 2025 at 05:17:20PM +0100, Markus Elfring wrote: > See also once more: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n145 I read it. > Is such a tag really relevant for a coding style adjustment? Is it? I think it would work. So before I submit my patch I'll need to add a Fixes: line. I have already edited my commit message. How can I find the SHA-1code of my commit from 1-25
Hi Jeremy, On Mon, Jan 27, 2025 at 4:30 PM Jeremy Dean <deaner92@yahoo.com> wrote: > > On Mon, Jan 27, 2025 at 05:17:20PM +0100, Markus Elfring wrote: > > See also once more: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n145 > > I read it. > > > Is such a tag really relevant for a coding style adjustment? > Is it? I think it would work. So before I submit my patch I'll need to add > a Fixes: line. I have already edited my commit message. How can I find > the SHA-1code of my commit from 1-25 I normally don't require Fixes tag for coding style adjustments submitted to bluetooth-next, these are not typically backported since there is no change on the logic or final binary.
diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c index cab93935cc7f..0d6ad50da046 100644 --- a/drivers/bluetooth/bfusb.c +++ b/drivers/bluetooth/bfusb.c @@ -365,9 +365,8 @@ static void bfusb_rx_complete(struct urb *urb) buf += 3; } - if (count < len) { + if (count < len) bt_dev_err(data->hdev, "block extends over URB buffer ranges"); - } if ((hdr & 0xe1) == 0xc1) bfusb_recv_block(data, hdr, buf, len);