| Message ID | 20250116084702.3473176-1-catalin.popescu@leica-geosystems.com |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next,v2,1/2] dt-bindings: net: rfkill-gpio: enable booting in blocked state | expand |
On Thu, Jan 16, 2025 at 09:47:01AM +0100, Catalin Popescu wrote: > By default, rfkill state is set to unblocked. Sometimes, we want to boot > in blocked state and let the application unblock the rfkill. > > Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com> > --- > Changes in v2: > - change "default-blocked" type from boolean to flag > --- > Documentation/devicetree/bindings/net/rfkill-gpio.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml > index 9630c8466fac..4a706a41ab38 100644 > --- a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml > +++ b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml > @@ -32,6 +32,10 @@ properties: > shutdown-gpios: > maxItems: 1 > > + default-blocked: > + $ref: /schemas/types.yaml#/definitions/flag > + description: configure rfkill state as blocked at boot I am assuming rfkill does not have third state possible, so it is only off or on. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 17/01/2025 09:56, Krzysztof Kozlowski wrote: > This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email. > > > On Thu, Jan 16, 2025 at 09:47:01AM +0100, Catalin Popescu wrote: >> By default, rfkill state is set to unblocked. Sometimes, we want to boot >> in blocked state and let the application unblock the rfkill. >> >> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com> >> --- >> Changes in v2: >> - change "default-blocked" type from boolean to flag >> --- >> Documentation/devicetree/bindings/net/rfkill-gpio.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml >> index 9630c8466fac..4a706a41ab38 100644 >> --- a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml >> +++ b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml >> @@ -32,6 +32,10 @@ properties: >> shutdown-gpios: >> maxItems: 1 >> >> + default-blocked: >> + $ref: /schemas/types.yaml#/definitions/flag >> + description: configure rfkill state as blocked at boot > I am assuming rfkill does not have third state possible, so it is only > off or on. Indeed, only on/off. > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thanks! BR, Catalin > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml index 9630c8466fac..4a706a41ab38 100644 --- a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml +++ b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml @@ -32,6 +32,10 @@ properties: shutdown-gpios: maxItems: 1 + default-blocked: + $ref: /schemas/types.yaml#/definitions/flag + description: configure rfkill state as blocked at boot + required: - compatible - radio-type @@ -48,4 +52,5 @@ examples: label = "rfkill-pcie-wlan"; radio-type = "wlan"; shutdown-gpios = <&gpio2 25 GPIO_ACTIVE_HIGH>; + default-blocked; };
By default, rfkill state is set to unblocked. Sometimes, we want to boot in blocked state and let the application unblock the rfkill. Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com> --- Changes in v2: - change "default-blocked" type from boolean to flag --- Documentation/devicetree/bindings/net/rfkill-gpio.yaml | 5 +++++ 1 file changed, 5 insertions(+) base-commit: 25cc469d6d344f5772e9fb6a5cf9d82a690afe68 prerequisite-patch-id: 0000000000000000000000000000000000000000