diff mbox series

watchdog: cros-ec: Add newlines to printks

Message ID 20250116224605.110870-1-swboyd@chromium.org
State New
Headers show
Series watchdog: cros-ec: Add newlines to printks | expand

Commit Message

Stephen Boyd Jan. 16, 2025, 10:46 p.m. UTC 
Add newlines to printk messages so that the next record is more easily
readable.

Cc: Lukasz Majczak <lma@chromium.org>
Cc: Benson Leung <bleung@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
 drivers/watchdog/cros_ec_wdt.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)


base-commit: 5bc55a333a2f7316b58edc7573e8e893f7acb532

Comments

Guenter Roeck Jan. 16, 2025, 10:54 p.m. UTC | #1 
On 1/16/25 14:46, Stephen Boyd wrote:
> Add newlines to printk messages so that the next record is more easily
> readable.
> 
> Cc: Lukasz Majczak <lma@chromium.org>
> Cc: Benson Leung <bleung@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/cros_ec_wdt.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/watchdog/cros_ec_wdt.c b/drivers/watchdog/cros_ec_wdt.c
> index ba045e29f9a5..716c23f4388c 100644
> --- a/drivers/watchdog/cros_ec_wdt.c
> +++ b/drivers/watchdog/cros_ec_wdt.c
> @@ -58,7 +58,7 @@ static int cros_ec_wdt_ping(struct watchdog_device *wdd)
>   	arg.req.command = EC_HANG_DETECT_CMD_RELOAD;
>   	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
>   	if (ret < 0)
> -		dev_dbg(wdd->parent, "Failed to ping watchdog (%d)", ret);
> +		dev_dbg(wdd->parent, "Failed to ping watchdog (%d)\n", ret);
>   
>   	return ret;
>   }
> @@ -74,7 +74,7 @@ static int cros_ec_wdt_start(struct watchdog_device *wdd)
>   	arg.req.reboot_timeout_sec = wdd->timeout;
>   	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
>   	if (ret < 0)
> -		dev_dbg(wdd->parent, "Failed to start watchdog (%d)", ret);
> +		dev_dbg(wdd->parent, "Failed to start watchdog (%d)\n", ret);
>   
>   	return ret;
>   }
> @@ -88,7 +88,7 @@ static int cros_ec_wdt_stop(struct watchdog_device *wdd)
>   	arg.req.command = EC_HANG_DETECT_CMD_CANCEL;
>   	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
>   	if (ret < 0)
> -		dev_dbg(wdd->parent, "Failed to stop watchdog (%d)", ret);
> +		dev_dbg(wdd->parent, "Failed to stop watchdog (%d)\n", ret);
>   
>   	return ret;
>   }
> @@ -136,7 +136,7 @@ static int cros_ec_wdt_probe(struct platform_device *pdev)
>   	arg.req.command = EC_HANG_DETECT_CMD_GET_STATUS;
>   	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
>   	if (ret < 0)
> -		return dev_err_probe(dev, ret, "Failed to get watchdog bootstatus");
> +		return dev_err_probe(dev, ret, "Failed to get watchdog bootstatus\n");
>   
>   	wdd->parent = &pdev->dev;
>   	wdd->info = &cros_ec_wdt_ident;
> @@ -150,7 +150,7 @@ static int cros_ec_wdt_probe(struct platform_device *pdev)
>   	arg.req.command = EC_HANG_DETECT_CMD_CLEAR_STATUS;
>   	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
>   	if (ret < 0)
> -		return dev_err_probe(dev, ret, "Failed to clear watchdog bootstatus");
> +		return dev_err_probe(dev, ret, "Failed to clear watchdog bootstatus\n");
>   
>   	watchdog_stop_on_reboot(wdd);
>   	watchdog_stop_on_unregister(wdd);
> 
> base-commit: 5bc55a333a2f7316b58edc7573e8e893f7acb532
Benson Leung Jan. 16, 2025, 10:58 p.m. UTC | #2 
On Thu, Jan 16, 2025 at 02:46:04PM -0800, Stephen Boyd wrote:
> Add newlines to printk messages so that the next record is more easily
> readable.
> 
> Cc: Lukasz Majczak <lma@chromium.org>
> Cc: Benson Leung <bleung@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>

Reviewed-by: Benson Leung <bleung@chromium.org>

> ---
>  drivers/watchdog/cros_ec_wdt.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/watchdog/cros_ec_wdt.c b/drivers/watchdog/cros_ec_wdt.c
> index ba045e29f9a5..716c23f4388c 100644
> --- a/drivers/watchdog/cros_ec_wdt.c
> +++ b/drivers/watchdog/cros_ec_wdt.c
> @@ -58,7 +58,7 @@ static int cros_ec_wdt_ping(struct watchdog_device *wdd)
>  	arg.req.command = EC_HANG_DETECT_CMD_RELOAD;
>  	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
>  	if (ret < 0)
> -		dev_dbg(wdd->parent, "Failed to ping watchdog (%d)", ret);
> +		dev_dbg(wdd->parent, "Failed to ping watchdog (%d)\n", ret);
>  
>  	return ret;
>  }
> @@ -74,7 +74,7 @@ static int cros_ec_wdt_start(struct watchdog_device *wdd)
>  	arg.req.reboot_timeout_sec = wdd->timeout;
>  	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
>  	if (ret < 0)
> -		dev_dbg(wdd->parent, "Failed to start watchdog (%d)", ret);
> +		dev_dbg(wdd->parent, "Failed to start watchdog (%d)\n", ret);
>  
>  	return ret;
>  }
> @@ -88,7 +88,7 @@ static int cros_ec_wdt_stop(struct watchdog_device *wdd)
>  	arg.req.command = EC_HANG_DETECT_CMD_CANCEL;
>  	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
>  	if (ret < 0)
> -		dev_dbg(wdd->parent, "Failed to stop watchdog (%d)", ret);
> +		dev_dbg(wdd->parent, "Failed to stop watchdog (%d)\n", ret);
>  
>  	return ret;
>  }
> @@ -136,7 +136,7 @@ static int cros_ec_wdt_probe(struct platform_device *pdev)
>  	arg.req.command = EC_HANG_DETECT_CMD_GET_STATUS;
>  	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
>  	if (ret < 0)
> -		return dev_err_probe(dev, ret, "Failed to get watchdog bootstatus");
> +		return dev_err_probe(dev, ret, "Failed to get watchdog bootstatus\n");
>  
>  	wdd->parent = &pdev->dev;
>  	wdd->info = &cros_ec_wdt_ident;
> @@ -150,7 +150,7 @@ static int cros_ec_wdt_probe(struct platform_device *pdev)
>  	arg.req.command = EC_HANG_DETECT_CMD_CLEAR_STATUS;
>  	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
>  	if (ret < 0)
> -		return dev_err_probe(dev, ret, "Failed to clear watchdog bootstatus");
> +		return dev_err_probe(dev, ret, "Failed to clear watchdog bootstatus\n");
>  
>  	watchdog_stop_on_reboot(wdd);
>  	watchdog_stop_on_unregister(wdd);
> 
> base-commit: 5bc55a333a2f7316b58edc7573e8e893f7acb532
> -- 
> https://chromeos.dev
>
diff mbox series

Patch

diff --git a/drivers/watchdog/cros_ec_wdt.c b/drivers/watchdog/cros_ec_wdt.c
index ba045e29f9a5..716c23f4388c 100644
--- a/drivers/watchdog/cros_ec_wdt.c
+++ b/drivers/watchdog/cros_ec_wdt.c
@@ -58,7 +58,7 @@  static int cros_ec_wdt_ping(struct watchdog_device *wdd)
 	arg.req.command = EC_HANG_DETECT_CMD_RELOAD;
 	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
 	if (ret < 0)
-		dev_dbg(wdd->parent, "Failed to ping watchdog (%d)", ret);
+		dev_dbg(wdd->parent, "Failed to ping watchdog (%d)\n", ret);
 
 	return ret;
 }
@@ -74,7 +74,7 @@  static int cros_ec_wdt_start(struct watchdog_device *wdd)
 	arg.req.reboot_timeout_sec = wdd->timeout;
 	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
 	if (ret < 0)
-		dev_dbg(wdd->parent, "Failed to start watchdog (%d)", ret);
+		dev_dbg(wdd->parent, "Failed to start watchdog (%d)\n", ret);
 
 	return ret;
 }
@@ -88,7 +88,7 @@  static int cros_ec_wdt_stop(struct watchdog_device *wdd)
 	arg.req.command = EC_HANG_DETECT_CMD_CANCEL;
 	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
 	if (ret < 0)
-		dev_dbg(wdd->parent, "Failed to stop watchdog (%d)", ret);
+		dev_dbg(wdd->parent, "Failed to stop watchdog (%d)\n", ret);
 
 	return ret;
 }
@@ -136,7 +136,7 @@  static int cros_ec_wdt_probe(struct platform_device *pdev)
 	arg.req.command = EC_HANG_DETECT_CMD_GET_STATUS;
 	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
 	if (ret < 0)
-		return dev_err_probe(dev, ret, "Failed to get watchdog bootstatus");
+		return dev_err_probe(dev, ret, "Failed to get watchdog bootstatus\n");
 
 	wdd->parent = &pdev->dev;
 	wdd->info = &cros_ec_wdt_ident;
@@ -150,7 +150,7 @@  static int cros_ec_wdt_probe(struct platform_device *pdev)
 	arg.req.command = EC_HANG_DETECT_CMD_CLEAR_STATUS;
 	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
 	if (ret < 0)
-		return dev_err_probe(dev, ret, "Failed to clear watchdog bootstatus");
+		return dev_err_probe(dev, ret, "Failed to clear watchdog bootstatus\n");
 
 	watchdog_stop_on_reboot(wdd);
 	watchdog_stop_on_unregister(wdd);