| Message ID | 20250116223915.430263-1-s-ramamoorthy@ti.com |
|---|---|
| Headers | show |
| Series | Add TI TPS65214 PMIC MFD Support | expand |
On 16/01/2025 23:39, Shree Ramamoorthy wrote: > Use chip ID and chip_data struct to differentiate between 3 PMIC devices in > probe(). Add TPS65214 resource information. Update descriptions and > copyright information to reflect the driver supports 3 PMIC devices. > > Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com> > --- > static struct tps65219_chip_data chip_info_table[] = { > + [TPS65214] = { > + .irq_chip = &tps65214_irq_chip, > + .cells = tps65214_cells, > + .n_cells = ARRAY_SIZE(tps65214_cells), > + }, > [TPS65215] = { > .irq_chip = &tps65215_irq_chip, > .cells = tps65215_cells, > @@ -421,6 +542,7 @@ static int tps65219_probe(struct i2c_client *client) > } > > static const struct of_device_id of_tps65219_match_table[] = { > + { .compatible = "ti,tps65214", .data = (void *)TPS65214, }, Where is the binding patch? It cannot be sent separately. > { .compatible = "ti,tps65215", .data = (void *)TPS65215, }, > { .compatible = "ti,tps65219", .data = (void *)TPS65219, }, Best regards, Krzysztof
On 16/01/2025 23:39, Shree Ramamoorthy wrote: > TPS65214 is a Power Management Integrated Circuit (PMIC) that has > significant register map overlap with TPS65215 and TPS65219. The series > introduces TPS65214 and adds the device to the multi-PMIC support driver. > > This follow-up series is dependent on: > Commit d23b7176df4a ("regulator: dt-bindings: Add TI TPS65214 PMIC bindings") What is this commit? Which tree? Recent next does not have it. The other thread said it depends on this patch, so how do you see it being merged? A depends on B, B depends on A. If A gets merged first: broken kernel. If B gets merged first: broken kernel? So what does this dependency and commit even mean? Best regards, Krzysztof
TPS65214 is a Power Management Integrated Circuit (PMIC) that has significant register map overlap with TPS65215 and TPS65219. The series introduces TPS65214 and adds the device to the multi-PMIC support driver. This follow-up series is dependent on: Commit d23b7176df4a ("regulator: dt-bindings: Add TI TPS65214 PMIC bindings") TPS65215 Driver Series: GPIO: https://lore.kernel.org/all/20250113225530.124213-1-s-ramamoorthy@ti.com/ MFD: https://lore.kernel.org/all/20250113230750.124843-1-s-ramamoorthy@ti.com/ Reg: https://lore.kernel.org/all/20250113231018.125426-1-s-ramamoorthy@ti.com/ Input: https://lore.kernel.org/all/20241226220049.398794-1-s-ramamoorthy@ti.com/ TPS65219 Cleanup Series: GPIO: https://lore.kernel.org/all/20241217204755.1011731-1-s-ramamoorthy@ti.com/ MFD: https://lore.kernel.org/all/20241217204935.1012106-1-s-ramamoorthy@ti.com/ Reg: https://lore.kernel.org/all/20241217204526.1010989-1-s-ramamoorthy@ti.com/ - TPS65214 is a Power Management IC with 3 Buck regulators and 2 LDOs. - TPS65214 has 2 LDOS and 1 GPO, whereas TPS65219 has 4 LDOs and 2 GPOs. - TPS65214's LDO1 maps to TPS65219's LDO3. - A key difference between TPS65215 & TPS65214 are the LDO current and voltage output ranges and the configurable options available. - The remaining features for both devices are the same. TPS65214 TRM: https://www.ti.com/lit/pdf/slvud30 AM62L + TPS65214 Test Logs: https://gist.github.com/ramamoorthyhs/0793f7813332d94423ca1baee02f62c9 Shree Ramamoorthy (1): mfd: tps65214: Add support for TI TPS65214 PMIC drivers/mfd/tps65219.c | 126 ++++++++++++++++++++++++++++++++++- include/linux/mfd/tps65219.h | 65 ++++++++++++++++-- 2 files changed, 184 insertions(+), 7 deletions(-)