mbox series

[v1,0/1] Add TI TPS65214 PMIC Input Support

Message ID 20250116224009.430622-1-s-ramamoorthy@ti.com
Headers show
Series Add TI TPS65214 PMIC Input Support | expand

Message

Shree Ramamoorthy Jan. 16, 2025, 10:40 p.m. UTC 
TPS65214 is a Power Management Integrated Circuit (PMIC) that has
significant register map overlap with TPS65215 and TPS65219. The series 
introduces TPS65214 and adds the device to the multi-PMIC support driver.

TPS65215 Driver Series:
GPIO: https://lore.kernel.org/all/20250113225530.124213-1-s-ramamoorthy@ti.com/
MFD: https://lore.kernel.org/all/20250113230750.124843-1-s-ramamoorthy@ti.com/
Reg: https://lore.kernel.org/all/20250113231018.125426-1-s-ramamoorthy@ti.com/
Input: https://lore.kernel.org/all/20241226220049.398794-1-s-ramamoorthy@ti.com/

TPS65219 Cleanup Series:
GPIO: https://lore.kernel.org/all/20241217204755.1011731-1-s-ramamoorthy@ti.com/
MFD: https://lore.kernel.org/all/20241217204935.1012106-1-s-ramamoorthy@ti.com/
Reg: https://lore.kernel.org/all/20241217204526.1010989-1-s-ramamoorthy@ti.com/

- TPS65214 is a Power Management IC with 3 Buck regulators and 2 LDOs.
- TPS65214 has 2 LDOS and 1 GPO, whereas TPS65219 has 4 LDOs and 2 GPOs.
- TPS65214's LDO1 maps to TPS65219's LDO3.
- A key difference between TPS65215 & TPS65214 are the LDO current and
  voltage output ranges and the configurable options available.
- The remaining features for both devices are the same.

TPS65214 TRM: https://www.ti.com/lit/pdf/slvud30

AM62L + TPS65214 Test Logs:
https://gist.github.com/ramamoorthyhs/0793f7813332d94423ca1baee02f62c9

Shree Ramamoorthy (1):
  input: tps65214: Add support for TI TPS65214 PMIC

 drivers/input/misc/tps65219-pwrbutton.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski Jan. 17, 2025, 9:23 a.m. UTC | #1 
On 16/01/2025 23:40, Shree Ramamoorthy wrote:
> Update descriptions to reflect this input driver  applies to TPS65214,
> TPS65215, and TPS65219.
> 
> Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com>
> ---

That's just churn...

Best regards,
Krzysztof
Dmitry Torokhov Jan. 17, 2025, 5:43 p.m. UTC | #2 
On Fri, Jan 17, 2025 at 10:23:58AM +0100, Krzysztof Kozlowski wrote:
> On 16/01/2025 23:40, Shree Ramamoorthy wrote:
> > Update descriptions to reflect this input driver  applies to TPS65214,
> > TPS65215, and TPS65219.
> > 
> > Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com>
> > ---
> 
> That's just churn...

Yes, when something is being reused we typically do not go back and list
all the new users unless there are other adjustments needed.

Thanks.
Shree Ramamoorthy Jan. 17, 2025, 6:53 p.m. UTC | #3 
Hi,

On 1/17/25 11:43 AM, Dmitry Torokhov wrote:
> On Fri, Jan 17, 2025 at 10:23:58AM +0100, Krzysztof Kozlowski wrote:
>> On 16/01/2025 23:40, Shree Ramamoorthy wrote:
>>> Update descriptions to reflect this input driver  applies to TPS65214,
>>> TPS65215, and TPS65219.
>>>
>>> Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com>
>>> ---
>> That's just churn...
> Yes, when something is being reused we typically do not go back and list
> all the new users unless there are other adjustments needed.
>
> Thanks.

Thank you both for reviewing and the explanation.
I will drop this input series for the next version submitted.