| Message ID | 20241113110516.2166328-3-Wenhua.Lin@unisoc.com |
|---|---|
| State | New |
| Headers | show |
| Series | serial: sprd: Modification of UNISOC Platform UART Driver | expand |
On Wed, Nov 13, 2024 at 07:05:16PM +0800, Wenhua Lin wrote: > The UMS9632 uses the SC9632 serial device. > > Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com> Acked-by: Conor Dooley <conor.dooley@microchip.com>
2024年11月13日 19:05, "Wenhua Lin" <Wenhua.Lin@unisoc.com> 写到: > > The UMS9632 uses the SC9632 serial device. > > Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com> > > --- > > Documentation/devicetree/bindings/serial/sprd-uart.yaml | 1 + > > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml > > index f4dbb6dc2b6e..a2a5056eba04 100644 > > --- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml > > +++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml > > @@ -17,6 +17,7 @@ properties: > > oneOf: > > - items: > > - enum: > > + - sprd,sc9632-uart > > - sprd,sc9860-uart > > - sprd,sc9863a-uart > > - sprd,ums512-uart > > -- > > 2.34.1 > Acked-by: Cixi Geng <cixi.geng@linux.dev>
Correct me if I'm wrong, but this patch seems incorrect to me. The 1st patch suggets that the sc9632-uart is incompatible with sc9836-uart, but here you make it fallback to it anyway. Also, both of the patches seem to have made it to linux-next without the reviews/Acks from maintainers. Maybe Greg was a bit too fast here :) Regards, Stanislav
On Thu, Nov 21, 2024 at 8:26 PM Stanislav Jakubek <stano.jakubek@gmail.com> wrote: > > Correct me if I'm wrong, but this patch seems incorrect to me. > The 1st patch suggets that the sc9632-uart is incompatible with sc9836-uart, > but here you make it fallback to it anyway. > > Also, both of the patches seem to have made it to linux-next without the > reviews/Acks from maintainers. Maybe Greg was a bit too fast here :) > > Regards, > Stanislav Hi Stanislav: Thank you very much for your review, we will correct it in patch v2. Thanks
On Thu, Nov 21, 2024 at 9:34 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 21/11/2024 13:26, Stanislav Jakubek wrote: > > Correct me if I'm wrong, but this patch seems incorrect to me. > > The 1st patch suggets that the sc9632-uart is incompatible with sc9836-uart, > > but here you make it fallback to it anyway. > > > > Also, both of the patches seem to have made it to linux-next without the > > reviews/Acks from maintainers. Maybe Greg was a bit too fast here :) > > Yeah, this looks odd and considering totally empty commit msg (nothing > useful there), it looks like wrong choice. > > Please explain the compatibility aspects. In the future: you have entire > commit msg to describe the hardware, instead of repeating the obvious - > what is visible from the diff. > > Best regards, > Krzysztof Hi Krzysztof: Thank you very much for your review, we will correct it in patch v2. Thanks
On 13/01/2025 03:29, wenhua lin wrote: > On Thu, Nov 21, 2024 at 9:34 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: >> >> On 21/11/2024 13:26, Stanislav Jakubek wrote: >>> Correct me if I'm wrong, but this patch seems incorrect to me. >>> The 1st patch suggets that the sc9632-uart is incompatible with sc9836-uart, >>> but here you make it fallback to it anyway. >>> >>> Also, both of the patches seem to have made it to linux-next without the >>> reviews/Acks from maintainers. Maybe Greg was a bit too fast here :) >> >> Yeah, this looks odd and considering totally empty commit msg (nothing >> useful there), it looks like wrong choice. >> >> Please explain the compatibility aspects. In the future: you have entire >> commit msg to describe the hardware, instead of repeating the obvious - >> what is visible from the diff. >> >> Best regards, >> Krzysztof > > Hi Krzysztof: > Thank you very much for your review, we will correct it in patch v2. I wrote - commit msg, not changelog. Sigh... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml index f4dbb6dc2b6e..a2a5056eba04 100644 --- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml +++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml @@ -17,6 +17,7 @@ properties: oneOf: - items: - enum: + - sprd,sc9632-uart - sprd,sc9860-uart - sprd,sc9863a-uart - sprd,ums512-uart
The UMS9632 uses the SC9632 serial device. Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com> --- Documentation/devicetree/bindings/serial/sprd-uart.yaml | 1 + 1 file changed, 1 insertion(+)