| Message ID | 20250109183551.1028791-1-quic_aarasahu@quicinc.com |
|---|---|
| Headers | show |
| Series | wifi: ath12k: Factory test mode support | expand |
On 1/9/2025 10:35 AM, Aaradhana Sahu wrote: > User space application requires that the testmode interface > is exactly same between ath drivers. Move testmode_i.h file > in ath directory to ensure that all ath driver uses same testmode > interface instead of duplicating testmode_i.h for each ath drivers. > > Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1 > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Aaradhana Sahu <quic_aarasahu@quicinc.com> > --- > drivers/net/wireless/ath/ath11k/testmode.c | 80 +++++++++---------- > .../wireless/ath/{ath11k => }/testmode_i.h | 54 ++++++------- > 2 files changed, 67 insertions(+), 67 deletions(-) > rename drivers/net/wireless/ath/{ath11k => }/testmode_i.h (50%) > > diff --git a/drivers/net/wireless/ath/ath11k/testmode.c b/drivers/net/wireless/ath/ath11k/testmode.c > index 302d66092b97..9d1613723601 100644 > --- a/drivers/net/wireless/ath/ath11k/testmode.c > +++ b/drivers/net/wireless/ath/ath11k/testmode.c > @@ -1,7 +1,7 @@ > // SPDX-License-Identifier: BSD-3-Clause-Clear > /* > * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved. > - * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved. > + * Copyright (c) 2023, 2025 Qualcomm Innovation Center, Inc. All rights reserved. should be 2023-2025 to account for the patches posted but not merged in 2024 > diff --git a/drivers/net/wireless/ath/ath11k/testmode_i.h b/drivers/net/wireless/ath/testmode_i.h > similarity index 50% > rename from drivers/net/wireless/ath/ath11k/testmode_i.h > rename to drivers/net/wireless/ath/testmode_i.h > index 91b83873d660..b8fa5092e6ca 100644 > --- a/drivers/net/wireless/ath/ath11k/testmode_i.h > +++ b/drivers/net/wireless/ath/testmode_i.h > @@ -1,59 +1,59 @@ > /* SPDX-License-Identifier: BSD-3-Clause-Clear */ > /* > * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved. > - * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved. > + * Copyright (c) 2023-2024 Qualcomm Innovation Center, Inc. All rights reserved. should be 2023-2025 for the same reason
On 1/9/2025 10:35 AM, Aaradhana Sahu wrote: > Device is booted in factory test mode for calibration. > The commands are sent from userspace application, which > is sent to firmware using wmi commands. Firmware sends > the response to driver as wmi events and driver sends > these events to the application via netlink message. > > Also added changes related to correct pdev id access for > fw test cmd. > > Aaradhana Sahu (5): > wifi: ath: create common testmode_i.h file for ath drivers > wifi: ath12k: export ath12k_wmi_tlv_hdr for testmode > wifi: ath12k: add factory test mode support > wifi: ath12k: Fill pdev id for fw test cmd > wifi: ath12k: Disable MLO in Factory Test Mode > > --- > v6: > -Rebased on ToT > -Updated copyright > -Added patch[5/5] > v5: > -Updated copyright > -Fixed line length within 90 char > v4: > -Rebased on latest ToT > v3: > -Rebased on latest ToT > -Updated Tested-on Tag > -Removed second parameter of ath12k_core_start() > -Updated copyright > v2: > -Rebased on latest ath ToT > --- > > drivers/net/wireless/ath/ath11k/testmode.c | 80 ++-- > drivers/net/wireless/ath/ath12k/Makefile | 1 + > drivers/net/wireless/ath/ath12k/core.c | 29 +- > drivers/net/wireless/ath/ath12k/core.h | 13 +- > drivers/net/wireless/ath/ath12k/debug.h | 3 +- > drivers/net/wireless/ath/ath12k/dp.c | 5 +- > drivers/net/wireless/ath/ath12k/mac.c | 17 +- > drivers/net/wireless/ath/ath12k/pci.c | 3 +- > drivers/net/wireless/ath/ath12k/qmi.c | 4 +- > drivers/net/wireless/ath/ath12k/testmode.c | 395 ++++++++++++++++++ > drivers/net/wireless/ath/ath12k/testmode.h | 40 ++ > drivers/net/wireless/ath/ath12k/wmi.c | 41 +- > drivers/net/wireless/ath/ath12k/wmi.h | 23 +- > drivers/net/wireless/ath/ath12k/wow.c | 3 +- > .../wireless/ath/{ath11k => }/testmode_i.h | 54 +-- > 15 files changed, 621 insertions(+), 90 deletions(-) > create mode 100644 drivers/net/wireless/ath/ath12k/testmode.c > create mode 100644 drivers/net/wireless/ath/ath12k/testmode.h > rename drivers/net/wireless/ath/{ath11k => }/testmode_i.h (50%) > > > base-commit: dbe50a7420e22954c747e79e72df2750d795ea77 I just had nit comments. Kalle, can you re-review? If there are no major comments, I can incorporate my comments when I pull this into the 'pending' branch. /jeff
On 1/10/2025 2:23 AM, Jeff Johnson wrote: > On 1/9/2025 10:35 AM, Aaradhana Sahu wrote: >> User space application requires that the testmode interface >> is exactly same between ath drivers. Move testmode_i.h file >> in ath directory to ensure that all ath driver uses same testmode >> interface instead of duplicating testmode_i.h for each ath drivers. >> >> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1 >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 >> >> Signed-off-by: Aaradhana Sahu <quic_aarasahu@quicinc.com> >> --- >> drivers/net/wireless/ath/ath11k/testmode.c | 80 +++++++++---------- >> .../wireless/ath/{ath11k => }/testmode_i.h | 54 ++++++------- >> 2 files changed, 67 insertions(+), 67 deletions(-) >> rename drivers/net/wireless/ath/{ath11k => }/testmode_i.h (50%) >> >> diff --git a/drivers/net/wireless/ath/ath11k/testmode.c b/drivers/net/wireless/ath/ath11k/testmode.c >> index 302d66092b97..9d1613723601 100644 >> --- a/drivers/net/wireless/ath/ath11k/testmode.c >> +++ b/drivers/net/wireless/ath/ath11k/testmode.c >> @@ -1,7 +1,7 @@ >> // SPDX-License-Identifier: BSD-3-Clause-Clear >> /* >> * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved. >> - * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved. >> + * Copyright (c) 2023, 2025 Qualcomm Innovation Center, Inc. All rights reserved. > > should be 2023-2025 to account for the patches posted but not merged in 2024 > Sure, will address in the next version. >> diff --git a/drivers/net/wireless/ath/ath11k/testmode_i.h b/drivers/net/wireless/ath/testmode_i.h >> similarity index 50% >> rename from drivers/net/wireless/ath/ath11k/testmode_i.h >> rename to drivers/net/wireless/ath/testmode_i.h >> index 91b83873d660..b8fa5092e6ca 100644 >> --- a/drivers/net/wireless/ath/ath11k/testmode_i.h >> +++ b/drivers/net/wireless/ath/testmode_i.h >> @@ -1,59 +1,59 @@ >> /* SPDX-License-Identifier: BSD-3-Clause-Clear */ >> /* >> * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved. >> - * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved. >> + * Copyright (c) 2023-2024 Qualcomm Innovation Center, Inc. All rights reserved. > > should be 2023-2025 for the same reason > Sure, will address in the next version. >
On 1/10/2025 2:30 AM, Jeff Johnson wrote: > On 1/9/2025 10:35 AM, Aaradhana Sahu wrote: >> Factory test mode(FTM) is supported only non-mlo(multi-link operation) > > only *in* non-mlo...? > > and s/-mlo/-MLO/ > Sure, will address in the next version. >> mode. Therefore, disable MLO when driver boots in FTM mode. >> >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 >> >> Signed-off-by: Aaradhana Sahu <quic_aarasahu@quicinc.com> >
Device is booted in factory test mode for calibration. The commands are sent from userspace application, which is sent to firmware using wmi commands. Firmware sends the response to driver as wmi events and driver sends these events to the application via netlink message. Also added changes related to correct pdev id access for fw test cmd. Aaradhana Sahu (5): wifi: ath: create common testmode_i.h file for ath drivers wifi: ath12k: export ath12k_wmi_tlv_hdr for testmode wifi: ath12k: add factory test mode support wifi: ath12k: Fill pdev id for fw test cmd wifi: ath12k: Disable MLO in Factory Test Mode --- v6: -Rebased on ToT -Updated copyright -Added patch[5/5] v5: -Updated copyright -Fixed line length within 90 char v4: -Rebased on latest ToT v3: -Rebased on latest ToT -Updated Tested-on Tag -Removed second parameter of ath12k_core_start() -Updated copyright v2: -Rebased on latest ath ToT --- drivers/net/wireless/ath/ath11k/testmode.c | 80 ++-- drivers/net/wireless/ath/ath12k/Makefile | 1 + drivers/net/wireless/ath/ath12k/core.c | 29 +- drivers/net/wireless/ath/ath12k/core.h | 13 +- drivers/net/wireless/ath/ath12k/debug.h | 3 +- drivers/net/wireless/ath/ath12k/dp.c | 5 +- drivers/net/wireless/ath/ath12k/mac.c | 17 +- drivers/net/wireless/ath/ath12k/pci.c | 3 +- drivers/net/wireless/ath/ath12k/qmi.c | 4 +- drivers/net/wireless/ath/ath12k/testmode.c | 395 ++++++++++++++++++ drivers/net/wireless/ath/ath12k/testmode.h | 40 ++ drivers/net/wireless/ath/ath12k/wmi.c | 41 +- drivers/net/wireless/ath/ath12k/wmi.h | 23 +- drivers/net/wireless/ath/ath12k/wow.c | 3 +- .../wireless/ath/{ath11k => }/testmode_i.h | 54 +-- 15 files changed, 621 insertions(+), 90 deletions(-) create mode 100644 drivers/net/wireless/ath/ath12k/testmode.c create mode 100644 drivers/net/wireless/ath/ath12k/testmode.h rename drivers/net/wireless/ath/{ath11k => }/testmode_i.h (50%) base-commit: dbe50a7420e22954c747e79e72df2750d795ea77