mbox series

[0/3] wifi: cfg80211: update EML capabilities of an ML Station

Message ID 20250107174802.1793252-1-quic_ramess@quicinc.com
Headers show
Series wifi: cfg80211: update EML capabilities of an ML Station | expand

Message

Rameshkumar Sundaram Jan. 7, 2025, 5:47 p.m. UTC 
When EMLSR is enabled for an ML association, the EML capabilities
advertised by the ML Station needs to be updated to drivers in order to
trigger EMLSR operation.
Add support to fetch EML capabilities advertised by ML station and
cache it in ieee80211_sta data structure so that drivers can use them
whenever required.

Ramasamy Kaliappan (3):
  wifi: cfg80211: Add support to get EMLSR capabilities of non-AP MLD
  wifi: mac80211: update ML STA with EML capabilities
  wifi: ath12k: update EMLSR capabilities of ML Station

 drivers/net/wireless/ath/ath12k/mac.c |  3 +-
 drivers/net/wireless/ath/ath12k/wmi.c | 81 ++++++++++++++++++++++++++-
 drivers/net/wireless/ath/ath12k/wmi.h |  3 +-
 include/net/cfg80211.h                |  2 +
 include/net/mac80211.h                |  2 +
 net/mac80211/cfg.c                    |  3 +
 net/wireless/nl80211.c                |  8 +++
 7 files changed, 98 insertions(+), 4 deletions(-)


base-commit: 09fa3b6974a1245ddd0751747609431494ba5b4f

Comments

Johannes Berg Jan. 8, 2025, 8:34 a.m. UTC | #1 
On Tue, 2025-01-07 at 23:18 +0530, Rameshkumar Sundaram wrote:
> 
> +	if (params->eml_cap)
> +		sta->sta.eml_cap = params->eml_cap;
> 

It would seem to me that 0 is a valid value, so you may need a separate
"was the attribute included and we're changing the value" flag?

johannes
Rameshkumar Sundaram Jan. 9, 2025, 12:45 p.m. UTC | #2 
On 1/8/2025 2:04 PM, Johannes Berg wrote:
> On Tue, 2025-01-07 at 23:18 +0530, Rameshkumar Sundaram wrote:
>> +	if (params->eml_cap)
>> +		sta->sta.eml_cap = params->eml_cap;
>>
> It would seem to me that 0 is a valid value, so you may need a separate
> "was the attribute included and we're changing the value" flag?
Yes you're right, shall i add a new entry in 
station_parameters_apply_mask {} and use it for this ?