| Message ID | 20241228114514.91594-4-ivo.g.dimitrov.75@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | ASoC: cpcap: Implement jack headset detection | expand |
On Sat, Dec 28, 2024 at 01:45:12PM +0200, Ivaylo Dimitrov wrote: > This adds the DT binding for the audio-codec headset detection interrupts Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 Also, missing full stop. > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > --- > Documentation/devicetree/bindings/mfd/motorola-cpcap.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt b/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt > index 190230216de8..3ad809e119ff 100644 > --- a/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt > +++ b/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt > @@ -31,10 +31,15 @@ node must be named "audio-codec". > Required properties for the audio-codec subnode: > > - #sound-dai-cells = <1>; > +- interrupts-extended = <&cpcap 9 0>, <&cpcap 10 0>; Instead: interrupts and say which interrupt is where. Anyway this should be converted to DT schema. > +- interrupt-names = "hs", "mb2"; > > The audio-codec provides two DAIs. The first one is connected to the > Stereo HiFi DAC and the second one is connected to the Voice DAC. > > +audio-codec interrupts are required for jack detection, "hs" one is headset > +detect and "mb2" is microphone bias 2 detect. This goes to the interrupts description. > + > Example: > > &mcspi1 { > @@ -52,6 +57,10 @@ Example: > > audio-codec { > #sound-dai-cells = <1>; > + interrupts-extended = > + <&cpcap 9 0>, > + <&cpcap 10 0>; Fix alignment. Same for your DTS patches. Best regards, Krzysztof
On 31.12.24 г. 10:41 ч., Krzysztof Kozlowski wrote: > On Sat, Dec 28, 2024 at 01:45:12PM +0200, Ivaylo Dimitrov wrote: >> This adds the DT binding for the audio-codec headset detection interrupts > > > Please do not use "This commit/patch/change", but imperative mood. See > longer explanation here: > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > Also, missing full stop. > >> >> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> >> --- >> Documentation/devicetree/bindings/mfd/motorola-cpcap.txt | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt b/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt >> index 190230216de8..3ad809e119ff 100644 >> --- a/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt >> +++ b/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt >> @@ -31,10 +31,15 @@ node must be named "audio-codec". >> Required properties for the audio-codec subnode: >> >> - #sound-dai-cells = <1>; >> +- interrupts-extended = <&cpcap 9 0>, <&cpcap 10 0>; > > Instead: interrupts and say which interrupt is where. > > Anyway this should be converted to DT schema. > Do you want me to do the conversion? If yes, could it be done in a follow-up patch? Thanks and happy new year, Ivo
diff --git a/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt b/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt index 190230216de8..3ad809e119ff 100644 --- a/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt +++ b/Documentation/devicetree/bindings/mfd/motorola-cpcap.txt @@ -31,10 +31,15 @@ node must be named "audio-codec". Required properties for the audio-codec subnode: - #sound-dai-cells = <1>; +- interrupts-extended = <&cpcap 9 0>, <&cpcap 10 0>; +- interrupt-names = "hs", "mb2"; The audio-codec provides two DAIs. The first one is connected to the Stereo HiFi DAC and the second one is connected to the Voice DAC. +audio-codec interrupts are required for jack detection, "hs" one is headset +detect and "mb2" is microphone bias 2 detect. + Example: &mcspi1 { @@ -52,6 +57,10 @@ Example: audio-codec { #sound-dai-cells = <1>; + interrupts-extended = + <&cpcap 9 0>, + <&cpcap 10 0>; + interrupt-names = "hs", "mb2"; /* HiFi */ port@0 {
This adds the DT binding for the audio-codec headset detection interrupts Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> --- Documentation/devicetree/bindings/mfd/motorola-cpcap.txt | 9 +++++++++ 1 file changed, 9 insertions(+)