mbox series

[v2,0/3] arm64: dts: qcom: Introduce Huawei Matebook E Go

Message ID 20241220160530.444864-1-mitltlatltl@gmail.com
Headers show
Series arm64: dts: qcom: Introduce Huawei Matebook E Go | expand

Message

Pengyu Luo Dec. 20, 2024, 4:05 p.m. UTC
Add support for the SC8280XP-based Huawei Matebook E Go (sc8280xp)

Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com>
---
Changes in v2:
- use Co-developed-by: tag (Konrad)
- follow this order (property-n property-names) (Konrad)
- add a label for tablet mode switch (Konrad)
- handle line breaks properly (Konrad)
- remove the wlan calibration variant (Konrad)
- drop the venus node, as upstream has not supported it now
- Link to v1: https://lore.kernel.org/linux-arm-msm/20241211153754.356476-1-mitltlatltl@gmail.com

---
Pengyu Luo (3):
  dt-bindings: arm: qcom: Document Huawei Matebook E Go (sc8280xp)
  firmware: qcom: scm: Allow QSEECOM on Huawei Matebook E Go (sc8280xp)
  arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

 .../devicetree/bindings/arm/qcom.yaml         |    1 +
 arch/arm64/boot/dts/qcom/Makefile             |    1 +
 .../boot/dts/qcom/sc8280xp-huawei-gaokun3.dts | 1318 +++++++++++++++++
 drivers/firmware/qcom/qcom_scm.c              |    1 +
 4 files changed, 1321 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts

Comments

Konrad Dybcio Dec. 20, 2024, 9:13 p.m. UTC | #1
On 20.12.2024 5:05 PM, Pengyu Luo wrote:
> Add an initial devicetree for the Huawei Matebook E Go, which is based on
> sc8280xp.
> 
> There are 3 variants, Huawei released first 2 at the same time.
> Huawei Matebook E Go LTE(sc8180x), codename should be gaokun2.
> Huawei Matebook E Go(sc8280xp@3.0GHz), codename is gaokun3.
> Huawei Matebook E Go 2023(sc8280xp@2.69GHz).
> 
> We add support for the latter two variants.
> 
> This work started by Tianyu Gao and Xuecong Chen, they made the
> devicetree based on existing work(i.e. the Lenovo X13s and the
> Qualcomm CRD), it can boot with framebuffer.
> 

So this looks good now, but

[...]

> +	chosen {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		framebuffer0: framebuffer@c6200000 {
> +			compatible = "simple-framebuffer";
> +			reg = <0x0 0xc6200000 0x0 0x02400000>;
> +			width = <1600>;
> +			height = <2560>;
> +			stride = <(1600 * 4)>;
> +			format = "a8r8g8b8";
> +		};
> +	};

I still don't understand why efifb doesn't work for you.

Could you share your .config file?

Konrad
Bjorn Andersson Dec. 26, 2024, 10:38 p.m. UTC | #2
On Sat, 21 Dec 2024 00:05:27 +0800, Pengyu Luo wrote:
> Add support for the SC8280XP-based Huawei Matebook E Go (sc8280xp)
> 
> 

Applied, thanks!

[1/3] dt-bindings: arm: qcom: Document Huawei Matebook E Go (sc8280xp)
      commit: f99c52954a82601d4d46677e9399e87c8b6c1bb3
[3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)
      commit: 1401ae5c28a259f684ccba7b460884b88f863596

Best regards,