| Message ID | 20241118021009.2858849-2-sowon.na@samsung.com |
|---|---|
| State | New |
| Headers | show |
| Series | Support ExynosAutov920 ufs phy driver | expand |
> -----Original Message----- > From: Sowon Na <sowon.na@samsung.com> > Sent: Monday, November 18, 2024 7:40 AM > To: robh@kernel.org; krzk@kernel.org; conor+dt@kernel.org; > vkoul@kernel.org; alim.akhtar@samsung.com; kishon@kernel.org > Cc: krzk+dt@kernel.org; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; linux-samsung-soc@vger.kernel.org; > sowon.na@samsung.com; Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> > Subject: [PATCH v3 1/3] dt-bindings: phy: Add ExynosAutov920 UFS PHY > bindings > > Add samsung,exynosautov920-ufs-phy compatible for ExynosAuto v920 SoC. > > Signed-off-by: Sowon Na <sowon.na@samsung.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- I am not sure how we can help you, you are keep missing to collect all the tags https://lkml.org/lkml/2024/11/7/617 > Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > index f402e31bf58d..d70ffeb6e824 100644 > --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > @@ -18,6 +18,7 @@ properties: > - google,gs101-ufs-phy > - samsung,exynos7-ufs-phy > - samsung,exynosautov9-ufs-phy > + - samsung,exynosautov920-ufs-phy > - tesla,fsd-ufs-phy > > reg: > -- > 2.45.2
Hi Alim, On 11/19/24 2:21 PM, Alim Akhtar wrote: > -----Original Message----- > From: Alim Akhtar <alim.akhtar@samsung.com> > Sent: Tuesday, November 19, 2024 2:21 PM > To: 'Sowon Na' <sowon.na@samsung.com>; robh@kernel.org; krzk@kernel.org; > conor+dt@kernel.org; vkoul@kernel.org; kishon@kernel.org > Cc: krzk+dt@kernel.org; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; linux-samsung-soc@vger.kernel.org; 'Krzysztof > Kozlowski' <krzysztof.kozlowski@linaro.org> > Subject: RE: [PATCH v3 1/3] dt-bindings: phy: Add ExynosAutov920 UFS PHY > bindings > > > > > -----Original Message----- > > From: Sowon Na <sowon.na@samsung.com> > > Sent: Monday, November 18, 2024 7:40 AM > > To: robh@kernel.org; krzk@kernel.org; conor+dt@kernel.org; > > vkoul@kernel.org; alim.akhtar@samsung.com; kishon@kernel.org > > Cc: krzk+dt@kernel.org; linux-kernel@vger.kernel.org; > > devicetree@vger.kernel.org; linux-samsung-soc@vger.kernel.org; > > sowon.na@samsung.com; Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> > > Subject: [PATCH v3 1/3] dt-bindings: phy: Add ExynosAutov920 UFS PHY > > bindings > > > > Add samsung,exynosautov920-ufs-phy compatible for ExynosAuto v920 SoC. > > > > Signed-off-by: Sowon Na <sowon.na@samsung.com> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > I am not sure how we can help you, you are keep missing to collect all the > tags > https://lkml.org/lkml/2024/11/7/617 > Really sorry for missing tags. I append it immediately, and will not miss anymore. Your review helps me a lot and makes my patch better. I applied all your reviews to my patches. Thank you a lot once again for your help. > > Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git > > a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > > b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > > index f402e31bf58d..d70ffeb6e824 100644 > > --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > > @@ -18,6 +18,7 @@ properties: > > - google,gs101-ufs-phy > > - samsung,exynos7-ufs-phy > > - samsung,exynosautov9-ufs-phy > > + - samsung,exynosautov920-ufs-phy > > - tesla,fsd-ufs-phy > > > > reg: > > -- > > 2.45.2 >
On 18/11/2024 03:10, Sowon Na wrote: > Add samsung,exynosautov920-ufs-phy compatible for ExynosAuto v920 SoC. > > Signed-off-by: Sowon Na <sowon.na@samsung.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Read carefully guides before posting new versions. You already got one such reminder, how many are needed? <form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. </form letter> Best regards, Krzysztof
On 18-12-24, 10:32, 나소원/SOWON NA wrote: > Hi Krzysztof, > > > -----Original Message----- > > From: 나소원/SOWON NA <sowon.na@samsung.com> > > Sent: Tuesday, November 19, 2024 3:36 PM > > To: 'Alim Akhtar' <alim.akhtar@samsung.com> > > Cc: 'robh@kernel.org' <robh@kernel.org>; 'krzk@kernel.org' > > <krzk@kernel.org>; 'conor+dt@kernel.org' <conor+dt@kernel.org>; > > 'vkoul@kernel.org' <vkoul@kernel.org>; 'kishon@kernel.org' > > <kishon@kernel.org>; 'krzk+dt@kernel.org' <krzk+dt@kernel.org>; 'linux- > > kernel@vger.kernel.org' <linux-kernel@vger.kernel.org>; > > 'devicetree@vger.kernel.org' <devicetree@vger.kernel.org>; 'linux-samsung- > > soc@vger.kernel.org' <linux-samsung-soc@vger.kernel.org>; 'Krzysztof > > Kozlowski' <krzysztof.kozlowski@linaro.org> > > Subject: RE: [PATCH v3 1/3] dt-bindings: phy: Add ExynosAutov920 UFS PHY > > bindings > > > > Hi Alim, > > > > On 11/19/24 2:21 PM, Alim Akhtar wrote: > > > -----Original Message----- > > > From: Alim Akhtar <alim.akhtar@samsung.com> > > > Sent: Tuesday, November 19, 2024 2:21 PM > > > To: 'Sowon Na' <sowon.na@samsung.com>; robh@kernel.org; > > > krzk@kernel.org; > > > conor+dt@kernel.org; vkoul@kernel.org; kishon@kernel.org > > > Cc: krzk+dt@kernel.org; linux-kernel@vger.kernel.org; > > > devicetree@vger.kernel.org; linux-samsung-soc@vger.kernel.org; > > > 'Krzysztof Kozlowski' <krzysztof.kozlowski@linaro.org> > > > Subject: RE: [PATCH v3 1/3] dt-bindings: phy: Add ExynosAutov920 UFS > > > PHY bindings > > > > > > > > > > > > > -----Original Message----- > > > > From: Sowon Na <sowon.na@samsung.com> > > > > Sent: Monday, November 18, 2024 7:40 AM > > > > To: robh@kernel.org; krzk@kernel.org; conor+dt@kernel.org; > > > > vkoul@kernel.org; alim.akhtar@samsung.com; kishon@kernel.org > > > > Cc: krzk+dt@kernel.org; linux-kernel@vger.kernel.org; > > > > devicetree@vger.kernel.org; linux-samsung-soc@vger.kernel.org; > > > > sowon.na@samsung.com; Krzysztof Kozlowski > > > > <krzysztof.kozlowski@linaro.org> > > > > Subject: [PATCH v3 1/3] dt-bindings: phy: Add ExynosAutov920 UFS PHY > > > > bindings > > > > > > > > Add samsung,exynosautov920-ufs-phy compatible for ExynosAuto v920 SoC. > > > > > > > > Signed-off-by: Sowon Na <sowon.na@samsung.com> > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > --- > > > I am not sure how we can help you, you are keep missing to collect all > > > the tags > > > https://lkml.org/lkml/2024/11/7/617 > > > > > Really sorry for missing tags. I append it immediately, and will not miss > > anymore. > > Your review helps me a lot and makes my patch better. I applied all your > > reviews to my patches. > > > > Thank you a lot once again for your help. > > > > I missed including the "Reviewed-by" tag in the patch set I sent. > Could you please let me know if you'd prefer me to send a v4 with the > tag included, or if you're able to apply it with the missing tag? Please wrap your replies in 80chars Yes pls add and post v4 > > Thank you for your understanding, and I apologize for the oversight. > > Best regards, > Sowon. > >
diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml index f402e31bf58d..d70ffeb6e824 100644 --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml @@ -18,6 +18,7 @@ properties: - google,gs101-ufs-phy - samsung,exynos7-ufs-phy - samsung,exynosautov9-ufs-phy + - samsung,exynosautov920-ufs-phy - tesla,fsd-ufs-phy reg: