Message ID | 20241220-gs101-acpm-dt-v3-0-642d64daa5d1@linaro.org |
---|---|
Headers | show |
Series | arm64: exynos: gs101: add ACPM related nodes | expand |
On 20/12/2024 15:45, Tudor Ambarus wrote: > GS101 has 14 mailbox controllers. Add the AP to APM mailbox node. > > Mailbox controllers have a shared register that can be used for passing > the mailbox messages. The AP to APM mailbox controller is used just as a > doorbell mechanism. It raises interrupt to the firmware after the mailbox > message has been written to SRAM where the TX/RX rings are defined. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- > arch/arm64/boot/dts/exynos/google/gs101.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > index 1441e9a252c2..6947dd081a0e 100644 > --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi > +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > @@ -1445,6 +1445,15 @@ wakeup-interrupt-controller { > }; > }; > > + ap2apm_mailbox: mailbox@17610000 { > + compatible = "google,gs101-mbox"; I don't think I have this in my tree and cover letter does not explain where I can find bindings. Nothing in next from few days ago. Always document in DTS patchset where are the bindings, unless it's obvious. Best regards, Krzysztof
Define SRAM, mailbox and ACPM protocol in device tree. Enable the mailbox and ACPM protocol in defconfig. Changes in v3: - ACPM: don't specify the channel ID and type in DT: the channel ID is discovered at runtime and the channel type is always DOORBELL for the ACPM interface. - mbox: update #mbox-cells = <0>; - rebase on top of v6.13-rc3 - Link to v2: https://lore.kernel.org/r/20241212-b4-acpm-v4-upstream-dts-v2-0-91b7a6f6d0b0@linaro.org Changes in v2: - update nodes based on the bindings updates - update mailbox and power-management (mailbox client) nodes to specify channel type (doorbell or data) and channel ID. v1: Link: https://lore.kernel.org/linux-arm-kernel/20241205180200.203146-1-tudor.ambarus@linaro.org/ Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> --- Tudor Ambarus (4): arm64: dts: exynos: gs101: add SRAM node arm64: dts: exynos: gs101: add AP to APM mailbox node arm64: dts: exynos: gs101: add ACPM protocol node arm64: defconfig: enable ACPM protocol and Exynos mailbox arch/arm64/boot/dts/exynos/google/gs101.dtsi | 25 +++++++++++++++++++++++++ arch/arm64/configs/defconfig | 2 ++ 2 files changed, 27 insertions(+) --- base-commit: 78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8 change-id: 20241220-gs101-acpm-dt-6dcde166530a Best regards,