diff mbox series

[1/2] dt-bindings: clock: qcom,sc7280-lpasscorecc: order properties to match convention

Message ID 20240817094605.27185-1-krzysztof.kozlowski@linaro.org
State New
Headers show
Series [1/2] dt-bindings: clock: qcom,sc7280-lpasscorecc: order properties to match convention | expand

Commit Message

Krzysztof Kozlowski Aug. 17, 2024, 9:46 a.m. UTC
By convention we expect first "compatible", then "reg" and then rest.
Order properties to match convention and what is in "required:" block.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Cc: Taniya Das <quic_tdas@quicinc.com>
---
 .../clock/qcom,sc7280-lpasscorecc.yaml        | 21 ++++++++++---------
 1 file changed, 11 insertions(+), 10 deletions(-)

Comments

Bjorn Andersson Dec. 17, 2024, 4:38 p.m. UTC | #1
On Sat, 17 Aug 2024 11:46:04 +0200, Krzysztof Kozlowski wrote:
> By convention we expect first "compatible", then "reg" and then rest.
> Order properties to match convention and what is in "required:" block.
> 
> 

Applied, thanks!

[1/2] dt-bindings: clock: qcom,sc7280-lpasscorecc: order properties to match convention
      commit: 2a5711c7dc6f20e132f99b13731952bdb3530acf
[2/2] dt-bindings: clock: qcom,sc7280-lpasscorecc: add top-level constraints
      commit: 9d40c5a698de6ba629f2abc8dd43b8a2db469307

Best regards,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml
index deee5423d66e..5e6737c39897 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml
@@ -18,12 +18,6 @@  description: |
     include/dt-bindings/clock/qcom,lpassaudiocc-sc7280.h
 
 properties:
-  clocks: true
-
-  clock-names: true
-
-  reg: true
-
   compatible:
     enum:
       - qcom,sc7280-lpassaoncc
@@ -31,12 +25,18 @@  properties:
       - qcom,sc7280-lpasscorecc
       - qcom,sc7280-lpasshm
 
-  power-domains:
-    maxItems: 1
+  reg: true
+
+  clocks: true
+
+  clock-names: true
 
   '#clock-cells':
     const: 1
 
+  power-domains:
+    maxItems: 1
+
   '#power-domain-cells':
     const: 1
 
@@ -57,8 +57,6 @@  required:
   - '#clock-cells'
   - '#power-domain-cells'
 
-additionalProperties: false
-
 allOf:
   - if:
       properties:
@@ -125,6 +123,9 @@  allOf:
 
         reg:
           maxItems: 1
+
+additionalProperties: false
+
 examples:
   - |
     #include <dt-bindings/clock/qcom,rpmh.h>