mbox series

[0/4] include: Header cleanups around "cpu.h"

Message ID 20241218155202.71931-1-philmd@linaro.org
Headers show
Series include: Header cleanups around "cpu.h" | expand

Message

Philippe Mathieu-Daudé Dec. 18, 2024, 3:51 p.m. UTC
Few more cleanups related to "cpu.h" in "exec/cpu-all.h".

(I plan to merge that myself)

Philippe Mathieu-Daudé (4):
  target/ppc: Include missing headers in mmu-hash[32,64].h
  tcg/tci: Include missing 'disas/dis-asm.h' header
  exec/ram_addr: Include missing 'exec/hwaddr.h' and 'exec/cpu-common.h'
  exec/cpu-all: Include 'cpu.h' earlier so MMU_USER_IDX is always
    defined

 include/exec/cpu-all.h  | 5 ++++-
 include/exec/ram_addr.h | 3 +++
 target/ppc/mmu-hash32.h | 3 +++
 target/ppc/mmu-hash64.h | 2 ++
 tcg/tci.c               | 1 +
 5 files changed, 13 insertions(+), 1 deletion(-)

Comments

Richard Henderson Dec. 18, 2024, 4:42 p.m. UTC | #1
On 12/18/24 09:51, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (4):
>    target/ppc: Include missing headers in mmu-hash[32,64].h
>    tcg/tci: Include missing 'disas/dis-asm.h' header
>    exec/ram_addr: Include missing 'exec/hwaddr.h' and 'exec/cpu-common.h'
>    exec/cpu-all: Include 'cpu.h' earlier so MMU_USER_IDX is always
>      defined

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Though, frankly these are hard to review in isolation.


r~
Philippe Mathieu-Daudé Dec. 19, 2024, 5:18 p.m. UTC | #2
On 18/12/24 17:42, Richard Henderson wrote:
> On 12/18/24 09:51, Philippe Mathieu-Daudé wrote:
>> Philippe Mathieu-Daudé (4):
>>    target/ppc: Include missing headers in mmu-hash[32,64].h
>>    tcg/tci: Include missing 'disas/dis-asm.h' header
>>    exec/ram_addr: Include missing 'exec/hwaddr.h' and 'exec/cpu-common.h'
>>    exec/cpu-all: Include 'cpu.h' earlier so MMU_USER_IDX is always
>>      defined
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> 
> Though, frankly these are hard to review in isolation.

Sorry for that. I'll send a PR with what I've already queued.
Next patches should be closer to the main tree.

Queuing patches 2-4.