| Message ID | 20241213-contrib-pg-cpu-hotplug-suspend2ram-fixes-v1-v1-2-c72978f63713@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | Fix Google Tensor GS101 CPU hotplug support | expand |
On Fri, 13 Dec 2024 16:44:39 +0000, Peter Griffin wrote: > To avoid dtschema warnings allow google,gs101-pmu to have > two reg regions. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- > I don't really like this patch, but also didn't want to submit the series > with a dtschema warning ;-) > > Possibly a better solution is when Robs patch > `mfd: syscon: Allow syscon nodes without a "syscon" compatible` [1] > > gets updated with a v2, we could remove syscon compatible from > gs101.dtsi (an ABI issue). If I understood his patch correctly, > it would mean this yaml update would then no longer be required. > > Let me know your thoughts > > [1] https://lore.kernel.org/lkml/20241211-syscon-fixes-v1-0-b5ac8c219e96@kernel.org/T/#m5ad1ed5c69f693d2a5cc54342a87fbdf3df756d2 > --- > Documentation/devicetree/bindings/mfd/syscon-common.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/mfd/syscon-common.yaml:68:3: [error] syntax error: expected <block end>, but found '?' (syntax) ./Documentation/devicetree/bindings/mfd/syscon-common.yaml:69:5: [warning] wrong indentation: expected 6 but found 4 (indentation) dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/syscon-common.yaml: ignoring, error parsing file make[2]: *** Deleting file 'Documentation/devicetree/bindings/mfd/syscon-common.example.dts' Documentation/devicetree/bindings/mfd/syscon-common.yaml:68:3: expected <block end>, but found '?' make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/mfd/syscon-common.example.dts] Error 1 make[2]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/mfd/syscon-common.yaml:68:3: expected <block end>, but found '?' make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2 make: *** [Makefile:251: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241213-contrib-pg-cpu-hotplug-suspend2ram-fixes-v1-v1-2-c72978f63713@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Mon, Dec 16, 2024 at 8:19 AM Rob Herring <robh@kernel.org> wrote: > > On Fri, Dec 13, 2024 at 04:44:39PM +0000, Peter Griffin wrote: > > To avoid dtschema warnings allow google,gs101-pmu to have > > two reg regions. > > It's not a "simple" syscon if you have 2 regions, so put it in its own > schema doc. NM, I see it already does. If you keep 'syscon', then 'maxItems: 1' will probably need to move to syscon.yaml. Rob
On 13/12/2024 17:44, Peter Griffin wrote: > To avoid dtschema warnings allow google,gs101-pmu to have > two reg regions. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- > I don't really like this patch, but also didn't want to submit the series > with a dtschema warning ;-) > > Possibly a better solution is when Robs patch > `mfd: syscon: Allow syscon nodes without a "syscon" compatible` [1] PMU which spans over two blocks is not a simple syscon. These would be two syscon devices. If you request regmap from such syscon, which regmap you get? I am not sure whether the PMU is really split here. Usually the main PMU was only one and additional blocks called PMU were somehow specialized per each IP block. Maybe you have here two devices, maybe only one. If it is only one, then it is not a syscon anymore, IMO. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/syscon-common.yaml b/Documentation/devicetree/bindings/mfd/syscon-common.yaml index 451cbad467a3..9cd9739d5e97 100644 --- a/Documentation/devicetree/bindings/mfd/syscon-common.yaml +++ b/Documentation/devicetree/bindings/mfd/syscon-common.yaml @@ -59,6 +59,16 @@ allOf: compatible: minItems: 3 maxItems: 5 + - if: + properties: + compatible: + contains: + const: + - google,gs101-pmu + then: + properties: + reg: + maxItems: 2 additionalProperties: true
To avoid dtschema warnings allow google,gs101-pmu to have two reg regions. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- I don't really like this patch, but also didn't want to submit the series with a dtschema warning ;-) Possibly a better solution is when Robs patch `mfd: syscon: Allow syscon nodes without a "syscon" compatible` [1] gets updated with a v2, we could remove syscon compatible from gs101.dtsi (an ABI issue). If I understood his patch correctly, it would mean this yaml update would then no longer be required. Let me know your thoughts [1] https://lore.kernel.org/lkml/20241211-syscon-fixes-v1-0-b5ac8c219e96@kernel.org/T/#m5ad1ed5c69f693d2a5cc54342a87fbdf3df756d2 --- Documentation/devicetree/bindings/mfd/syscon-common.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)