| Message ID | 20241213190750.2513964-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | whole-tree: Constify Property structures | expand |
On 12/13/24 13:06, Richard Henderson wrote: > Since d36f165d952 (qdev: make properties array "const"), we can > define our Property structure const. Do this across the entire tree. > > There are a few other minor changes: > - Two instances where it was obvious that an empty property list > could be removed entirely. There are other empty lists that > probably should be removed, but I didn't look further into usage. > - In hw/misc/xlnx-versal-trng.c, adjust a Property to use the > correct PropertyInfo in the definition, rather than setting > it at runtime. > - One instance where { } was used instead of DEFINE_PROP_END_OF_LIST. > Not a bug, but wrong style. I also meant to report that for qemu-system-aarch64 (the only one I checked), this moves 150k from .data to .data.rel.ro. I'm somewhat surprised there's that many, or that Property is as large as it is at 88 bytes. r~
On 13/12/24 20:06, Richard Henderson wrote: > Since d36f165d952 (qdev: make properties array "const"), we can > define our Property structure const. Do this across the entire tree. > > There are a few other minor changes: > - Two instances where it was obvious that an empty property list > could be removed entirely. There are other empty lists that > probably should be removed, but I didn't look further into usage. > - In hw/misc/xlnx-versal-trng.c, adjust a Property to use the > correct PropertyInfo in the definition, rather than setting > it at runtime. > - One instance where { } was used instead of DEFINE_PROP_END_OF_LIST. > Not a bug, but wrong style. > > > r~ > > > Richard Henderson (71): > target/arm: Constify all Property > target/avr: Constify all Property > target/hexagon: Constify all Property > target/i386: Constify all Property > target/microblaze: Constify all Property > target/mips: Constify all Property > target/ppc: Remove empty property list > target/riscv: Constify all Property > target/s390x: Constify all Property > target/sparc: Constify all Property and PropertyInfo > cpu-target: Constify all Property > hw/9pfs: Constify all Property > hw/acpi: Constify all Property > hw/adc: Constify all Property > hw/arm: Constify all Property > hw/audio: Constify all Property > hw/avr: Constify all Property > hw/block/xen-block: Unexport PropertyInfo > hw/block: Constify all Property > hw/char: Constify all Property > hw/core: Constify all Property > hw/cpu: Constify all Property > hw/cxl: Constify all Property > hw/display: Constify all Property > hw/dma: Constify all Property > hw/gpio: Constify all Property > hw/hyperv: Constify all Property > hw/i2c: Constify all Property > hw/i386: Constify all Property > hw/ide: Constify all Property > hw/input: Constify all Property > hw/intc: Constify all Property > hw/ipack: Constify all Property > hw/ipmi: Constify all Property > hw/isa: Constify all Property > hw/m68k: Constify all Property > hw/mem: Constify all Property > hw/mips: Constify all Property > hw/misc/xlnx-versal-trng: Constify trng_props > hw/misc: Constify all Property > hw/net: Constify all Property > hw/nubus: Constify all Property > hw/nvme: Constify all Property > hw/nvram: Constify all Property > hw/pci-bridge: Constify all Property > hw/pci-host/astro: Remove empty Property list > hw/pci-host: Constify all Property > hw/pci: Constify all Property > hw/ppc: Constify all Property > hw/remote: Constify all Property > hw/riscv: Constify all Property > hw/rtc: Constify all Property > hw/rx: Constify all Property > hw/s390x: Constify all Property > hw/scsi: Constify all Property > hw/sd: Constify all Property > hw/sparc: Constify all Property > hw/sparc64: Constify all Property > hw/ssi: Constify all Property > hw/timer: Constify all Property > hw/tpm: Constify all Property > hw/tricore: Constify all Property > hw/ufs: Constify all Property > hw/usb: Constify all Property > hw/vfio: Constify all Property > hw/virtio: Constify all Property > hw/watchdog: Constify all Property > hw/xen: Constify all Property > hw/xen: Use DEFINE_PROP_END_OF_LIST in xen_sysdev_properties > tests/unit: Constify all Property > docs: Constify all Property in examples Series: Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On 12/13/24 20:07, Richard Henderson wrote: > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > hw/net/allwinner-sun8i-emac.c | 2 +- > hw/net/allwinner_emac.c | 2 +- > hw/net/cadence_gem.c | 2 +- > hw/net/can/xlnx-versal-canfd.c | 2 +- > hw/net/can/xlnx-zynqmp-can.c | 2 +- > hw/net/dp8393x.c | 2 +- > hw/net/e1000.c | 2 +- > hw/net/e1000e.c | 2 +- > hw/net/eepro100.c | 2 +- > hw/net/fsl_etsec/etsec.c | 2 +- > hw/net/ftgmac100.c | 4 ++-- > hw/net/igb.c | 2 +- > hw/net/imx_fec.c | 2 +- > hw/net/lan9118.c | 2 +- > hw/net/lance.c | 2 +- > hw/net/lasi_i82596.c | 2 +- > hw/net/mcf_fec.c | 2 +- > hw/net/mipsnet.c | 2 +- > hw/net/msf2-emac.c | 2 +- > hw/net/mv88w8618_eth.c | 2 +- > hw/net/ne2000-isa.c | 2 +- > hw/net/ne2000-pci.c | 2 +- > hw/net/npcm7xx_emc.c | 2 +- > hw/net/npcm_gmac.c | 2 +- > hw/net/opencores_eth.c | 2 +- > hw/net/pcnet-pci.c | 2 +- > hw/net/rocker/rocker.c | 2 +- > hw/net/rtl8139.c | 2 +- > hw/net/smc91c111.c | 2 +- > hw/net/spapr_llan.c | 2 +- > hw/net/stellaris_enet.c | 2 +- > hw/net/sungem.c | 2 +- > hw/net/sunhme.c | 2 +- > hw/net/tulip.c | 2 +- > hw/net/virtio-net.c | 2 +- > hw/net/vmxnet3.c | 2 +- > hw/net/xen_nic.c | 2 +- > hw/net/xgmac.c | 2 +- > hw/net/xilinx_axienet.c | 2 +- > hw/net/xilinx_ethlite.c | 2 +- > 40 files changed, 41 insertions(+), 41 deletions(-) For the ftgmac100, Reviewed-by: Cédric Le Goater <clg@redhat.com> Thanks, C. > > diff --git a/hw/net/allwinner-sun8i-emac.c b/hw/net/allwinner-sun8i-emac.c > index cdae74f503..3f03060bf5 100644 > --- a/hw/net/allwinner-sun8i-emac.c > +++ b/hw/net/allwinner-sun8i-emac.c > @@ -829,7 +829,7 @@ static void allwinner_sun8i_emac_realize(DeviceState *dev, Error **errp) > qemu_format_nic_info_str(qemu_get_queue(s->nic), s->conf.macaddr.a); > } > > -static Property allwinner_sun8i_emac_properties[] = { > +static const Property allwinner_sun8i_emac_properties[] = { > DEFINE_NIC_PROPERTIES(AwSun8iEmacState, conf), > DEFINE_PROP_UINT8("phy-addr", AwSun8iEmacState, mii_phy_addr, 0), > DEFINE_PROP_LINK("dma-memory", AwSun8iEmacState, dma_mr, > diff --git a/hw/net/allwinner_emac.c b/hw/net/allwinner_emac.c > index c104c2588e..39c10426cf 100644 > --- a/hw/net/allwinner_emac.c > +++ b/hw/net/allwinner_emac.c > @@ -462,7 +462,7 @@ static void aw_emac_realize(DeviceState *dev, Error **errp) > fifo8_create(&s->tx_fifo[1], TX_FIFO_SIZE); > } > > -static Property aw_emac_properties[] = { > +static const Property aw_emac_properties[] = { > DEFINE_NIC_PROPERTIES(AwEmacState, conf), > DEFINE_PROP_UINT8("phy-addr", AwEmacState, phy_addr, 0), > DEFINE_PROP_END_OF_LIST(), > diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c > index 526739887c..3fce01315f 100644 > --- a/hw/net/cadence_gem.c > +++ b/hw/net/cadence_gem.c > @@ -1784,7 +1784,7 @@ static const VMStateDescription vmstate_cadence_gem = { > } > }; > > -static Property gem_properties[] = { > +static const Property gem_properties[] = { > DEFINE_NIC_PROPERTIES(CadenceGEMState, conf), > DEFINE_PROP_UINT32("revision", CadenceGEMState, revision, > GEM_MODID_VALUE), > diff --git a/hw/net/can/xlnx-versal-canfd.c b/hw/net/can/xlnx-versal-canfd.c > index e148bd7b46..97fa46c4b3 100644 > --- a/hw/net/can/xlnx-versal-canfd.c > +++ b/hw/net/can/xlnx-versal-canfd.c > @@ -2042,7 +2042,7 @@ static const VMStateDescription vmstate_canfd = { > } > }; > > -static Property canfd_core_properties[] = { > +static const Property canfd_core_properties[] = { > DEFINE_PROP_UINT8("rx-fifo0", XlnxVersalCANFDState, cfg.rx0_fifo, 0x40), > DEFINE_PROP_UINT8("rx-fifo1", XlnxVersalCANFDState, cfg.rx1_fifo, 0x40), > DEFINE_PROP_UINT8("tx-fifo", XlnxVersalCANFDState, cfg.tx_fifo, 0x20), > diff --git a/hw/net/can/xlnx-zynqmp-can.c b/hw/net/can/xlnx-zynqmp-can.c > index 58f1432bb3..61c104c18b 100644 > --- a/hw/net/can/xlnx-zynqmp-can.c > +++ b/hw/net/can/xlnx-zynqmp-can.c > @@ -1169,7 +1169,7 @@ static const VMStateDescription vmstate_can = { > } > }; > > -static Property xlnx_zynqmp_can_properties[] = { > +static const Property xlnx_zynqmp_can_properties[] = { > DEFINE_PROP_UINT32("ext_clk_freq", XlnxZynqMPCANState, cfg.ext_clk_freq, > CAN_DEFAULT_CLOCK), > DEFINE_PROP_LINK("canbus", XlnxZynqMPCANState, canbus, TYPE_CAN_BUS, > diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c > index c0977308ba..e3ca11991b 100644 > --- a/hw/net/dp8393x.c > +++ b/hw/net/dp8393x.c > @@ -931,7 +931,7 @@ static const VMStateDescription vmstate_dp8393x = { > } > }; > > -static Property dp8393x_properties[] = { > +static const Property dp8393x_properties[] = { > DEFINE_NIC_PROPERTIES(dp8393xState, conf), > DEFINE_PROP_LINK("dma_mr", dp8393xState, dma_mr, > TYPE_MEMORY_REGION, MemoryRegion *), > diff --git a/hw/net/e1000.c b/hw/net/e1000.c > index ab72236d18..ef0af31751 100644 > --- a/hw/net/e1000.c > +++ b/hw/net/e1000.c > @@ -1677,7 +1677,7 @@ static void pci_e1000_realize(PCIDevice *pci_dev, Error **errp) > e1000_flush_queue_timer, d); > } > > -static Property e1000_properties[] = { > +static const Property e1000_properties[] = { > DEFINE_NIC_PROPERTIES(E1000State, conf), > DEFINE_PROP_BIT("extra_mac_registers", E1000State, > compat_flags, E1000_FLAG_MAC_BIT, true), > diff --git a/hw/net/e1000e.c b/hw/net/e1000e.c > index 843892ce09..e2b7576f67 100644 > --- a/hw/net/e1000e.c > +++ b/hw/net/e1000e.c > @@ -661,7 +661,7 @@ static PropertyInfo e1000e_prop_disable_vnet, > e1000e_prop_subsys_ven, > e1000e_prop_subsys; > > -static Property e1000e_properties[] = { > +static const Property e1000e_properties[] = { > DEFINE_NIC_PROPERTIES(E1000EState, conf), > DEFINE_PROP_SIGNED("disable_vnet_hdr", E1000EState, disable_vnet, false, > e1000e_prop_disable_vnet, bool), > diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c > index 20b22d8e49..b8cb8d5cf1 100644 > --- a/hw/net/eepro100.c > +++ b/hw/net/eepro100.c > @@ -2058,7 +2058,7 @@ static E100PCIDeviceInfo *eepro100_get_class(EEPRO100State *s) > return eepro100_get_class_by_name(object_get_typename(OBJECT(s))); > } > > -static Property e100_properties[] = { > +static const Property e100_properties[] = { > DEFINE_NIC_PROPERTIES(EEPRO100State, conf), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c > index d8076e7be4..764be2c6a2 100644 > --- a/hw/net/fsl_etsec/etsec.c > +++ b/hw/net/fsl_etsec/etsec.c > @@ -414,7 +414,7 @@ static void etsec_instance_init(Object *obj) > sysbus_init_irq(sbd, &etsec->err_irq); > } > > -static Property etsec_properties[] = { > +static const Property etsec_properties[] = { > DEFINE_NIC_PROPERTIES(eTSEC, conf), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/net/ftgmac100.c b/hw/net/ftgmac100.c > index 478356ee3e..4adc7fb10c 100644 > --- a/hw/net/ftgmac100.c > +++ b/hw/net/ftgmac100.c > @@ -1254,7 +1254,7 @@ static const VMStateDescription vmstate_ftgmac100 = { > } > }; > > -static Property ftgmac100_properties[] = { > +static const Property ftgmac100_properties[] = { > DEFINE_PROP_BOOL("aspeed", FTGMAC100State, aspeed, false), > DEFINE_NIC_PROPERTIES(FTGMAC100State, conf), > DEFINE_PROP_BOOL("dma64", FTGMAC100State, dma64, false), > @@ -1415,7 +1415,7 @@ static const VMStateDescription vmstate_aspeed_mii = { > } > }; > > -static Property aspeed_mii_properties[] = { > +static const Property aspeed_mii_properties[] = { > DEFINE_PROP_LINK("nic", AspeedMiiState, nic, TYPE_FTGMAC100, > FTGMAC100State *), > DEFINE_PROP_END_OF_LIST(), > diff --git a/hw/net/igb.c b/hw/net/igb.c > index b92bba402e..ad0f748d82 100644 > --- a/hw/net/igb.c > +++ b/hw/net/igb.c > @@ -591,7 +591,7 @@ static const VMStateDescription igb_vmstate = { > } > }; > > -static Property igb_properties[] = { > +static const Property igb_properties[] = { > DEFINE_NIC_PROPERTIES(IGBState, conf), > DEFINE_PROP_BOOL("x-pcie-flr-init", IGBState, has_flr, true), > DEFINE_PROP_END_OF_LIST(), > diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c > index 4ee6f74206..9b64968477 100644 > --- a/hw/net/imx_fec.c > +++ b/hw/net/imx_fec.c > @@ -1222,7 +1222,7 @@ static void imx_eth_realize(DeviceState *dev, Error **errp) > qemu_format_nic_info_str(qemu_get_queue(s->nic), s->conf.macaddr.a); > } > > -static Property imx_eth_properties[] = { > +static const Property imx_eth_properties[] = { > DEFINE_NIC_PROPERTIES(IMXFECState, conf), > DEFINE_PROP_UINT32("tx-ring-num", IMXFECState, tx_ring_num, 1), > DEFINE_PROP_UINT32("phy-num", IMXFECState, phy_num, 0), > diff --git a/hw/net/lan9118.c b/hw/net/lan9118.c > index 99e87b7178..237e9b97d5 100644 > --- a/hw/net/lan9118.c > +++ b/hw/net/lan9118.c > @@ -1304,7 +1304,7 @@ static void lan9118_realize(DeviceState *dev, Error **errp) > ptimer_transaction_commit(s->timer); > } > > -static Property lan9118_properties[] = { > +static const Property lan9118_properties[] = { > DEFINE_NIC_PROPERTIES(lan9118_state, conf), > DEFINE_PROP_UINT32("mode_16bit", lan9118_state, mode_16bit, 0), > DEFINE_PROP_END_OF_LIST(), > diff --git a/hw/net/lance.c b/hw/net/lance.c > index 269615b452..9ed9c94cff 100644 > --- a/hw/net/lance.c > +++ b/hw/net/lance.c > @@ -137,7 +137,7 @@ static void lance_instance_init(Object *obj) > DEVICE(obj)); > } > > -static Property lance_properties[] = { > +static const Property lance_properties[] = { > DEFINE_PROP_LINK("dma", SysBusPCNetState, state.dma_opaque, > TYPE_DEVICE, DeviceState *), > DEFINE_NIC_PROPERTIES(SysBusPCNetState, state.conf), > diff --git a/hw/net/lasi_i82596.c b/hw/net/lasi_i82596.c > index 183fab8712..248e3841db 100644 > --- a/hw/net/lasi_i82596.c > +++ b/hw/net/lasi_i82596.c > @@ -158,7 +158,7 @@ static void lasi_82596_instance_init(Object *obj) > DEVICE(obj)); > } > > -static Property lasi_82596_properties[] = { > +static const Property lasi_82596_properties[] = { > DEFINE_NIC_PROPERTIES(SysBusI82596State, state.conf), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/net/mcf_fec.c b/hw/net/mcf_fec.c > index 037cd2028e..55bad4c069 100644 > --- a/hw/net/mcf_fec.c > +++ b/hw/net/mcf_fec.c > @@ -660,7 +660,7 @@ static void mcf_fec_instance_init(Object *obj) > } > } > > -static Property mcf_fec_properties[] = { > +static const Property mcf_fec_properties[] = { > DEFINE_NIC_PROPERTIES(mcf_fec_state, conf), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/net/mipsnet.c b/hw/net/mipsnet.c > index 31bbd6fb89..c9ef1beb7b 100644 > --- a/hw/net/mipsnet.c > +++ b/hw/net/mipsnet.c > @@ -266,7 +266,7 @@ static void mipsnet_sysbus_reset(DeviceState *dev) > mipsnet_reset(s); > } > > -static Property mipsnet_properties[] = { > +static const Property mipsnet_properties[] = { > DEFINE_NIC_PROPERTIES(MIPSnetState, conf), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/net/msf2-emac.c b/hw/net/msf2-emac.c > index d28fc6c570..8d9015f962 100644 > --- a/hw/net/msf2-emac.c > +++ b/hw/net/msf2-emac.c > @@ -546,7 +546,7 @@ static void msf2_emac_init(Object *obj) > sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio); > } > > -static Property msf2_emac_properties[] = { > +static const Property msf2_emac_properties[] = { > DEFINE_PROP_LINK("ahb-bus", MSF2EmacState, dma_mr, > TYPE_MEMORY_REGION, MemoryRegion *), > DEFINE_NIC_PROPERTIES(MSF2EmacState, conf), > diff --git a/hw/net/mv88w8618_eth.c b/hw/net/mv88w8618_eth.c > index 96c65f4d46..ccb11512db 100644 > --- a/hw/net/mv88w8618_eth.c > +++ b/hw/net/mv88w8618_eth.c > @@ -371,7 +371,7 @@ static const VMStateDescription mv88w8618_eth_vmsd = { > } > }; > > -static Property mv88w8618_eth_properties[] = { > +static const Property mv88w8618_eth_properties[] = { > DEFINE_NIC_PROPERTIES(mv88w8618_eth_state, conf), > DEFINE_PROP_LINK("dma-memory", mv88w8618_eth_state, dma_mr, > TYPE_MEMORY_REGION, MemoryRegion *), > diff --git a/hw/net/ne2000-isa.c b/hw/net/ne2000-isa.c > index 26980e087e..1cd070d419 100644 > --- a/hw/net/ne2000-isa.c > +++ b/hw/net/ne2000-isa.c > @@ -79,7 +79,7 @@ static void isa_ne2000_realizefn(DeviceState *dev, Error **errp) > qemu_format_nic_info_str(qemu_get_queue(s->nic), s->c.macaddr.a); > } > > -static Property ne2000_isa_properties[] = { > +static const Property ne2000_isa_properties[] = { > DEFINE_PROP_UINT32("iobase", ISANE2000State, iobase, 0x300), > DEFINE_PROP_UINT32("irq", ISANE2000State, isairq, 9), > DEFINE_NIC_PROPERTIES(ISANE2000State, ne2000.c), > diff --git a/hw/net/ne2000-pci.c b/hw/net/ne2000-pci.c > index 74773069c6..12fa579d22 100644 > --- a/hw/net/ne2000-pci.c > +++ b/hw/net/ne2000-pci.c > @@ -96,7 +96,7 @@ static void ne2000_instance_init(Object *obj) > &pci_dev->qdev); > } > > -static Property ne2000_properties[] = { > +static const Property ne2000_properties[] = { > DEFINE_NIC_PROPERTIES(PCINE2000State, ne2000.c), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/net/npcm7xx_emc.c b/hw/net/npcm7xx_emc.c > index 7307a13400..f06e908d04 100644 > --- a/hw/net/npcm7xx_emc.c > +++ b/hw/net/npcm7xx_emc.c > @@ -845,7 +845,7 @@ static const VMStateDescription vmstate_npcm7xx_emc = { > }, > }; > > -static Property npcm7xx_emc_properties[] = { > +static const Property npcm7xx_emc_properties[] = { > DEFINE_NIC_PROPERTIES(NPCM7xxEMCState, conf), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/net/npcm_gmac.c b/hw/net/npcm_gmac.c > index 685905f9e2..1db29307d7 100644 > --- a/hw/net/npcm_gmac.c > +++ b/hw/net/npcm_gmac.c > @@ -912,7 +912,7 @@ static const VMStateDescription vmstate_npcm_gmac = { > }, > }; > > -static Property npcm_gmac_properties[] = { > +static const Property npcm_gmac_properties[] = { > DEFINE_NIC_PROPERTIES(NPCMGMACState, conf), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/net/opencores_eth.c b/hw/net/opencores_eth.c > index 2c0ebda100..003b452bc9 100644 > --- a/hw/net/opencores_eth.c > +++ b/hw/net/opencores_eth.c > @@ -743,7 +743,7 @@ static void qdev_open_eth_reset(DeviceState *dev) > open_eth_reset(d); > } > > -static Property open_eth_properties[] = { > +static const Property open_eth_properties[] = { > DEFINE_NIC_PROPERTIES(OpenEthState, conf), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/net/pcnet-pci.c b/hw/net/pcnet-pci.c > index 6190b76916..83ba8cd949 100644 > --- a/hw/net/pcnet-pci.c > +++ b/hw/net/pcnet-pci.c > @@ -252,7 +252,7 @@ static void pcnet_instance_init(Object *obj) > DEVICE(obj)); > } > > -static Property pcnet_properties[] = { > +static const Property pcnet_properties[] = { > DEFINE_NIC_PROPERTIES(PCIPCNetState, state.conf), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c > index 5e74acc969..efc20396aa 100644 > --- a/hw/net/rocker/rocker.c > +++ b/hw/net/rocker/rocker.c > @@ -1459,7 +1459,7 @@ static void rocker_reset(DeviceState *dev) > DPRINTF("Reset done\n"); > } > > -static Property rocker_properties[] = { > +static const Property rocker_properties[] = { > DEFINE_PROP_STRING("name", Rocker, name), > DEFINE_PROP_STRING("world", Rocker, world_name), > DEFINE_PROP_MACADDR("fp_start_macaddr", Rocker, > diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c > index bc56075c0d..064a73b6b4 100644 > --- a/hw/net/rtl8139.c > +++ b/hw/net/rtl8139.c > @@ -3410,7 +3410,7 @@ static void rtl8139_instance_init(Object *obj) > DEVICE(obj)); > } > > -static Property rtl8139_properties[] = { > +static const Property rtl8139_properties[] = { > DEFINE_NIC_PROPERTIES(RTL8139State, conf), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c > index 180ba5c791..a853c30fa2 100644 > --- a/hw/net/smc91c111.c > +++ b/hw/net/smc91c111.c > @@ -788,7 +788,7 @@ static void smc91c111_realize(DeviceState *dev, Error **errp) > /* ??? Save/restore. */ > } > > -static Property smc91c111_properties[] = { > +static const Property smc91c111_properties[] = { > DEFINE_NIC_PROPERTIES(smc91c111_state, conf), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/net/spapr_llan.c b/hw/net/spapr_llan.c > index 8af33d91b6..d381c041db 100644 > --- a/hw/net/spapr_llan.c > +++ b/hw/net/spapr_llan.c > @@ -786,7 +786,7 @@ static target_ulong h_change_logical_lan_mac(PowerPCCPU *cpu, > return H_SUCCESS; > } > > -static Property spapr_vlan_properties[] = { > +static const Property spapr_vlan_properties[] = { > DEFINE_SPAPR_PROPERTIES(SpaprVioVlan, sdev), > DEFINE_NIC_PROPERTIES(SpaprVioVlan, nicconf), > DEFINE_PROP_BIT("use-rx-buffer-pools", SpaprVioVlan, > diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c > index 9ebff296c4..4af1afa733 100644 > --- a/hw/net/stellaris_enet.c > +++ b/hw/net/stellaris_enet.c > @@ -497,7 +497,7 @@ static void stellaris_enet_realize(DeviceState *dev, Error **errp) > qemu_format_nic_info_str(qemu_get_queue(s->nic), s->conf.macaddr.a); > } > > -static Property stellaris_enet_properties[] = { > +static const Property stellaris_enet_properties[] = { > DEFINE_NIC_PROPERTIES(stellaris_enet_state, conf), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/net/sungem.c b/hw/net/sungem.c > index 67087e9842..bcc7a18382 100644 > --- a/hw/net/sungem.c > +++ b/hw/net/sungem.c > @@ -1420,7 +1420,7 @@ static void sungem_instance_init(Object *obj) > DEVICE(obj)); > } > > -static Property sungem_properties[] = { > +static const Property sungem_properties[] = { > DEFINE_NIC_PROPERTIES(SunGEMState, conf), > /* Phy address should be 0 for most Apple machines except > * for K2 in which case it's 1. Will be set by a machine > diff --git a/hw/net/sunhme.c b/hw/net/sunhme.c > index 0e6c655a5b..86f472fcbe 100644 > --- a/hw/net/sunhme.c > +++ b/hw/net/sunhme.c > @@ -177,7 +177,7 @@ struct SunHMEState { > uint16_t miiregs[HME_MII_REGS_SIZE]; > }; > > -static Property sunhme_properties[] = { > +static const Property sunhme_properties[] = { > DEFINE_NIC_PROPERTIES(SunHMEState, conf), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/net/tulip.c b/hw/net/tulip.c > index 9df3e17162..f35b58a88c 100644 > --- a/hw/net/tulip.c > +++ b/hw/net/tulip.c > @@ -1007,7 +1007,7 @@ static void tulip_instance_init(Object *obj) > &pci_dev->qdev); > } > > -static Property tulip_properties[] = { > +static const Property tulip_properties[] = { > DEFINE_NIC_PROPERTIES(TULIPState, c), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > index 6e8c51a2db..4fd1f9acca 100644 > --- a/hw/net/virtio-net.c > +++ b/hw/net/virtio-net.c > @@ -3985,7 +3985,7 @@ static const VMStateDescription vmstate_virtio_net = { > .dev_unplug_pending = dev_unplug_pending, > }; > > -static Property virtio_net_properties[] = { > +static const Property virtio_net_properties[] = { > DEFINE_PROP_BIT64("csum", VirtIONet, host_features, > VIRTIO_NET_F_CSUM, true), > DEFINE_PROP_BIT64("guest_csum", VirtIONet, host_features, > diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c > index 8aa8c46228..f69547cad5 100644 > --- a/hw/net/vmxnet3.c > +++ b/hw/net/vmxnet3.c > @@ -2471,7 +2471,7 @@ static const VMStateDescription vmstate_vmxnet3 = { > } > }; > > -static Property vmxnet3_properties[] = { > +static const Property vmxnet3_properties[] = { > DEFINE_NIC_PROPERTIES(VMXNET3State, conf), > DEFINE_PROP_BIT("x-old-msi-offsets", VMXNET3State, compat_flags, > VMXNET3_COMPAT_FLAG_OLD_MSI_OFFSETS_BIT, false), > diff --git a/hw/net/xen_nic.c b/hw/net/xen_nic.c > index 89487b49ba..5a5259150a 100644 > --- a/hw/net/xen_nic.c > +++ b/hw/net/xen_nic.c > @@ -555,7 +555,7 @@ static void xen_netdev_unrealize(XenDevice *xendev) > > /* ------------------------------------------------------------- */ > > -static Property xen_netdev_properties[] = { > +static const Property xen_netdev_properties[] = { > DEFINE_NIC_PROPERTIES(XenNetDev, conf), > DEFINE_PROP_INT32("idx", XenNetDev, dev, -1), > DEFINE_PROP_END_OF_LIST(), > diff --git a/hw/net/xgmac.c b/hw/net/xgmac.c > index ffe3fc8dbe..6e0f96f485 100644 > --- a/hw/net/xgmac.c > +++ b/hw/net/xgmac.c > @@ -414,7 +414,7 @@ static void xgmac_enet_realize(DeviceState *dev, Error **errp) > s->conf.macaddr.a[0]; > } > > -static Property xgmac_properties[] = { > +static const Property xgmac_properties[] = { > DEFINE_NIC_PROPERTIES(XgmacState, conf), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/net/xilinx_axienet.c b/hw/net/xilinx_axienet.c > index faf27947b0..9d0c618e2f 100644 > --- a/hw/net/xilinx_axienet.c > +++ b/hw/net/xilinx_axienet.c > @@ -996,7 +996,7 @@ static void xilinx_enet_init(Object *obj) > sysbus_init_mmio(sbd, &s->iomem); > } > > -static Property xilinx_enet_properties[] = { > +static const Property xilinx_enet_properties[] = { > DEFINE_PROP_UINT32("phyaddr", XilinxAXIEnet, c_phyaddr, 7), > DEFINE_PROP_UINT32("rxmem", XilinxAXIEnet, c_rxmem, 0x1000), > DEFINE_PROP_UINT32("txmem", XilinxAXIEnet, c_txmem, 0x1000), > diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c > index bd81290808..9413731d20 100644 > --- a/hw/net/xilinx_ethlite.c > +++ b/hw/net/xilinx_ethlite.c > @@ -251,7 +251,7 @@ static void xilinx_ethlite_init(Object *obj) > sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio); > } > > -static Property xilinx_ethlite_properties[] = { > +static const Property xilinx_ethlite_properties[] = { > DEFINE_PROP_UINT32("tx-ping-pong", struct xlx_ethlite, c_tx_pingpong, 1), > DEFINE_PROP_UINT32("rx-ping-pong", struct xlx_ethlite, c_rx_pingpong, 1), > DEFINE_NIC_PROPERTIES(struct xlx_ethlite, conf),
Am 13. Dezember 2024 19:06:30 UTC schrieb Richard Henderson <richard.henderson@linaro.org>: >Since d36f165d952 (qdev: make properties array "const"), we can >define our Property structure const. Do this across the entire tree. > >There are a few other minor changes: > - Two instances where it was obvious that an empty property list > could be removed entirely. There are other empty lists that > probably should be removed, but I didn't look further into usage. > - In hw/misc/xlnx-versal-trng.c, adjust a Property to use the > correct PropertyInfo in the definition, rather than setting > it at runtime. > - One instance where { } was used instead of DEFINE_PROP_END_OF_LIST. > Not a bug, but wrong style. > > >r~ > > >Richard Henderson (71): > target/arm: Constify all Property > target/avr: Constify all Property > target/hexagon: Constify all Property > target/i386: Constify all Property > target/microblaze: Constify all Property > target/mips: Constify all Property > target/ppc: Remove empty property list > target/riscv: Constify all Property > target/s390x: Constify all Property > target/sparc: Constify all Property and PropertyInfo > cpu-target: Constify all Property > hw/9pfs: Constify all Property > hw/acpi: Constify all Property > hw/adc: Constify all Property > hw/arm: Constify all Property > hw/audio: Constify all Property > hw/avr: Constify all Property > hw/block/xen-block: Unexport PropertyInfo > hw/block: Constify all Property > hw/char: Constify all Property > hw/core: Constify all Property > hw/cpu: Constify all Property > hw/cxl: Constify all Property > hw/display: Constify all Property > hw/dma: Constify all Property > hw/gpio: Constify all Property > hw/hyperv: Constify all Property > hw/i2c: Constify all Property > hw/i386: Constify all Property > hw/ide: Constify all Property > hw/input: Constify all Property > hw/intc: Constify all Property > hw/ipack: Constify all Property > hw/ipmi: Constify all Property > hw/isa: Constify all Property > hw/m68k: Constify all Property > hw/mem: Constify all Property > hw/mips: Constify all Property > hw/misc/xlnx-versal-trng: Constify trng_props > hw/misc: Constify all Property > hw/net: Constify all Property > hw/nubus: Constify all Property > hw/nvme: Constify all Property > hw/nvram: Constify all Property > hw/pci-bridge: Constify all Property > hw/pci-host/astro: Remove empty Property list > hw/pci-host: Constify all Property > hw/pci: Constify all Property > hw/ppc: Constify all Property > hw/remote: Constify all Property > hw/riscv: Constify all Property > hw/rtc: Constify all Property > hw/rx: Constify all Property > hw/s390x: Constify all Property > hw/scsi: Constify all Property > hw/sd: Constify all Property > hw/sparc: Constify all Property > hw/sparc64: Constify all Property > hw/ssi: Constify all Property > hw/timer: Constify all Property > hw/tpm: Constify all Property > hw/tricore: Constify all Property > hw/ufs: Constify all Property > hw/usb: Constify all Property > hw/vfio: Constify all Property > hw/virtio: Constify all Property > hw/watchdog: Constify all Property > hw/xen: Constify all Property > hw/xen: Use DEFINE_PROP_END_OF_LIST in xen_sysdev_properties > tests/unit: Constify all Property > docs: Constify all Property in examples > > cpu-target.c | 2 +- > hw/9pfs/virtio-9p-device.c | 2 +- > hw/acpi/erst.c | 2 +- > hw/acpi/generic_event_device.c | 2 +- > hw/acpi/piix4.c | 2 +- > hw/acpi/vmgenid.c | 2 +- > hw/adc/aspeed_adc.c | 2 +- > hw/adc/npcm7xx_adc.c | 2 +- > hw/arm/armsse.c | 8 ++++---- > hw/arm/armv7m.c | 4 ++-- > hw/arm/aspeed_soc_common.c | 2 +- > hw/arm/bcm2836.c | 2 +- > hw/arm/fsl-imx25.c | 2 +- > hw/arm/fsl-imx6.c | 2 +- > hw/arm/fsl-imx6ul.c | 2 +- > hw/arm/fsl-imx7.c | 2 +- > hw/arm/integratorcp.c | 2 +- > hw/arm/msf2-soc.c | 2 +- > hw/arm/npcm7xx.c | 2 +- > hw/arm/nrf51_soc.c | 2 +- > hw/arm/smmu-common.c | 2 +- > hw/arm/smmuv3.c | 2 +- > hw/arm/stellaris.c | 2 +- > hw/arm/strongarm.c | 2 +- > hw/arm/xlnx-versal.c | 2 +- > hw/arm/xlnx-zynqmp.c | 2 +- > hw/audio/ac97.c | 2 +- > hw/audio/adlib.c | 2 +- > hw/audio/asc.c | 2 +- > hw/audio/cs4231a.c | 2 +- > hw/audio/es1370.c | 2 +- > hw/audio/gus.c | 2 +- > hw/audio/hda-codec.c | 2 +- > hw/audio/intel-hda.c | 4 ++-- > hw/audio/pcspk.c | 2 +- > hw/audio/pl041.c | 2 +- > hw/audio/sb16.c | 2 +- > hw/audio/via-ac97.c | 2 +- > hw/audio/virtio-snd-pci.c | 2 +- > hw/audio/virtio-snd.c | 2 +- > hw/audio/wm8750.c | 2 +- > hw/avr/atmega.c | 2 +- > hw/block/fdc-isa.c | 2 +- > hw/block/fdc-sysbus.c | 4 ++-- > hw/block/fdc.c | 2 +- > hw/block/m25p80.c | 2 +- > hw/block/nand.c | 2 +- > hw/block/pflash_cfi01.c | 2 +- > hw/block/pflash_cfi02.c | 2 +- > hw/block/swim.c | 2 +- > hw/block/vhost-user-blk.c | 2 +- > hw/block/virtio-blk.c | 2 +- > hw/block/xen-block.c | 4 ++-- > hw/char/avr_usart.c | 2 +- > hw/char/bcm2835_aux.c | 2 +- > hw/char/cadence_uart.c | 2 +- > hw/char/cmsdk-apb-uart.c | 2 +- > hw/char/debugcon.c | 2 +- > hw/char/digic-uart.c | 2 +- > hw/char/escc.c | 2 +- > hw/char/exynos4210_uart.c | 2 +- > hw/char/goldfish_tty.c | 2 +- > hw/char/grlib_apbuart.c | 2 +- > hw/char/ibex_uart.c | 2 +- > hw/char/imx_serial.c | 2 +- > hw/char/ipoctal232.c | 2 +- > hw/char/mcf_uart.c | 2 +- > hw/char/nrf51_uart.c | 2 +- > hw/char/parallel.c | 2 +- > hw/char/pl011.c | 2 +- > hw/char/renesas_sci.c | 2 +- > hw/char/sclpconsole-lm.c | 2 +- > hw/char/sclpconsole.c | 2 +- > hw/char/serial-isa.c | 2 +- > hw/char/serial-mm.c | 2 +- > hw/char/serial-pci-multi.c | 4 ++-- > hw/char/serial-pci.c | 2 +- > hw/char/serial.c | 2 +- > hw/char/sh_serial.c | 2 +- > hw/char/shakti_uart.c | 2 +- > hw/char/sifive_uart.c | 2 +- > hw/char/spapr_vty.c | 2 +- > hw/char/stm32f2xx_usart.c | 2 +- > hw/char/stm32l4x5_usart.c | 2 +- > hw/char/terminal3270.c | 2 +- > hw/char/virtio-console.c | 2 +- > hw/char/virtio-serial-bus.c | 4 ++-- > hw/char/xen_console.c | 2 +- > hw/char/xilinx_uartlite.c | 2 +- > hw/core/generic-loader.c | 2 +- > hw/core/guest-loader.c | 2 +- > hw/core/or-irq.c | 2 +- > hw/core/platform-bus.c | 2 +- > hw/core/split-irq.c | 2 +- > hw/cpu/a15mpcore.c | 2 +- > hw/cpu/a9mpcore.c | 2 +- > hw/cpu/arm11mpcore.c | 2 +- > hw/cpu/cluster.c | 2 +- > hw/cpu/realview_mpcore.c | 2 +- > hw/cxl/switch-mailbox-cci.c | 2 +- > hw/display/artist.c | 2 +- > hw/display/ati.c | 2 +- > hw/display/bcm2835_fb.c | 2 +- > hw/display/bochs-display.c | 2 +- > hw/display/cg3.c | 2 +- > hw/display/cirrus_vga.c | 2 +- > hw/display/cirrus_vga_isa.c | 2 +- > hw/display/exynos4210_fimd.c | 2 +- > hw/display/g364fb.c | 2 +- > hw/display/i2c-ddc.c | 2 +- > hw/display/macfb.c | 4 ++-- > hw/display/pl110.c | 2 +- > hw/display/qxl.c | 2 +- > hw/display/ramfb-standalone.c | 2 +- > hw/display/sm501.c | 4 ++-- > hw/display/tcx.c | 2 +- > hw/display/vga-isa.c | 2 +- > hw/display/vga-mmio.c | 2 +- > hw/display/vga-pci.c | 4 ++-- > hw/display/vhost-user-gpu.c | 2 +- > hw/display/virtio-gpu-gl.c | 2 +- > hw/display/virtio-gpu-pci.c | 2 +- > hw/display/virtio-gpu-rutabaga.c | 2 +- > hw/display/virtio-gpu.c | 2 +- > hw/display/virtio-vga.c | 2 +- > hw/display/vmware_vga.c | 2 +- > hw/display/xlnx_dp.c | 2 +- > hw/dma/i82374.c | 2 +- > hw/dma/i8257.c | 2 +- > hw/dma/pl080.c | 2 +- > hw/dma/pl330.c | 2 +- > hw/dma/xilinx_axidma.c | 2 +- > hw/dma/xlnx-zdma.c | 2 +- > hw/dma/xlnx_csu_dma.c | 2 +- > hw/gpio/imx_gpio.c | 2 +- > hw/gpio/npcm7xx_gpio.c | 2 +- > hw/gpio/omap_gpio.c | 2 +- > hw/gpio/pca9552.c | 2 +- > hw/gpio/pca9554.c | 2 +- > hw/gpio/pl061.c | 2 +- > hw/gpio/sifive_gpio.c | 2 +- > hw/gpio/stm32l4x5_gpio.c | 2 +- > hw/hyperv/hv-balloon.c | 2 +- > hw/hyperv/syndbg.c | 2 +- > hw/hyperv/vmbus.c | 4 ++-- > hw/i2c/aspeed_i2c.c | 4 ++-- > hw/i2c/core.c | 2 +- > hw/i2c/i2c_mux_pca954x.c | 2 +- > hw/i2c/omap_i2c.c | 2 +- > hw/i386/amd_iommu.c | 2 +- > hw/i386/intel_iommu.c | 2 +- > hw/i386/kvm/clock.c | 2 +- > hw/i386/kvm/i8254.c | 2 +- > hw/i386/kvm/ioapic.c | 2 +- > hw/i386/sgx-epc.c | 2 +- > hw/i386/vmmouse.c | 2 +- > hw/i386/vmport.c | 2 +- > hw/i386/x86-iommu.c | 2 +- > hw/i386/xen/xen_pvdevice.c | 2 +- > hw/ide/ahci.c | 2 +- > hw/ide/cf.c | 2 +- > hw/ide/cmd646.c | 2 +- > hw/ide/ide-dev.c | 6 +++--- > hw/ide/isa.c | 2 +- > hw/ide/macio.c | 2 +- > hw/ide/mmio.c | 2 +- > hw/input/pckbd.c | 4 ++-- > hw/input/stellaris_gamepad.c | 2 +- > hw/input/virtio-input-hid.c | 6 +++--- > hw/input/virtio-input-host.c | 2 +- > hw/input/virtio-input.c | 2 +- > hw/intc/apic_common.c | 2 +- > hw/intc/arm_gic_common.c | 2 +- > hw/intc/arm_gicv2m.c | 2 +- > hw/intc/arm_gicv3_common.c | 2 +- > hw/intc/arm_gicv3_its.c | 2 +- > hw/intc/arm_gicv3_its_kvm.c | 2 +- > hw/intc/armv7m_nvic.c | 2 +- > hw/intc/exynos4210_combiner.c | 2 +- > hw/intc/exynos4210_gic.c | 2 +- > hw/intc/goldfish_pic.c | 2 +- > hw/intc/grlib_irqmp.c | 2 +- > hw/intc/i8259_common.c | 2 +- > hw/intc/ioapic.c | 2 +- > hw/intc/loongarch_extioi.c | 2 +- > hw/intc/loongarch_pch_msi.c | 2 +- > hw/intc/loongarch_pch_pic.c | 2 +- > hw/intc/loongson_ipi_common.c | 2 +- > hw/intc/m68k_irqc.c | 2 +- > hw/intc/mips_gic.c | 2 +- > hw/intc/omap_intc.c | 2 +- > hw/intc/ompic.c | 2 +- > hw/intc/openpic.c | 2 +- > hw/intc/openpic_kvm.c | 2 +- > hw/intc/pnv_xive.c | 2 +- > hw/intc/pnv_xive2.c | 2 +- > hw/intc/ppc-uic.c | 2 +- > hw/intc/riscv_aclint.c | 4 ++-- > hw/intc/riscv_aplic.c | 2 +- > hw/intc/riscv_imsic.c | 2 +- > hw/intc/rx_icu.c | 2 +- > hw/intc/s390_flic.c | 4 ++-- > hw/intc/sifive_plic.c | 2 +- > hw/intc/spapr_xive.c | 2 +- > hw/intc/xics.c | 4 ++-- > hw/intc/xilinx_intc.c | 2 +- > hw/intc/xive.c | 8 ++++---- > hw/intc/xive2.c | 4 ++-- > hw/intc/xlnx-pmu-iomod-intc.c | 2 +- > hw/ipack/ipack.c | 2 +- > hw/ipmi/ipmi.c | 2 +- > hw/ipmi/ipmi_bmc_extern.c | 2 +- > hw/ipmi/ipmi_bmc_sim.c | 2 +- > hw/ipmi/isa_ipmi_bt.c | 2 +- > hw/ipmi/isa_ipmi_kcs.c | 2 +- > hw/isa/lpc_ich9.c | 2 +- > hw/isa/pc87312.c | 2 +- > hw/isa/piix.c | 2 +- > hw/m68k/mcf5206.c | 2 +- > hw/m68k/mcf_intc.c | 2 +- > hw/m68k/next-cube.c | 2 +- > hw/m68k/q800-glue.c | 2 +- > hw/mem/cxl_type3.c | 2 +- > hw/mem/nvdimm.c | 2 +- > hw/mem/pc-dimm.c | 2 +- > hw/mem/sparse-mem.c | 2 +- > hw/mips/cps.c | 2 +- > hw/misc/a9scu.c | 2 +- > hw/misc/allwinner-h3-dramc.c | 2 +- > hw/misc/allwinner-r40-dramc.c | 2 +- > hw/misc/allwinner-sid.c | 2 +- > hw/misc/applesmc.c | 2 +- > hw/misc/arm11scu.c | 2 +- > hw/misc/arm_l2x0.c | 2 +- > hw/misc/arm_sysctl.c | 2 +- > hw/misc/armsse-cpuid.c | 2 +- > hw/misc/aspeed_hace.c | 2 +- > hw/misc/aspeed_i3c.c | 2 +- > hw/misc/aspeed_lpc.c | 2 +- > hw/misc/aspeed_sbc.c | 2 +- > hw/misc/aspeed_scu.c | 2 +- > hw/misc/aspeed_sdmc.c | 2 +- > hw/misc/bcm2835_cprman.c | 2 +- > hw/misc/bcm2835_property.c | 2 +- > hw/misc/debugexit.c | 2 +- > hw/misc/eccmemctl.c | 2 +- > hw/misc/empty_slot.c | 2 +- > hw/misc/iotkit-secctl.c | 2 +- > hw/misc/iotkit-sysctl.c | 2 +- > hw/misc/iotkit-sysinfo.c | 2 +- > hw/misc/ivshmem.c | 4 ++-- > hw/misc/led.c | 2 +- > hw/misc/mac_via.c | 2 +- > hw/misc/macio/cuda.c | 2 +- > hw/misc/macio/macio.c | 4 ++-- > hw/misc/macio/pmu.c | 2 +- > hw/misc/mips_cmgcr.c | 2 +- > hw/misc/mips_cpc.c | 2 +- > hw/misc/mips_itu.c | 2 +- > hw/misc/mos6522.c | 2 +- > hw/misc/mps2-fpgaio.c | 2 +- > hw/misc/mps2-scc.c | 2 +- > hw/misc/msf2-sysreg.c | 2 +- > hw/misc/npcm7xx_gcr.c | 2 +- > hw/misc/nrf51_rng.c | 2 +- > hw/misc/pci-testdev.c | 2 +- > hw/misc/pvpanic-isa.c | 2 +- > hw/misc/pvpanic-pci.c | 2 +- > hw/misc/sifive_e_aon.c | 2 +- > hw/misc/sifive_u_otp.c | 2 +- > hw/misc/stm32l4x5_rcc.c | 2 +- > hw/misc/tz-mpc.c | 2 +- > hw/misc/tz-msc.c | 2 +- > hw/misc/tz-ppc.c | 2 +- > hw/misc/unimp.c | 2 +- > hw/misc/xlnx-versal-cframe-reg.c | 4 ++-- > hw/misc/xlnx-versal-cfu.c | 4 ++-- > hw/misc/xlnx-versal-trng.c | 6 +++--- > hw/misc/xlnx-versal-xramc.c | 2 +- > hw/misc/zynq_slcr.c | 2 +- > hw/net/allwinner-sun8i-emac.c | 2 +- > hw/net/allwinner_emac.c | 2 +- > hw/net/cadence_gem.c | 2 +- > hw/net/can/xlnx-versal-canfd.c | 2 +- > hw/net/can/xlnx-zynqmp-can.c | 2 +- > hw/net/dp8393x.c | 2 +- > hw/net/e1000.c | 2 +- > hw/net/e1000e.c | 2 +- > hw/net/eepro100.c | 2 +- > hw/net/fsl_etsec/etsec.c | 2 +- > hw/net/ftgmac100.c | 4 ++-- > hw/net/igb.c | 2 +- > hw/net/imx_fec.c | 2 +- > hw/net/lan9118.c | 2 +- > hw/net/lance.c | 2 +- > hw/net/lasi_i82596.c | 2 +- > hw/net/mcf_fec.c | 2 +- > hw/net/mipsnet.c | 2 +- > hw/net/msf2-emac.c | 2 +- > hw/net/mv88w8618_eth.c | 2 +- > hw/net/ne2000-isa.c | 2 +- > hw/net/ne2000-pci.c | 2 +- > hw/net/npcm7xx_emc.c | 2 +- > hw/net/npcm_gmac.c | 2 +- > hw/net/opencores_eth.c | 2 +- > hw/net/pcnet-pci.c | 2 +- > hw/net/rocker/rocker.c | 2 +- > hw/net/rtl8139.c | 2 +- > hw/net/smc91c111.c | 2 +- > hw/net/spapr_llan.c | 2 +- > hw/net/stellaris_enet.c | 2 +- > hw/net/sungem.c | 2 +- > hw/net/sunhme.c | 2 +- > hw/net/tulip.c | 2 +- > hw/net/virtio-net.c | 2 +- > hw/net/vmxnet3.c | 2 +- > hw/net/xen_nic.c | 2 +- > hw/net/xgmac.c | 2 +- > hw/net/xilinx_axienet.c | 2 +- > hw/net/xilinx_ethlite.c | 2 +- > hw/nubus/nubus-bridge.c | 2 +- > hw/nubus/nubus-device.c | 2 +- > hw/nvme/ctrl.c | 2 +- > hw/nvme/ns.c | 2 +- > hw/nvme/subsys.c | 2 +- > hw/nvram/ds1225y.c | 2 +- > hw/nvram/eeprom_at24c.c | 2 +- > hw/nvram/fw_cfg.c | 6 +++--- > hw/nvram/mac_nvram.c | 2 +- > hw/nvram/nrf51_nvm.c | 2 +- > hw/nvram/spapr_nvram.c | 2 +- > hw/nvram/xlnx-bbram.c | 2 +- > hw/nvram/xlnx-efuse.c | 2 +- > hw/nvram/xlnx-versal-efuse-cache.c | 2 +- > hw/nvram/xlnx-versal-efuse-ctrl.c | 2 +- > hw/nvram/xlnx-zynqmp-efuse.c | 2 +- > hw/pci-bridge/cxl_downstream.c | 2 +- > hw/pci-bridge/cxl_root_port.c | 2 +- > hw/pci-bridge/cxl_upstream.c | 2 +- > hw/pci-bridge/gen_pcie_root_port.c | 2 +- > hw/pci-bridge/pci_bridge_dev.c | 2 +- > hw/pci-bridge/pci_expander_bridge.c | 4 ++-- > hw/pci-bridge/pcie_pci_bridge.c | 2 +- > hw/pci-bridge/pcie_root_port.c | 2 +- > hw/pci-bridge/xio3130_downstream.c | 2 +- > hw/pci-host/astro.c | 5 ----- > hw/pci-host/dino.c | 2 +- > hw/pci-host/gpex.c | 2 +- > hw/pci-host/grackle.c | 2 +- > hw/pci-host/gt64120.c | 2 +- > hw/pci-host/i440fx.c | 2 +- > hw/pci-host/mv64361.c | 2 +- > hw/pci-host/pnv_phb.c | 4 ++-- > hw/pci-host/pnv_phb3.c | 2 +- > hw/pci-host/pnv_phb4.c | 2 +- > hw/pci-host/pnv_phb4_pec.c | 2 +- > hw/pci-host/ppce500.c | 2 +- > hw/pci-host/q35.c | 4 ++-- > hw/pci-host/raven.c | 2 +- > hw/pci-host/sabre.c | 2 +- > hw/pci-host/uninorth.c | 2 +- > hw/pci-host/versatile.c | 2 +- > hw/pci-host/xilinx-pcie.c | 2 +- > hw/pci/pci.c | 2 +- > hw/pci/pci_bridge.c | 2 +- > hw/pci/pci_host.c | 2 +- > hw/pci/pcie_port.c | 4 ++-- > hw/ppc/pnv.c | 2 +- > hw/ppc/pnv_adu.c | 2 +- > hw/ppc/pnv_chiptod.c | 2 +- > hw/ppc/pnv_core.c | 4 ++-- > hw/ppc/pnv_homer.c | 2 +- > hw/ppc/pnv_i2c.c | 2 +- > hw/ppc/pnv_lpc.c | 2 +- > hw/ppc/pnv_pnor.c | 2 +- > hw/ppc/pnv_psi.c | 2 +- > hw/ppc/ppc405_uc.c | 2 +- > hw/ppc/ppc440_uc.c | 2 +- > hw/ppc/ppc4xx_devs.c | 4 ++-- > hw/ppc/ppc4xx_sdram.c | 4 ++-- > hw/ppc/prep_systemio.c | 2 +- > hw/ppc/rs6000_mc.c | 2 +- > hw/ppc/spapr_cpu_core.c | 2 +- > hw/ppc/spapr_nvdimm.c | 2 +- > hw/ppc/spapr_pci.c | 2 +- > hw/ppc/spapr_rng.c | 2 +- > hw/ppc/spapr_tpm_proxy.c | 2 +- > hw/remote/proxy.c | 2 +- > hw/riscv/opentitan.c | 2 +- > hw/riscv/riscv-iommu-pci.c | 2 +- > hw/riscv/riscv-iommu.c | 2 +- > hw/riscv/riscv_hart.c | 2 +- > hw/riscv/sifive_u.c | 2 +- > hw/rtc/allwinner-rtc.c | 2 +- > hw/rtc/goldfish_rtc.c | 2 +- > hw/rtc/m48t59-isa.c | 2 +- > hw/rtc/m48t59.c | 2 +- > hw/rtc/mc146818rtc.c | 2 +- > hw/rtc/pl031.c | 2 +- > hw/rx/rx62n.c | 2 +- > hw/s390x/3270-ccw.c | 2 +- > hw/s390x/ccw-device.c | 2 +- > hw/s390x/css-bridge.c | 2 +- > hw/s390x/ipl.c | 2 +- > hw/s390x/s390-pci-bus.c | 2 +- > hw/s390x/s390-skeys.c | 2 +- > hw/s390x/s390-stattrib.c | 2 +- > hw/s390x/vhost-scsi-ccw.c | 2 +- > hw/s390x/vhost-user-fs-ccw.c | 2 +- > hw/s390x/vhost-vsock-ccw.c | 2 +- > hw/s390x/virtio-ccw-9p.c | 2 +- > hw/s390x/virtio-ccw-balloon.c | 2 +- > hw/s390x/virtio-ccw-blk.c | 2 +- > hw/s390x/virtio-ccw-crypto.c | 2 +- > hw/s390x/virtio-ccw-gpu.c | 2 +- > hw/s390x/virtio-ccw-input.c | 2 +- > hw/s390x/virtio-ccw-net.c | 2 +- > hw/s390x/virtio-ccw-rng.c | 2 +- > hw/s390x/virtio-ccw-scsi.c | 2 +- > hw/s390x/virtio-ccw-serial.c | 2 +- > hw/scsi/megasas.c | 6 +++--- > hw/scsi/mptsas.c | 2 +- > hw/scsi/scsi-bus.c | 2 +- > hw/scsi/scsi-disk.c | 6 +++--- > hw/scsi/scsi-generic.c | 2 +- > hw/scsi/spapr_vscsi.c | 2 +- > hw/scsi/vhost-scsi.c | 2 +- > hw/scsi/vhost-user-scsi.c | 2 +- > hw/scsi/virtio-scsi.c | 2 +- > hw/scsi/vmw_pvscsi.c | 2 +- > hw/sd/allwinner-sdhost.c | 2 +- > hw/sd/aspeed_sdhci.c | 2 +- > hw/sd/sd.c | 6 +++--- > hw/sd/sdhci-pci.c | 2 +- > hw/sd/sdhci.c | 2 +- > hw/sparc/sun4m.c | 2 +- > hw/sparc/sun4m_iommu.c | 2 +- > hw/sparc64/sun4u.c | 6 +++--- > hw/ssi/aspeed_smc.c | 4 ++-- > hw/ssi/ibex_spi_host.c | 2 +- > hw/ssi/npcm7xx_fiu.c | 2 +- > hw/ssi/pnv_spi.c | 2 +- > hw/ssi/sifive_spi.c | 2 +- > hw/ssi/ssi.c | 2 +- > hw/ssi/xilinx_spi.c | 2 +- > hw/ssi/xilinx_spips.c | 4 ++-- > hw/ssi/xlnx-versal-ospi.c | 2 +- > hw/timer/a9gtimer.c | 2 +- > hw/timer/allwinner-a10-pit.c | 2 +- > hw/timer/arm_mptimer.c | 2 +- > hw/timer/arm_timer.c | 2 +- > hw/timer/aspeed_timer.c | 2 +- > hw/timer/avr_timer16.c | 2 +- > hw/timer/grlib_gptimer.c | 2 +- > hw/timer/hpet.c | 2 +- > hw/timer/i8254_common.c | 2 +- > hw/timer/ibex_timer.c | 2 +- > hw/timer/mss-timer.c | 2 +- > hw/timer/nrf51_timer.c | 2 +- > hw/timer/pxa2xx_timer.c | 2 +- > hw/timer/renesas_cmt.c | 2 +- > hw/timer/renesas_tmr.c | 2 +- > hw/timer/sifive_pwm.c | 2 +- > hw/timer/slavio_timer.c | 2 +- > hw/timer/sse-timer.c | 2 +- > hw/timer/stm32f2xx_timer.c | 2 +- > hw/timer/xilinx_timer.c | 2 +- > hw/tpm/tpm_crb.c | 2 +- > hw/tpm/tpm_spapr.c | 2 +- > hw/tpm/tpm_tis_i2c.c | 2 +- > hw/tpm/tpm_tis_isa.c | 2 +- > hw/tpm/tpm_tis_sysbus.c | 2 +- > hw/tricore/tc27x_soc.c | 2 +- > hw/tricore/tricore_testdevice.c | 2 +- > hw/ufs/lu.c | 2 +- > hw/ufs/ufs.c | 2 +- > hw/usb/bus.c | 2 +- > hw/usb/canokey.c | 2 +- > hw/usb/ccid-card-emulated.c | 2 +- > hw/usb/ccid-card-passthru.c | 2 +- > hw/usb/dev-audio.c | 2 +- > hw/usb/dev-hid.c | 6 +++--- > hw/usb/dev-hub.c | 2 +- > hw/usb/dev-mtp.c | 2 +- > hw/usb/dev-network.c | 2 +- > hw/usb/dev-serial.c | 4 ++-- > hw/usb/dev-smartcard-reader.c | 4 ++-- > hw/usb/dev-storage-classic.c | 2 +- > hw/usb/dev-uas.c | 2 +- > hw/usb/hcd-dwc2.c | 2 +- > hw/usb/hcd-dwc3.c | 2 +- > hw/usb/hcd-ehci-pci.c | 2 +- > hw/usb/hcd-ehci-sysbus.c | 2 +- > hw/usb/hcd-ohci-pci.c | 2 +- > hw/usb/hcd-ohci-sysbus.c | 2 +- > hw/usb/hcd-uhci.c | 4 ++-- > hw/usb/hcd-xhci-nec.c | 2 +- > hw/usb/hcd-xhci-sysbus.c | 2 +- > hw/usb/hcd-xhci.c | 2 +- > hw/usb/host-libusb.c | 2 +- > hw/usb/redirect.c | 2 +- > hw/usb/u2f-emulated.c | 2 +- > hw/usb/u2f-passthru.c | 2 +- > hw/vfio/ap.c | 2 +- > hw/vfio/ccw.c | 2 +- > hw/vfio/pci.c | 4 ++-- > hw/vfio/platform.c | 2 +- > hw/virtio/vdpa-dev-pci.c | 2 +- > hw/virtio/vdpa-dev.c | 2 +- > hw/virtio/vhost-scsi-pci.c | 2 +- > hw/virtio/vhost-user-blk-pci.c | 2 +- > hw/virtio/vhost-user-device.c | 2 +- > hw/virtio/vhost-user-fs-pci.c | 2 +- > hw/virtio/vhost-user-fs.c | 2 +- > hw/virtio/vhost-user-gpio.c | 2 +- > hw/virtio/vhost-user-i2c.c | 2 +- > hw/virtio/vhost-user-input.c | 2 +- > hw/virtio/vhost-user-rng-pci.c | 2 +- > hw/virtio/vhost-user-rng.c | 2 +- > hw/virtio/vhost-user-scmi.c | 2 +- > hw/virtio/vhost-user-scsi-pci.c | 2 +- > hw/virtio/vhost-user-snd-pci.c | 2 +- > hw/virtio/vhost-user-snd.c | 2 +- > hw/virtio/vhost-user-vsock-pci.c | 2 +- > hw/virtio/vhost-user-vsock.c | 2 +- > hw/virtio/vhost-vsock-common.c | 2 +- > hw/virtio/vhost-vsock-pci.c | 2 +- > hw/virtio/vhost-vsock.c | 2 +- > hw/virtio/virtio-9p-pci.c | 2 +- > hw/virtio/virtio-balloon.c | 2 +- > hw/virtio/virtio-blk-pci.c | 2 +- > hw/virtio/virtio-crypto-pci.c | 2 +- > hw/virtio/virtio-crypto.c | 2 +- > hw/virtio/virtio-input-pci.c | 2 +- > hw/virtio/virtio-iommu-pci.c | 2 +- > hw/virtio/virtio-iommu.c | 2 +- > hw/virtio/virtio-mem.c | 2 +- > hw/virtio/virtio-mmio.c | 2 +- > hw/virtio/virtio-net-pci.c | 2 +- > hw/virtio/virtio-nsm.c | 2 +- > hw/virtio/virtio-pci.c | 4 ++-- > hw/virtio/virtio-pmem.c | 2 +- > hw/virtio/virtio-rng-pci.c | 2 +- > hw/virtio/virtio-rng.c | 2 +- > hw/virtio/virtio-scsi-pci.c | 2 +- > hw/virtio/virtio-serial-pci.c | 2 +- > hw/virtio/virtio.c | 2 +- > hw/watchdog/sbsa_gwdt.c | 2 +- > hw/watchdog/wdt_aspeed.c | 2 +- > hw/watchdog/wdt_imx2.c | 2 +- > hw/xen/xen-bus.c | 2 +- > hw/xen/xen-legacy-backend.c | 6 +++--- > hw/xen/xen_pt.c | 2 +- > target/arm/cpu.c | 26 +++++++++++++------------- > target/arm/cpu64.c | 6 +++--- > target/arm/tcg/cpu64.c | 2 +- > target/avr/cpu.c | 2 +- > target/hexagon/cpu.c | 2 +- > target/i386/cpu.c | 4 ++-- > target/microblaze/cpu.c | 2 +- > target/mips/cpu.c | 2 +- > target/ppc/cpu_init.c | 6 ------ > target/riscv/cpu.c | 2 +- > target/s390x/cpu.c | 2 +- > target/sparc/cpu.c | 4 ++-- > tests/unit/test-qdev-global-props.c | 2 +- > docs/devel/migration/compatibility.rst | 4 ++-- > docs/devel/virtio-backends.rst | 2 +- > 568 files changed, 644 insertions(+), 655 deletions(-) > Maybe extend checkpatch to catch these in the future? (Not meant to be a blocker) Best regards, Bernhard
On 12/13/24 20:06, Richard Henderson wrote: > Since d36f165d952 (qdev: make properties array "const"), we can > define our Property structure const. Do this across the entire tree. > > There are a few other minor changes: > - Two instances where it was obvious that an empty property list > could be removed entirely. There are other empty lists that > probably should be removed, but I didn't look further into usage. > - In hw/misc/xlnx-versal-trng.c, adjust a Property to use the > correct PropertyInfo in the definition, rather than setting > it at runtime. > - One instance where { } was used instead of DEFINE_PROP_END_OF_LIST. > Not a bug, but wrong style. Thanks very much! It's not a lot of memory but it's nice to share these across multiple instances of QEMU. Paolo > r~ > > > Richard Henderson (71): > target/arm: Constify all Property > target/avr: Constify all Property > target/hexagon: Constify all Property > target/i386: Constify all Property > target/microblaze: Constify all Property > target/mips: Constify all Property > target/ppc: Remove empty property list > target/riscv: Constify all Property > target/s390x: Constify all Property > target/sparc: Constify all Property and PropertyInfo > cpu-target: Constify all Property > hw/9pfs: Constify all Property > hw/acpi: Constify all Property > hw/adc: Constify all Property > hw/arm: Constify all Property > hw/audio: Constify all Property > hw/avr: Constify all Property > hw/block/xen-block: Unexport PropertyInfo > hw/block: Constify all Property > hw/char: Constify all Property > hw/core: Constify all Property > hw/cpu: Constify all Property > hw/cxl: Constify all Property > hw/display: Constify all Property > hw/dma: Constify all Property > hw/gpio: Constify all Property > hw/hyperv: Constify all Property > hw/i2c: Constify all Property > hw/i386: Constify all Property > hw/ide: Constify all Property > hw/input: Constify all Property > hw/intc: Constify all Property > hw/ipack: Constify all Property > hw/ipmi: Constify all Property > hw/isa: Constify all Property > hw/m68k: Constify all Property > hw/mem: Constify all Property > hw/mips: Constify all Property > hw/misc/xlnx-versal-trng: Constify trng_props > hw/misc: Constify all Property > hw/net: Constify all Property > hw/nubus: Constify all Property > hw/nvme: Constify all Property > hw/nvram: Constify all Property > hw/pci-bridge: Constify all Property > hw/pci-host/astro: Remove empty Property list > hw/pci-host: Constify all Property > hw/pci: Constify all Property > hw/ppc: Constify all Property > hw/remote: Constify all Property > hw/riscv: Constify all Property > hw/rtc: Constify all Property > hw/rx: Constify all Property > hw/s390x: Constify all Property > hw/scsi: Constify all Property > hw/sd: Constify all Property > hw/sparc: Constify all Property > hw/sparc64: Constify all Property > hw/ssi: Constify all Property > hw/timer: Constify all Property > hw/tpm: Constify all Property > hw/tricore: Constify all Property > hw/ufs: Constify all Property > hw/usb: Constify all Property > hw/vfio: Constify all Property > hw/virtio: Constify all Property > hw/watchdog: Constify all Property > hw/xen: Constify all Property > hw/xen: Use DEFINE_PROP_END_OF_LIST in xen_sysdev_properties > tests/unit: Constify all Property > docs: Constify all Property in examples > > cpu-target.c | 2 +- > hw/9pfs/virtio-9p-device.c | 2 +- > hw/acpi/erst.c | 2 +- > hw/acpi/generic_event_device.c | 2 +- > hw/acpi/piix4.c | 2 +- > hw/acpi/vmgenid.c | 2 +- > hw/adc/aspeed_adc.c | 2 +- > hw/adc/npcm7xx_adc.c | 2 +- > hw/arm/armsse.c | 8 ++++---- > hw/arm/armv7m.c | 4 ++-- > hw/arm/aspeed_soc_common.c | 2 +- > hw/arm/bcm2836.c | 2 +- > hw/arm/fsl-imx25.c | 2 +- > hw/arm/fsl-imx6.c | 2 +- > hw/arm/fsl-imx6ul.c | 2 +- > hw/arm/fsl-imx7.c | 2 +- > hw/arm/integratorcp.c | 2 +- > hw/arm/msf2-soc.c | 2 +- > hw/arm/npcm7xx.c | 2 +- > hw/arm/nrf51_soc.c | 2 +- > hw/arm/smmu-common.c | 2 +- > hw/arm/smmuv3.c | 2 +- > hw/arm/stellaris.c | 2 +- > hw/arm/strongarm.c | 2 +- > hw/arm/xlnx-versal.c | 2 +- > hw/arm/xlnx-zynqmp.c | 2 +- > hw/audio/ac97.c | 2 +- > hw/audio/adlib.c | 2 +- > hw/audio/asc.c | 2 +- > hw/audio/cs4231a.c | 2 +- > hw/audio/es1370.c | 2 +- > hw/audio/gus.c | 2 +- > hw/audio/hda-codec.c | 2 +- > hw/audio/intel-hda.c | 4 ++-- > hw/audio/pcspk.c | 2 +- > hw/audio/pl041.c | 2 +- > hw/audio/sb16.c | 2 +- > hw/audio/via-ac97.c | 2 +- > hw/audio/virtio-snd-pci.c | 2 +- > hw/audio/virtio-snd.c | 2 +- > hw/audio/wm8750.c | 2 +- > hw/avr/atmega.c | 2 +- > hw/block/fdc-isa.c | 2 +- > hw/block/fdc-sysbus.c | 4 ++-- > hw/block/fdc.c | 2 +- > hw/block/m25p80.c | 2 +- > hw/block/nand.c | 2 +- > hw/block/pflash_cfi01.c | 2 +- > hw/block/pflash_cfi02.c | 2 +- > hw/block/swim.c | 2 +- > hw/block/vhost-user-blk.c | 2 +- > hw/block/virtio-blk.c | 2 +- > hw/block/xen-block.c | 4 ++-- > hw/char/avr_usart.c | 2 +- > hw/char/bcm2835_aux.c | 2 +- > hw/char/cadence_uart.c | 2 +- > hw/char/cmsdk-apb-uart.c | 2 +- > hw/char/debugcon.c | 2 +- > hw/char/digic-uart.c | 2 +- > hw/char/escc.c | 2 +- > hw/char/exynos4210_uart.c | 2 +- > hw/char/goldfish_tty.c | 2 +- > hw/char/grlib_apbuart.c | 2 +- > hw/char/ibex_uart.c | 2 +- > hw/char/imx_serial.c | 2 +- > hw/char/ipoctal232.c | 2 +- > hw/char/mcf_uart.c | 2 +- > hw/char/nrf51_uart.c | 2 +- > hw/char/parallel.c | 2 +- > hw/char/pl011.c | 2 +- > hw/char/renesas_sci.c | 2 +- > hw/char/sclpconsole-lm.c | 2 +- > hw/char/sclpconsole.c | 2 +- > hw/char/serial-isa.c | 2 +- > hw/char/serial-mm.c | 2 +- > hw/char/serial-pci-multi.c | 4 ++-- > hw/char/serial-pci.c | 2 +- > hw/char/serial.c | 2 +- > hw/char/sh_serial.c | 2 +- > hw/char/shakti_uart.c | 2 +- > hw/char/sifive_uart.c | 2 +- > hw/char/spapr_vty.c | 2 +- > hw/char/stm32f2xx_usart.c | 2 +- > hw/char/stm32l4x5_usart.c | 2 +- > hw/char/terminal3270.c | 2 +- > hw/char/virtio-console.c | 2 +- > hw/char/virtio-serial-bus.c | 4 ++-- > hw/char/xen_console.c | 2 +- > hw/char/xilinx_uartlite.c | 2 +- > hw/core/generic-loader.c | 2 +- > hw/core/guest-loader.c | 2 +- > hw/core/or-irq.c | 2 +- > hw/core/platform-bus.c | 2 +- > hw/core/split-irq.c | 2 +- > hw/cpu/a15mpcore.c | 2 +- > hw/cpu/a9mpcore.c | 2 +- > hw/cpu/arm11mpcore.c | 2 +- > hw/cpu/cluster.c | 2 +- > hw/cpu/realview_mpcore.c | 2 +- > hw/cxl/switch-mailbox-cci.c | 2 +- > hw/display/artist.c | 2 +- > hw/display/ati.c | 2 +- > hw/display/bcm2835_fb.c | 2 +- > hw/display/bochs-display.c | 2 +- > hw/display/cg3.c | 2 +- > hw/display/cirrus_vga.c | 2 +- > hw/display/cirrus_vga_isa.c | 2 +- > hw/display/exynos4210_fimd.c | 2 +- > hw/display/g364fb.c | 2 +- > hw/display/i2c-ddc.c | 2 +- > hw/display/macfb.c | 4 ++-- > hw/display/pl110.c | 2 +- > hw/display/qxl.c | 2 +- > hw/display/ramfb-standalone.c | 2 +- > hw/display/sm501.c | 4 ++-- > hw/display/tcx.c | 2 +- > hw/display/vga-isa.c | 2 +- > hw/display/vga-mmio.c | 2 +- > hw/display/vga-pci.c | 4 ++-- > hw/display/vhost-user-gpu.c | 2 +- > hw/display/virtio-gpu-gl.c | 2 +- > hw/display/virtio-gpu-pci.c | 2 +- > hw/display/virtio-gpu-rutabaga.c | 2 +- > hw/display/virtio-gpu.c | 2 +- > hw/display/virtio-vga.c | 2 +- > hw/display/vmware_vga.c | 2 +- > hw/display/xlnx_dp.c | 2 +- > hw/dma/i82374.c | 2 +- > hw/dma/i8257.c | 2 +- > hw/dma/pl080.c | 2 +- > hw/dma/pl330.c | 2 +- > hw/dma/xilinx_axidma.c | 2 +- > hw/dma/xlnx-zdma.c | 2 +- > hw/dma/xlnx_csu_dma.c | 2 +- > hw/gpio/imx_gpio.c | 2 +- > hw/gpio/npcm7xx_gpio.c | 2 +- > hw/gpio/omap_gpio.c | 2 +- > hw/gpio/pca9552.c | 2 +- > hw/gpio/pca9554.c | 2 +- > hw/gpio/pl061.c | 2 +- > hw/gpio/sifive_gpio.c | 2 +- > hw/gpio/stm32l4x5_gpio.c | 2 +- > hw/hyperv/hv-balloon.c | 2 +- > hw/hyperv/syndbg.c | 2 +- > hw/hyperv/vmbus.c | 4 ++-- > hw/i2c/aspeed_i2c.c | 4 ++-- > hw/i2c/core.c | 2 +- > hw/i2c/i2c_mux_pca954x.c | 2 +- > hw/i2c/omap_i2c.c | 2 +- > hw/i386/amd_iommu.c | 2 +- > hw/i386/intel_iommu.c | 2 +- > hw/i386/kvm/clock.c | 2 +- > hw/i386/kvm/i8254.c | 2 +- > hw/i386/kvm/ioapic.c | 2 +- > hw/i386/sgx-epc.c | 2 +- > hw/i386/vmmouse.c | 2 +- > hw/i386/vmport.c | 2 +- > hw/i386/x86-iommu.c | 2 +- > hw/i386/xen/xen_pvdevice.c | 2 +- > hw/ide/ahci.c | 2 +- > hw/ide/cf.c | 2 +- > hw/ide/cmd646.c | 2 +- > hw/ide/ide-dev.c | 6 +++--- > hw/ide/isa.c | 2 +- > hw/ide/macio.c | 2 +- > hw/ide/mmio.c | 2 +- > hw/input/pckbd.c | 4 ++-- > hw/input/stellaris_gamepad.c | 2 +- > hw/input/virtio-input-hid.c | 6 +++--- > hw/input/virtio-input-host.c | 2 +- > hw/input/virtio-input.c | 2 +- > hw/intc/apic_common.c | 2 +- > hw/intc/arm_gic_common.c | 2 +- > hw/intc/arm_gicv2m.c | 2 +- > hw/intc/arm_gicv3_common.c | 2 +- > hw/intc/arm_gicv3_its.c | 2 +- > hw/intc/arm_gicv3_its_kvm.c | 2 +- > hw/intc/armv7m_nvic.c | 2 +- > hw/intc/exynos4210_combiner.c | 2 +- > hw/intc/exynos4210_gic.c | 2 +- > hw/intc/goldfish_pic.c | 2 +- > hw/intc/grlib_irqmp.c | 2 +- > hw/intc/i8259_common.c | 2 +- > hw/intc/ioapic.c | 2 +- > hw/intc/loongarch_extioi.c | 2 +- > hw/intc/loongarch_pch_msi.c | 2 +- > hw/intc/loongarch_pch_pic.c | 2 +- > hw/intc/loongson_ipi_common.c | 2 +- > hw/intc/m68k_irqc.c | 2 +- > hw/intc/mips_gic.c | 2 +- > hw/intc/omap_intc.c | 2 +- > hw/intc/ompic.c | 2 +- > hw/intc/openpic.c | 2 +- > hw/intc/openpic_kvm.c | 2 +- > hw/intc/pnv_xive.c | 2 +- > hw/intc/pnv_xive2.c | 2 +- > hw/intc/ppc-uic.c | 2 +- > hw/intc/riscv_aclint.c | 4 ++-- > hw/intc/riscv_aplic.c | 2 +- > hw/intc/riscv_imsic.c | 2 +- > hw/intc/rx_icu.c | 2 +- > hw/intc/s390_flic.c | 4 ++-- > hw/intc/sifive_plic.c | 2 +- > hw/intc/spapr_xive.c | 2 +- > hw/intc/xics.c | 4 ++-- > hw/intc/xilinx_intc.c | 2 +- > hw/intc/xive.c | 8 ++++---- > hw/intc/xive2.c | 4 ++-- > hw/intc/xlnx-pmu-iomod-intc.c | 2 +- > hw/ipack/ipack.c | 2 +- > hw/ipmi/ipmi.c | 2 +- > hw/ipmi/ipmi_bmc_extern.c | 2 +- > hw/ipmi/ipmi_bmc_sim.c | 2 +- > hw/ipmi/isa_ipmi_bt.c | 2 +- > hw/ipmi/isa_ipmi_kcs.c | 2 +- > hw/isa/lpc_ich9.c | 2 +- > hw/isa/pc87312.c | 2 +- > hw/isa/piix.c | 2 +- > hw/m68k/mcf5206.c | 2 +- > hw/m68k/mcf_intc.c | 2 +- > hw/m68k/next-cube.c | 2 +- > hw/m68k/q800-glue.c | 2 +- > hw/mem/cxl_type3.c | 2 +- > hw/mem/nvdimm.c | 2 +- > hw/mem/pc-dimm.c | 2 +- > hw/mem/sparse-mem.c | 2 +- > hw/mips/cps.c | 2 +- > hw/misc/a9scu.c | 2 +- > hw/misc/allwinner-h3-dramc.c | 2 +- > hw/misc/allwinner-r40-dramc.c | 2 +- > hw/misc/allwinner-sid.c | 2 +- > hw/misc/applesmc.c | 2 +- > hw/misc/arm11scu.c | 2 +- > hw/misc/arm_l2x0.c | 2 +- > hw/misc/arm_sysctl.c | 2 +- > hw/misc/armsse-cpuid.c | 2 +- > hw/misc/aspeed_hace.c | 2 +- > hw/misc/aspeed_i3c.c | 2 +- > hw/misc/aspeed_lpc.c | 2 +- > hw/misc/aspeed_sbc.c | 2 +- > hw/misc/aspeed_scu.c | 2 +- > hw/misc/aspeed_sdmc.c | 2 +- > hw/misc/bcm2835_cprman.c | 2 +- > hw/misc/bcm2835_property.c | 2 +- > hw/misc/debugexit.c | 2 +- > hw/misc/eccmemctl.c | 2 +- > hw/misc/empty_slot.c | 2 +- > hw/misc/iotkit-secctl.c | 2 +- > hw/misc/iotkit-sysctl.c | 2 +- > hw/misc/iotkit-sysinfo.c | 2 +- > hw/misc/ivshmem.c | 4 ++-- > hw/misc/led.c | 2 +- > hw/misc/mac_via.c | 2 +- > hw/misc/macio/cuda.c | 2 +- > hw/misc/macio/macio.c | 4 ++-- > hw/misc/macio/pmu.c | 2 +- > hw/misc/mips_cmgcr.c | 2 +- > hw/misc/mips_cpc.c | 2 +- > hw/misc/mips_itu.c | 2 +- > hw/misc/mos6522.c | 2 +- > hw/misc/mps2-fpgaio.c | 2 +- > hw/misc/mps2-scc.c | 2 +- > hw/misc/msf2-sysreg.c | 2 +- > hw/misc/npcm7xx_gcr.c | 2 +- > hw/misc/nrf51_rng.c | 2 +- > hw/misc/pci-testdev.c | 2 +- > hw/misc/pvpanic-isa.c | 2 +- > hw/misc/pvpanic-pci.c | 2 +- > hw/misc/sifive_e_aon.c | 2 +- > hw/misc/sifive_u_otp.c | 2 +- > hw/misc/stm32l4x5_rcc.c | 2 +- > hw/misc/tz-mpc.c | 2 +- > hw/misc/tz-msc.c | 2 +- > hw/misc/tz-ppc.c | 2 +- > hw/misc/unimp.c | 2 +- > hw/misc/xlnx-versal-cframe-reg.c | 4 ++-- > hw/misc/xlnx-versal-cfu.c | 4 ++-- > hw/misc/xlnx-versal-trng.c | 6 +++--- > hw/misc/xlnx-versal-xramc.c | 2 +- > hw/misc/zynq_slcr.c | 2 +- > hw/net/allwinner-sun8i-emac.c | 2 +- > hw/net/allwinner_emac.c | 2 +- > hw/net/cadence_gem.c | 2 +- > hw/net/can/xlnx-versal-canfd.c | 2 +- > hw/net/can/xlnx-zynqmp-can.c | 2 +- > hw/net/dp8393x.c | 2 +- > hw/net/e1000.c | 2 +- > hw/net/e1000e.c | 2 +- > hw/net/eepro100.c | 2 +- > hw/net/fsl_etsec/etsec.c | 2 +- > hw/net/ftgmac100.c | 4 ++-- > hw/net/igb.c | 2 +- > hw/net/imx_fec.c | 2 +- > hw/net/lan9118.c | 2 +- > hw/net/lance.c | 2 +- > hw/net/lasi_i82596.c | 2 +- > hw/net/mcf_fec.c | 2 +- > hw/net/mipsnet.c | 2 +- > hw/net/msf2-emac.c | 2 +- > hw/net/mv88w8618_eth.c | 2 +- > hw/net/ne2000-isa.c | 2 +- > hw/net/ne2000-pci.c | 2 +- > hw/net/npcm7xx_emc.c | 2 +- > hw/net/npcm_gmac.c | 2 +- > hw/net/opencores_eth.c | 2 +- > hw/net/pcnet-pci.c | 2 +- > hw/net/rocker/rocker.c | 2 +- > hw/net/rtl8139.c | 2 +- > hw/net/smc91c111.c | 2 +- > hw/net/spapr_llan.c | 2 +- > hw/net/stellaris_enet.c | 2 +- > hw/net/sungem.c | 2 +- > hw/net/sunhme.c | 2 +- > hw/net/tulip.c | 2 +- > hw/net/virtio-net.c | 2 +- > hw/net/vmxnet3.c | 2 +- > hw/net/xen_nic.c | 2 +- > hw/net/xgmac.c | 2 +- > hw/net/xilinx_axienet.c | 2 +- > hw/net/xilinx_ethlite.c | 2 +- > hw/nubus/nubus-bridge.c | 2 +- > hw/nubus/nubus-device.c | 2 +- > hw/nvme/ctrl.c | 2 +- > hw/nvme/ns.c | 2 +- > hw/nvme/subsys.c | 2 +- > hw/nvram/ds1225y.c | 2 +- > hw/nvram/eeprom_at24c.c | 2 +- > hw/nvram/fw_cfg.c | 6 +++--- > hw/nvram/mac_nvram.c | 2 +- > hw/nvram/nrf51_nvm.c | 2 +- > hw/nvram/spapr_nvram.c | 2 +- > hw/nvram/xlnx-bbram.c | 2 +- > hw/nvram/xlnx-efuse.c | 2 +- > hw/nvram/xlnx-versal-efuse-cache.c | 2 +- > hw/nvram/xlnx-versal-efuse-ctrl.c | 2 +- > hw/nvram/xlnx-zynqmp-efuse.c | 2 +- > hw/pci-bridge/cxl_downstream.c | 2 +- > hw/pci-bridge/cxl_root_port.c | 2 +- > hw/pci-bridge/cxl_upstream.c | 2 +- > hw/pci-bridge/gen_pcie_root_port.c | 2 +- > hw/pci-bridge/pci_bridge_dev.c | 2 +- > hw/pci-bridge/pci_expander_bridge.c | 4 ++-- > hw/pci-bridge/pcie_pci_bridge.c | 2 +- > hw/pci-bridge/pcie_root_port.c | 2 +- > hw/pci-bridge/xio3130_downstream.c | 2 +- > hw/pci-host/astro.c | 5 ----- > hw/pci-host/dino.c | 2 +- > hw/pci-host/gpex.c | 2 +- > hw/pci-host/grackle.c | 2 +- > hw/pci-host/gt64120.c | 2 +- > hw/pci-host/i440fx.c | 2 +- > hw/pci-host/mv64361.c | 2 +- > hw/pci-host/pnv_phb.c | 4 ++-- > hw/pci-host/pnv_phb3.c | 2 +- > hw/pci-host/pnv_phb4.c | 2 +- > hw/pci-host/pnv_phb4_pec.c | 2 +- > hw/pci-host/ppce500.c | 2 +- > hw/pci-host/q35.c | 4 ++-- > hw/pci-host/raven.c | 2 +- > hw/pci-host/sabre.c | 2 +- > hw/pci-host/uninorth.c | 2 +- > hw/pci-host/versatile.c | 2 +- > hw/pci-host/xilinx-pcie.c | 2 +- > hw/pci/pci.c | 2 +- > hw/pci/pci_bridge.c | 2 +- > hw/pci/pci_host.c | 2 +- > hw/pci/pcie_port.c | 4 ++-- > hw/ppc/pnv.c | 2 +- > hw/ppc/pnv_adu.c | 2 +- > hw/ppc/pnv_chiptod.c | 2 +- > hw/ppc/pnv_core.c | 4 ++-- > hw/ppc/pnv_homer.c | 2 +- > hw/ppc/pnv_i2c.c | 2 +- > hw/ppc/pnv_lpc.c | 2 +- > hw/ppc/pnv_pnor.c | 2 +- > hw/ppc/pnv_psi.c | 2 +- > hw/ppc/ppc405_uc.c | 2 +- > hw/ppc/ppc440_uc.c | 2 +- > hw/ppc/ppc4xx_devs.c | 4 ++-- > hw/ppc/ppc4xx_sdram.c | 4 ++-- > hw/ppc/prep_systemio.c | 2 +- > hw/ppc/rs6000_mc.c | 2 +- > hw/ppc/spapr_cpu_core.c | 2 +- > hw/ppc/spapr_nvdimm.c | 2 +- > hw/ppc/spapr_pci.c | 2 +- > hw/ppc/spapr_rng.c | 2 +- > hw/ppc/spapr_tpm_proxy.c | 2 +- > hw/remote/proxy.c | 2 +- > hw/riscv/opentitan.c | 2 +- > hw/riscv/riscv-iommu-pci.c | 2 +- > hw/riscv/riscv-iommu.c | 2 +- > hw/riscv/riscv_hart.c | 2 +- > hw/riscv/sifive_u.c | 2 +- > hw/rtc/allwinner-rtc.c | 2 +- > hw/rtc/goldfish_rtc.c | 2 +- > hw/rtc/m48t59-isa.c | 2 +- > hw/rtc/m48t59.c | 2 +- > hw/rtc/mc146818rtc.c | 2 +- > hw/rtc/pl031.c | 2 +- > hw/rx/rx62n.c | 2 +- > hw/s390x/3270-ccw.c | 2 +- > hw/s390x/ccw-device.c | 2 +- > hw/s390x/css-bridge.c | 2 +- > hw/s390x/ipl.c | 2 +- > hw/s390x/s390-pci-bus.c | 2 +- > hw/s390x/s390-skeys.c | 2 +- > hw/s390x/s390-stattrib.c | 2 +- > hw/s390x/vhost-scsi-ccw.c | 2 +- > hw/s390x/vhost-user-fs-ccw.c | 2 +- > hw/s390x/vhost-vsock-ccw.c | 2 +- > hw/s390x/virtio-ccw-9p.c | 2 +- > hw/s390x/virtio-ccw-balloon.c | 2 +- > hw/s390x/virtio-ccw-blk.c | 2 +- > hw/s390x/virtio-ccw-crypto.c | 2 +- > hw/s390x/virtio-ccw-gpu.c | 2 +- > hw/s390x/virtio-ccw-input.c | 2 +- > hw/s390x/virtio-ccw-net.c | 2 +- > hw/s390x/virtio-ccw-rng.c | 2 +- > hw/s390x/virtio-ccw-scsi.c | 2 +- > hw/s390x/virtio-ccw-serial.c | 2 +- > hw/scsi/megasas.c | 6 +++--- > hw/scsi/mptsas.c | 2 +- > hw/scsi/scsi-bus.c | 2 +- > hw/scsi/scsi-disk.c | 6 +++--- > hw/scsi/scsi-generic.c | 2 +- > hw/scsi/spapr_vscsi.c | 2 +- > hw/scsi/vhost-scsi.c | 2 +- > hw/scsi/vhost-user-scsi.c | 2 +- > hw/scsi/virtio-scsi.c | 2 +- > hw/scsi/vmw_pvscsi.c | 2 +- > hw/sd/allwinner-sdhost.c | 2 +- > hw/sd/aspeed_sdhci.c | 2 +- > hw/sd/sd.c | 6 +++--- > hw/sd/sdhci-pci.c | 2 +- > hw/sd/sdhci.c | 2 +- > hw/sparc/sun4m.c | 2 +- > hw/sparc/sun4m_iommu.c | 2 +- > hw/sparc64/sun4u.c | 6 +++--- > hw/ssi/aspeed_smc.c | 4 ++-- > hw/ssi/ibex_spi_host.c | 2 +- > hw/ssi/npcm7xx_fiu.c | 2 +- > hw/ssi/pnv_spi.c | 2 +- > hw/ssi/sifive_spi.c | 2 +- > hw/ssi/ssi.c | 2 +- > hw/ssi/xilinx_spi.c | 2 +- > hw/ssi/xilinx_spips.c | 4 ++-- > hw/ssi/xlnx-versal-ospi.c | 2 +- > hw/timer/a9gtimer.c | 2 +- > hw/timer/allwinner-a10-pit.c | 2 +- > hw/timer/arm_mptimer.c | 2 +- > hw/timer/arm_timer.c | 2 +- > hw/timer/aspeed_timer.c | 2 +- > hw/timer/avr_timer16.c | 2 +- > hw/timer/grlib_gptimer.c | 2 +- > hw/timer/hpet.c | 2 +- > hw/timer/i8254_common.c | 2 +- > hw/timer/ibex_timer.c | 2 +- > hw/timer/mss-timer.c | 2 +- > hw/timer/nrf51_timer.c | 2 +- > hw/timer/pxa2xx_timer.c | 2 +- > hw/timer/renesas_cmt.c | 2 +- > hw/timer/renesas_tmr.c | 2 +- > hw/timer/sifive_pwm.c | 2 +- > hw/timer/slavio_timer.c | 2 +- > hw/timer/sse-timer.c | 2 +- > hw/timer/stm32f2xx_timer.c | 2 +- > hw/timer/xilinx_timer.c | 2 +- > hw/tpm/tpm_crb.c | 2 +- > hw/tpm/tpm_spapr.c | 2 +- > hw/tpm/tpm_tis_i2c.c | 2 +- > hw/tpm/tpm_tis_isa.c | 2 +- > hw/tpm/tpm_tis_sysbus.c | 2 +- > hw/tricore/tc27x_soc.c | 2 +- > hw/tricore/tricore_testdevice.c | 2 +- > hw/ufs/lu.c | 2 +- > hw/ufs/ufs.c | 2 +- > hw/usb/bus.c | 2 +- > hw/usb/canokey.c | 2 +- > hw/usb/ccid-card-emulated.c | 2 +- > hw/usb/ccid-card-passthru.c | 2 +- > hw/usb/dev-audio.c | 2 +- > hw/usb/dev-hid.c | 6 +++--- > hw/usb/dev-hub.c | 2 +- > hw/usb/dev-mtp.c | 2 +- > hw/usb/dev-network.c | 2 +- > hw/usb/dev-serial.c | 4 ++-- > hw/usb/dev-smartcard-reader.c | 4 ++-- > hw/usb/dev-storage-classic.c | 2 +- > hw/usb/dev-uas.c | 2 +- > hw/usb/hcd-dwc2.c | 2 +- > hw/usb/hcd-dwc3.c | 2 +- > hw/usb/hcd-ehci-pci.c | 2 +- > hw/usb/hcd-ehci-sysbus.c | 2 +- > hw/usb/hcd-ohci-pci.c | 2 +- > hw/usb/hcd-ohci-sysbus.c | 2 +- > hw/usb/hcd-uhci.c | 4 ++-- > hw/usb/hcd-xhci-nec.c | 2 +- > hw/usb/hcd-xhci-sysbus.c | 2 +- > hw/usb/hcd-xhci.c | 2 +- > hw/usb/host-libusb.c | 2 +- > hw/usb/redirect.c | 2 +- > hw/usb/u2f-emulated.c | 2 +- > hw/usb/u2f-passthru.c | 2 +- > hw/vfio/ap.c | 2 +- > hw/vfio/ccw.c | 2 +- > hw/vfio/pci.c | 4 ++-- > hw/vfio/platform.c | 2 +- > hw/virtio/vdpa-dev-pci.c | 2 +- > hw/virtio/vdpa-dev.c | 2 +- > hw/virtio/vhost-scsi-pci.c | 2 +- > hw/virtio/vhost-user-blk-pci.c | 2 +- > hw/virtio/vhost-user-device.c | 2 +- > hw/virtio/vhost-user-fs-pci.c | 2 +- > hw/virtio/vhost-user-fs.c | 2 +- > hw/virtio/vhost-user-gpio.c | 2 +- > hw/virtio/vhost-user-i2c.c | 2 +- > hw/virtio/vhost-user-input.c | 2 +- > hw/virtio/vhost-user-rng-pci.c | 2 +- > hw/virtio/vhost-user-rng.c | 2 +- > hw/virtio/vhost-user-scmi.c | 2 +- > hw/virtio/vhost-user-scsi-pci.c | 2 +- > hw/virtio/vhost-user-snd-pci.c | 2 +- > hw/virtio/vhost-user-snd.c | 2 +- > hw/virtio/vhost-user-vsock-pci.c | 2 +- > hw/virtio/vhost-user-vsock.c | 2 +- > hw/virtio/vhost-vsock-common.c | 2 +- > hw/virtio/vhost-vsock-pci.c | 2 +- > hw/virtio/vhost-vsock.c | 2 +- > hw/virtio/virtio-9p-pci.c | 2 +- > hw/virtio/virtio-balloon.c | 2 +- > hw/virtio/virtio-blk-pci.c | 2 +- > hw/virtio/virtio-crypto-pci.c | 2 +- > hw/virtio/virtio-crypto.c | 2 +- > hw/virtio/virtio-input-pci.c | 2 +- > hw/virtio/virtio-iommu-pci.c | 2 +- > hw/virtio/virtio-iommu.c | 2 +- > hw/virtio/virtio-mem.c | 2 +- > hw/virtio/virtio-mmio.c | 2 +- > hw/virtio/virtio-net-pci.c | 2 +- > hw/virtio/virtio-nsm.c | 2 +- > hw/virtio/virtio-pci.c | 4 ++-- > hw/virtio/virtio-pmem.c | 2 +- > hw/virtio/virtio-rng-pci.c | 2 +- > hw/virtio/virtio-rng.c | 2 +- > hw/virtio/virtio-scsi-pci.c | 2 +- > hw/virtio/virtio-serial-pci.c | 2 +- > hw/virtio/virtio.c | 2 +- > hw/watchdog/sbsa_gwdt.c | 2 +- > hw/watchdog/wdt_aspeed.c | 2 +- > hw/watchdog/wdt_imx2.c | 2 +- > hw/xen/xen-bus.c | 2 +- > hw/xen/xen-legacy-backend.c | 6 +++--- > hw/xen/xen_pt.c | 2 +- > target/arm/cpu.c | 26 +++++++++++++------------- > target/arm/cpu64.c | 6 +++--- > target/arm/tcg/cpu64.c | 2 +- > target/avr/cpu.c | 2 +- > target/hexagon/cpu.c | 2 +- > target/i386/cpu.c | 4 ++-- > target/microblaze/cpu.c | 2 +- > target/mips/cpu.c | 2 +- > target/ppc/cpu_init.c | 6 ------ > target/riscv/cpu.c | 2 +- > target/s390x/cpu.c | 2 +- > target/sparc/cpu.c | 4 ++-- > tests/unit/test-qdev-global-props.c | 2 +- > docs/devel/migration/compatibility.rst | 4 ++-- > docs/devel/virtio-backends.rst | 2 +- > 568 files changed, 644 insertions(+), 655 deletions(-) >
On 12/14/24 12:40, Bernhard Beschow wrote:
> Maybe extend checkpatch to catch these in the future? (Not meant to be a blocker)
I believe I have a way to enforce this at build-time, for a follow-up patch set.
r~
Hi Rihard. Good idea, LGTM. Just out of curiosity, what was the motivation for such a patch? It it simply about cleaning the code or is it intended to solve a deeper problem. Thanks, cmd On 13/12/2024 20:07, Richard Henderson wrote: > Caution: External email. Do not open attachments or click links, unless this email comes from a known sender and you know the content is safe. > > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > hw/i386/amd_iommu.c | 2 +- > hw/i386/intel_iommu.c | 2 +- > hw/i386/kvm/clock.c | 2 +- > hw/i386/kvm/i8254.c | 2 +- > hw/i386/kvm/ioapic.c | 2 +- > hw/i386/sgx-epc.c | 2 +- > hw/i386/vmmouse.c | 2 +- > hw/i386/vmport.c | 2 +- > hw/i386/x86-iommu.c | 2 +- > hw/i386/xen/xen_pvdevice.c | 2 +- > 10 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c > index af0f4da1f6..ca3e62a244 100644 > --- a/hw/i386/amd_iommu.c > +++ b/hw/i386/amd_iommu.c > @@ -1668,7 +1668,7 @@ static void amdvi_sysbus_realize(DeviceState *dev, Error **errp) > amdvi_init(s); > } > > -static Property amdvi_properties[] = { > +static const Property amdvi_properties[] = { > DEFINE_PROP_BOOL("xtsup", AMDVIState, xtsup, false), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > index 4c0d1d7d47..a5b268342f 100644 > --- a/hw/i386/intel_iommu.c > +++ b/hw/i386/intel_iommu.c > @@ -3404,7 +3404,7 @@ static const MemoryRegionOps vtd_mem_ops = { > }, > }; > > -static Property vtd_properties[] = { > +static const Property vtd_properties[] = { > DEFINE_PROP_UINT32("version", IntelIOMMUState, version, 0), > DEFINE_PROP_ON_OFF_AUTO("eim", IntelIOMMUState, intr_eim, > ON_OFF_AUTO_AUTO), > diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c > index 40aa9a32c3..71150ed2e0 100644 > --- a/hw/i386/kvm/clock.c > +++ b/hw/i386/kvm/clock.c > @@ -305,7 +305,7 @@ static const VMStateDescription kvmclock_vmsd = { > } > }; > > -static Property kvmclock_properties[] = { > +static const Property kvmclock_properties[] = { > DEFINE_PROP_BOOL("x-mach-use-reliable-get-clock", KVMClockState, > mach_use_reliable_get_clock, true), > DEFINE_PROP_END_OF_LIST(), > diff --git a/hw/i386/kvm/i8254.c b/hw/i386/kvm/i8254.c > index baa4b39582..2933d3f458 100644 > --- a/hw/i386/kvm/i8254.c > +++ b/hw/i386/kvm/i8254.c > @@ -287,7 +287,7 @@ static void kvm_pit_realizefn(DeviceState *dev, Error **errp) > kpc->parent_realize(dev, errp); > } > > -static Property kvm_pit_properties[] = { > +static const Property kvm_pit_properties[] = { > DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", KVMPITState, > lost_tick_policy, LOST_TICK_POLICY_DELAY), > DEFINE_PROP_END_OF_LIST(), > diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c > index 2907b08164..217ff43b98 100644 > --- a/hw/i386/kvm/ioapic.c > +++ b/hw/i386/kvm/ioapic.c > @@ -133,7 +133,7 @@ static void kvm_ioapic_realize(DeviceState *dev, Error **errp) > qdev_init_gpio_in(dev, kvm_ioapic_set_irq, IOAPIC_NUM_PINS); > } > > -static Property kvm_ioapic_properties[] = { > +static const Property kvm_ioapic_properties[] = { > DEFINE_PROP_UINT32("gsi_base", KVMIOAPICState, kvm_gsi_base, 0), > DEFINE_PROP_END_OF_LIST() > }; > diff --git a/hw/i386/sgx-epc.c b/hw/i386/sgx-epc.c > index d664829d35..c232e825e0 100644 > --- a/hw/i386/sgx-epc.c > +++ b/hw/i386/sgx-epc.c > @@ -19,7 +19,7 @@ > #include "target/i386/cpu.h" > #include "exec/address-spaces.h" > > -static Property sgx_epc_properties[] = { > +static const Property sgx_epc_properties[] = { > DEFINE_PROP_UINT64(SGX_EPC_ADDR_PROP, SGXEPCDevice, addr, 0), > DEFINE_PROP_UINT32(SGX_EPC_NUMA_NODE_PROP, SGXEPCDevice, node, 0), > DEFINE_PROP_LINK(SGX_EPC_MEMDEV_PROP, SGXEPCDevice, hostmem, > diff --git a/hw/i386/vmmouse.c b/hw/i386/vmmouse.c > index 76130cd46d..da9c35c1ec 100644 > --- a/hw/i386/vmmouse.c > +++ b/hw/i386/vmmouse.c > @@ -317,7 +317,7 @@ static void vmmouse_realizefn(DeviceState *dev, Error **errp) > vmport_register(VMPORT_CMD_VMMOUSE_DATA, vmmouse_ioport_read, s); > } > > -static Property vmmouse_properties[] = { > +static const Property vmmouse_properties[] = { > DEFINE_PROP_LINK("i8042", VMMouseState, i8042, TYPE_I8042, ISAKBDState *), > DEFINE_PROP_END_OF_LIST(), > }; > diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c > index 7cc75dbc6d..cab6e72089 100644 > --- a/hw/i386/vmport.c > +++ b/hw/i386/vmport.c > @@ -252,7 +252,7 @@ static void vmport_realizefn(DeviceState *dev, Error **errp) > } > } > > -static Property vmport_properties[] = { > +static const Property vmport_properties[] = { > /* Used to enforce compatibility for migration */ > DEFINE_PROP_BIT("x-read-set-eax", VMPortState, compat_flags, > VMPORT_COMPAT_READ_SET_EAX_BIT, true), > diff --git a/hw/i386/x86-iommu.c b/hw/i386/x86-iommu.c > index 60af896225..155f6262ea 100644 > --- a/hw/i386/x86-iommu.c > +++ b/hw/i386/x86-iommu.c > @@ -125,7 +125,7 @@ static void x86_iommu_realize(DeviceState *dev, Error **errp) > } > } > > -static Property x86_iommu_properties[] = { > +static const Property x86_iommu_properties[] = { > DEFINE_PROP_ON_OFF_AUTO("intremap", X86IOMMUState, > intr_supported, ON_OFF_AUTO_AUTO), > DEFINE_PROP_BOOL("device-iotlb", X86IOMMUState, dt_supported, false), > diff --git a/hw/i386/xen/xen_pvdevice.c b/hw/i386/xen/xen_pvdevice.c > index ed621531d8..e71483e6e3 100644 > --- a/hw/i386/xen/xen_pvdevice.c > +++ b/hw/i386/xen/xen_pvdevice.c > @@ -115,7 +115,7 @@ static void xen_pv_realize(PCIDevice *pci_dev, Error **errp) > &d->mmio); > } > > -static Property xen_pv_props[] = { > +static const Property xen_pv_props[] = { > DEFINE_PROP_UINT16("vendor-id", XenPVDevice, vendor_id, PCI_VENDOR_ID_XEN), > DEFINE_PROP_UINT16("device-id", XenPVDevice, device_id, 0xffff), > DEFINE_PROP_UINT8("revision", XenPVDevice, revision, 0x01), > -- > 2.43.0 >
On 12/16/24 00:14, CLEMENT MATHIEU--DRIF wrote: > Hi Rihard. > > Good idea, LGTM. > > Just out of curiosity, what was the motivation for such a patch? > It it simply about cleaning the code or is it intended to solve a deeper > problem. Simply cleaning the code, prompted by a change to core QAPI code for Rust enablement. r~
On 2024/12/14 4:07, Richard Henderson wrote: > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Since d36f165d952 (qdev: make properties array "const"), we can define our Property structure const. Do this across the entire tree. There are a few other minor changes: - Two instances where it was obvious that an empty property list could be removed entirely. There are other empty lists that probably should be removed, but I didn't look further into usage. - In hw/misc/xlnx-versal-trng.c, adjust a Property to use the correct PropertyInfo in the definition, rather than setting it at runtime. - One instance where { } was used instead of DEFINE_PROP_END_OF_LIST. Not a bug, but wrong style. r~ Richard Henderson (71): target/arm: Constify all Property target/avr: Constify all Property target/hexagon: Constify all Property target/i386: Constify all Property target/microblaze: Constify all Property target/mips: Constify all Property target/ppc: Remove empty property list target/riscv: Constify all Property target/s390x: Constify all Property target/sparc: Constify all Property and PropertyInfo cpu-target: Constify all Property hw/9pfs: Constify all Property hw/acpi: Constify all Property hw/adc: Constify all Property hw/arm: Constify all Property hw/audio: Constify all Property hw/avr: Constify all Property hw/block/xen-block: Unexport PropertyInfo hw/block: Constify all Property hw/char: Constify all Property hw/core: Constify all Property hw/cpu: Constify all Property hw/cxl: Constify all Property hw/display: Constify all Property hw/dma: Constify all Property hw/gpio: Constify all Property hw/hyperv: Constify all Property hw/i2c: Constify all Property hw/i386: Constify all Property hw/ide: Constify all Property hw/input: Constify all Property hw/intc: Constify all Property hw/ipack: Constify all Property hw/ipmi: Constify all Property hw/isa: Constify all Property hw/m68k: Constify all Property hw/mem: Constify all Property hw/mips: Constify all Property hw/misc/xlnx-versal-trng: Constify trng_props hw/misc: Constify all Property hw/net: Constify all Property hw/nubus: Constify all Property hw/nvme: Constify all Property hw/nvram: Constify all Property hw/pci-bridge: Constify all Property hw/pci-host/astro: Remove empty Property list hw/pci-host: Constify all Property hw/pci: Constify all Property hw/ppc: Constify all Property hw/remote: Constify all Property hw/riscv: Constify all Property hw/rtc: Constify all Property hw/rx: Constify all Property hw/s390x: Constify all Property hw/scsi: Constify all Property hw/sd: Constify all Property hw/sparc: Constify all Property hw/sparc64: Constify all Property hw/ssi: Constify all Property hw/timer: Constify all Property hw/tpm: Constify all Property hw/tricore: Constify all Property hw/ufs: Constify all Property hw/usb: Constify all Property hw/vfio: Constify all Property hw/virtio: Constify all Property hw/watchdog: Constify all Property hw/xen: Constify all Property hw/xen: Use DEFINE_PROP_END_OF_LIST in xen_sysdev_properties tests/unit: Constify all Property docs: Constify all Property in examples cpu-target.c | 2 +- hw/9pfs/virtio-9p-device.c | 2 +- hw/acpi/erst.c | 2 +- hw/acpi/generic_event_device.c | 2 +- hw/acpi/piix4.c | 2 +- hw/acpi/vmgenid.c | 2 +- hw/adc/aspeed_adc.c | 2 +- hw/adc/npcm7xx_adc.c | 2 +- hw/arm/armsse.c | 8 ++++---- hw/arm/armv7m.c | 4 ++-- hw/arm/aspeed_soc_common.c | 2 +- hw/arm/bcm2836.c | 2 +- hw/arm/fsl-imx25.c | 2 +- hw/arm/fsl-imx6.c | 2 +- hw/arm/fsl-imx6ul.c | 2 +- hw/arm/fsl-imx7.c | 2 +- hw/arm/integratorcp.c | 2 +- hw/arm/msf2-soc.c | 2 +- hw/arm/npcm7xx.c | 2 +- hw/arm/nrf51_soc.c | 2 +- hw/arm/smmu-common.c | 2 +- hw/arm/smmuv3.c | 2 +- hw/arm/stellaris.c | 2 +- hw/arm/strongarm.c | 2 +- hw/arm/xlnx-versal.c | 2 +- hw/arm/xlnx-zynqmp.c | 2 +- hw/audio/ac97.c | 2 +- hw/audio/adlib.c | 2 +- hw/audio/asc.c | 2 +- hw/audio/cs4231a.c | 2 +- hw/audio/es1370.c | 2 +- hw/audio/gus.c | 2 +- hw/audio/hda-codec.c | 2 +- hw/audio/intel-hda.c | 4 ++-- hw/audio/pcspk.c | 2 +- hw/audio/pl041.c | 2 +- hw/audio/sb16.c | 2 +- hw/audio/via-ac97.c | 2 +- hw/audio/virtio-snd-pci.c | 2 +- hw/audio/virtio-snd.c | 2 +- hw/audio/wm8750.c | 2 +- hw/avr/atmega.c | 2 +- hw/block/fdc-isa.c | 2 +- hw/block/fdc-sysbus.c | 4 ++-- hw/block/fdc.c | 2 +- hw/block/m25p80.c | 2 +- hw/block/nand.c | 2 +- hw/block/pflash_cfi01.c | 2 +- hw/block/pflash_cfi02.c | 2 +- hw/block/swim.c | 2 +- hw/block/vhost-user-blk.c | 2 +- hw/block/virtio-blk.c | 2 +- hw/block/xen-block.c | 4 ++-- hw/char/avr_usart.c | 2 +- hw/char/bcm2835_aux.c | 2 +- hw/char/cadence_uart.c | 2 +- hw/char/cmsdk-apb-uart.c | 2 +- hw/char/debugcon.c | 2 +- hw/char/digic-uart.c | 2 +- hw/char/escc.c | 2 +- hw/char/exynos4210_uart.c | 2 +- hw/char/goldfish_tty.c | 2 +- hw/char/grlib_apbuart.c | 2 +- hw/char/ibex_uart.c | 2 +- hw/char/imx_serial.c | 2 +- hw/char/ipoctal232.c | 2 +- hw/char/mcf_uart.c | 2 +- hw/char/nrf51_uart.c | 2 +- hw/char/parallel.c | 2 +- hw/char/pl011.c | 2 +- hw/char/renesas_sci.c | 2 +- hw/char/sclpconsole-lm.c | 2 +- hw/char/sclpconsole.c | 2 +- hw/char/serial-isa.c | 2 +- hw/char/serial-mm.c | 2 +- hw/char/serial-pci-multi.c | 4 ++-- hw/char/serial-pci.c | 2 +- hw/char/serial.c | 2 +- hw/char/sh_serial.c | 2 +- hw/char/shakti_uart.c | 2 +- hw/char/sifive_uart.c | 2 +- hw/char/spapr_vty.c | 2 +- hw/char/stm32f2xx_usart.c | 2 +- hw/char/stm32l4x5_usart.c | 2 +- hw/char/terminal3270.c | 2 +- hw/char/virtio-console.c | 2 +- hw/char/virtio-serial-bus.c | 4 ++-- hw/char/xen_console.c | 2 +- hw/char/xilinx_uartlite.c | 2 +- hw/core/generic-loader.c | 2 +- hw/core/guest-loader.c | 2 +- hw/core/or-irq.c | 2 +- hw/core/platform-bus.c | 2 +- hw/core/split-irq.c | 2 +- hw/cpu/a15mpcore.c | 2 +- hw/cpu/a9mpcore.c | 2 +- hw/cpu/arm11mpcore.c | 2 +- hw/cpu/cluster.c | 2 +- hw/cpu/realview_mpcore.c | 2 +- hw/cxl/switch-mailbox-cci.c | 2 +- hw/display/artist.c | 2 +- hw/display/ati.c | 2 +- hw/display/bcm2835_fb.c | 2 +- hw/display/bochs-display.c | 2 +- hw/display/cg3.c | 2 +- hw/display/cirrus_vga.c | 2 +- hw/display/cirrus_vga_isa.c | 2 +- hw/display/exynos4210_fimd.c | 2 +- hw/display/g364fb.c | 2 +- hw/display/i2c-ddc.c | 2 +- hw/display/macfb.c | 4 ++-- hw/display/pl110.c | 2 +- hw/display/qxl.c | 2 +- hw/display/ramfb-standalone.c | 2 +- hw/display/sm501.c | 4 ++-- hw/display/tcx.c | 2 +- hw/display/vga-isa.c | 2 +- hw/display/vga-mmio.c | 2 +- hw/display/vga-pci.c | 4 ++-- hw/display/vhost-user-gpu.c | 2 +- hw/display/virtio-gpu-gl.c | 2 +- hw/display/virtio-gpu-pci.c | 2 +- hw/display/virtio-gpu-rutabaga.c | 2 +- hw/display/virtio-gpu.c | 2 +- hw/display/virtio-vga.c | 2 +- hw/display/vmware_vga.c | 2 +- hw/display/xlnx_dp.c | 2 +- hw/dma/i82374.c | 2 +- hw/dma/i8257.c | 2 +- hw/dma/pl080.c | 2 +- hw/dma/pl330.c | 2 +- hw/dma/xilinx_axidma.c | 2 +- hw/dma/xlnx-zdma.c | 2 +- hw/dma/xlnx_csu_dma.c | 2 +- hw/gpio/imx_gpio.c | 2 +- hw/gpio/npcm7xx_gpio.c | 2 +- hw/gpio/omap_gpio.c | 2 +- hw/gpio/pca9552.c | 2 +- hw/gpio/pca9554.c | 2 +- hw/gpio/pl061.c | 2 +- hw/gpio/sifive_gpio.c | 2 +- hw/gpio/stm32l4x5_gpio.c | 2 +- hw/hyperv/hv-balloon.c | 2 +- hw/hyperv/syndbg.c | 2 +- hw/hyperv/vmbus.c | 4 ++-- hw/i2c/aspeed_i2c.c | 4 ++-- hw/i2c/core.c | 2 +- hw/i2c/i2c_mux_pca954x.c | 2 +- hw/i2c/omap_i2c.c | 2 +- hw/i386/amd_iommu.c | 2 +- hw/i386/intel_iommu.c | 2 +- hw/i386/kvm/clock.c | 2 +- hw/i386/kvm/i8254.c | 2 +- hw/i386/kvm/ioapic.c | 2 +- hw/i386/sgx-epc.c | 2 +- hw/i386/vmmouse.c | 2 +- hw/i386/vmport.c | 2 +- hw/i386/x86-iommu.c | 2 +- hw/i386/xen/xen_pvdevice.c | 2 +- hw/ide/ahci.c | 2 +- hw/ide/cf.c | 2 +- hw/ide/cmd646.c | 2 +- hw/ide/ide-dev.c | 6 +++--- hw/ide/isa.c | 2 +- hw/ide/macio.c | 2 +- hw/ide/mmio.c | 2 +- hw/input/pckbd.c | 4 ++-- hw/input/stellaris_gamepad.c | 2 +- hw/input/virtio-input-hid.c | 6 +++--- hw/input/virtio-input-host.c | 2 +- hw/input/virtio-input.c | 2 +- hw/intc/apic_common.c | 2 +- hw/intc/arm_gic_common.c | 2 +- hw/intc/arm_gicv2m.c | 2 +- hw/intc/arm_gicv3_common.c | 2 +- hw/intc/arm_gicv3_its.c | 2 +- hw/intc/arm_gicv3_its_kvm.c | 2 +- hw/intc/armv7m_nvic.c | 2 +- hw/intc/exynos4210_combiner.c | 2 +- hw/intc/exynos4210_gic.c | 2 +- hw/intc/goldfish_pic.c | 2 +- hw/intc/grlib_irqmp.c | 2 +- hw/intc/i8259_common.c | 2 +- hw/intc/ioapic.c | 2 +- hw/intc/loongarch_extioi.c | 2 +- hw/intc/loongarch_pch_msi.c | 2 +- hw/intc/loongarch_pch_pic.c | 2 +- hw/intc/loongson_ipi_common.c | 2 +- hw/intc/m68k_irqc.c | 2 +- hw/intc/mips_gic.c | 2 +- hw/intc/omap_intc.c | 2 +- hw/intc/ompic.c | 2 +- hw/intc/openpic.c | 2 +- hw/intc/openpic_kvm.c | 2 +- hw/intc/pnv_xive.c | 2 +- hw/intc/pnv_xive2.c | 2 +- hw/intc/ppc-uic.c | 2 +- hw/intc/riscv_aclint.c | 4 ++-- hw/intc/riscv_aplic.c | 2 +- hw/intc/riscv_imsic.c | 2 +- hw/intc/rx_icu.c | 2 +- hw/intc/s390_flic.c | 4 ++-- hw/intc/sifive_plic.c | 2 +- hw/intc/spapr_xive.c | 2 +- hw/intc/xics.c | 4 ++-- hw/intc/xilinx_intc.c | 2 +- hw/intc/xive.c | 8 ++++---- hw/intc/xive2.c | 4 ++-- hw/intc/xlnx-pmu-iomod-intc.c | 2 +- hw/ipack/ipack.c | 2 +- hw/ipmi/ipmi.c | 2 +- hw/ipmi/ipmi_bmc_extern.c | 2 +- hw/ipmi/ipmi_bmc_sim.c | 2 +- hw/ipmi/isa_ipmi_bt.c | 2 +- hw/ipmi/isa_ipmi_kcs.c | 2 +- hw/isa/lpc_ich9.c | 2 +- hw/isa/pc87312.c | 2 +- hw/isa/piix.c | 2 +- hw/m68k/mcf5206.c | 2 +- hw/m68k/mcf_intc.c | 2 +- hw/m68k/next-cube.c | 2 +- hw/m68k/q800-glue.c | 2 +- hw/mem/cxl_type3.c | 2 +- hw/mem/nvdimm.c | 2 +- hw/mem/pc-dimm.c | 2 +- hw/mem/sparse-mem.c | 2 +- hw/mips/cps.c | 2 +- hw/misc/a9scu.c | 2 +- hw/misc/allwinner-h3-dramc.c | 2 +- hw/misc/allwinner-r40-dramc.c | 2 +- hw/misc/allwinner-sid.c | 2 +- hw/misc/applesmc.c | 2 +- hw/misc/arm11scu.c | 2 +- hw/misc/arm_l2x0.c | 2 +- hw/misc/arm_sysctl.c | 2 +- hw/misc/armsse-cpuid.c | 2 +- hw/misc/aspeed_hace.c | 2 +- hw/misc/aspeed_i3c.c | 2 +- hw/misc/aspeed_lpc.c | 2 +- hw/misc/aspeed_sbc.c | 2 +- hw/misc/aspeed_scu.c | 2 +- hw/misc/aspeed_sdmc.c | 2 +- hw/misc/bcm2835_cprman.c | 2 +- hw/misc/bcm2835_property.c | 2 +- hw/misc/debugexit.c | 2 +- hw/misc/eccmemctl.c | 2 +- hw/misc/empty_slot.c | 2 +- hw/misc/iotkit-secctl.c | 2 +- hw/misc/iotkit-sysctl.c | 2 +- hw/misc/iotkit-sysinfo.c | 2 +- hw/misc/ivshmem.c | 4 ++-- hw/misc/led.c | 2 +- hw/misc/mac_via.c | 2 +- hw/misc/macio/cuda.c | 2 +- hw/misc/macio/macio.c | 4 ++-- hw/misc/macio/pmu.c | 2 +- hw/misc/mips_cmgcr.c | 2 +- hw/misc/mips_cpc.c | 2 +- hw/misc/mips_itu.c | 2 +- hw/misc/mos6522.c | 2 +- hw/misc/mps2-fpgaio.c | 2 +- hw/misc/mps2-scc.c | 2 +- hw/misc/msf2-sysreg.c | 2 +- hw/misc/npcm7xx_gcr.c | 2 +- hw/misc/nrf51_rng.c | 2 +- hw/misc/pci-testdev.c | 2 +- hw/misc/pvpanic-isa.c | 2 +- hw/misc/pvpanic-pci.c | 2 +- hw/misc/sifive_e_aon.c | 2 +- hw/misc/sifive_u_otp.c | 2 +- hw/misc/stm32l4x5_rcc.c | 2 +- hw/misc/tz-mpc.c | 2 +- hw/misc/tz-msc.c | 2 +- hw/misc/tz-ppc.c | 2 +- hw/misc/unimp.c | 2 +- hw/misc/xlnx-versal-cframe-reg.c | 4 ++-- hw/misc/xlnx-versal-cfu.c | 4 ++-- hw/misc/xlnx-versal-trng.c | 6 +++--- hw/misc/xlnx-versal-xramc.c | 2 +- hw/misc/zynq_slcr.c | 2 +- hw/net/allwinner-sun8i-emac.c | 2 +- hw/net/allwinner_emac.c | 2 +- hw/net/cadence_gem.c | 2 +- hw/net/can/xlnx-versal-canfd.c | 2 +- hw/net/can/xlnx-zynqmp-can.c | 2 +- hw/net/dp8393x.c | 2 +- hw/net/e1000.c | 2 +- hw/net/e1000e.c | 2 +- hw/net/eepro100.c | 2 +- hw/net/fsl_etsec/etsec.c | 2 +- hw/net/ftgmac100.c | 4 ++-- hw/net/igb.c | 2 +- hw/net/imx_fec.c | 2 +- hw/net/lan9118.c | 2 +- hw/net/lance.c | 2 +- hw/net/lasi_i82596.c | 2 +- hw/net/mcf_fec.c | 2 +- hw/net/mipsnet.c | 2 +- hw/net/msf2-emac.c | 2 +- hw/net/mv88w8618_eth.c | 2 +- hw/net/ne2000-isa.c | 2 +- hw/net/ne2000-pci.c | 2 +- hw/net/npcm7xx_emc.c | 2 +- hw/net/npcm_gmac.c | 2 +- hw/net/opencores_eth.c | 2 +- hw/net/pcnet-pci.c | 2 +- hw/net/rocker/rocker.c | 2 +- hw/net/rtl8139.c | 2 +- hw/net/smc91c111.c | 2 +- hw/net/spapr_llan.c | 2 +- hw/net/stellaris_enet.c | 2 +- hw/net/sungem.c | 2 +- hw/net/sunhme.c | 2 +- hw/net/tulip.c | 2 +- hw/net/virtio-net.c | 2 +- hw/net/vmxnet3.c | 2 +- hw/net/xen_nic.c | 2 +- hw/net/xgmac.c | 2 +- hw/net/xilinx_axienet.c | 2 +- hw/net/xilinx_ethlite.c | 2 +- hw/nubus/nubus-bridge.c | 2 +- hw/nubus/nubus-device.c | 2 +- hw/nvme/ctrl.c | 2 +- hw/nvme/ns.c | 2 +- hw/nvme/subsys.c | 2 +- hw/nvram/ds1225y.c | 2 +- hw/nvram/eeprom_at24c.c | 2 +- hw/nvram/fw_cfg.c | 6 +++--- hw/nvram/mac_nvram.c | 2 +- hw/nvram/nrf51_nvm.c | 2 +- hw/nvram/spapr_nvram.c | 2 +- hw/nvram/xlnx-bbram.c | 2 +- hw/nvram/xlnx-efuse.c | 2 +- hw/nvram/xlnx-versal-efuse-cache.c | 2 +- hw/nvram/xlnx-versal-efuse-ctrl.c | 2 +- hw/nvram/xlnx-zynqmp-efuse.c | 2 +- hw/pci-bridge/cxl_downstream.c | 2 +- hw/pci-bridge/cxl_root_port.c | 2 +- hw/pci-bridge/cxl_upstream.c | 2 +- hw/pci-bridge/gen_pcie_root_port.c | 2 +- hw/pci-bridge/pci_bridge_dev.c | 2 +- hw/pci-bridge/pci_expander_bridge.c | 4 ++-- hw/pci-bridge/pcie_pci_bridge.c | 2 +- hw/pci-bridge/pcie_root_port.c | 2 +- hw/pci-bridge/xio3130_downstream.c | 2 +- hw/pci-host/astro.c | 5 ----- hw/pci-host/dino.c | 2 +- hw/pci-host/gpex.c | 2 +- hw/pci-host/grackle.c | 2 +- hw/pci-host/gt64120.c | 2 +- hw/pci-host/i440fx.c | 2 +- hw/pci-host/mv64361.c | 2 +- hw/pci-host/pnv_phb.c | 4 ++-- hw/pci-host/pnv_phb3.c | 2 +- hw/pci-host/pnv_phb4.c | 2 +- hw/pci-host/pnv_phb4_pec.c | 2 +- hw/pci-host/ppce500.c | 2 +- hw/pci-host/q35.c | 4 ++-- hw/pci-host/raven.c | 2 +- hw/pci-host/sabre.c | 2 +- hw/pci-host/uninorth.c | 2 +- hw/pci-host/versatile.c | 2 +- hw/pci-host/xilinx-pcie.c | 2 +- hw/pci/pci.c | 2 +- hw/pci/pci_bridge.c | 2 +- hw/pci/pci_host.c | 2 +- hw/pci/pcie_port.c | 4 ++-- hw/ppc/pnv.c | 2 +- hw/ppc/pnv_adu.c | 2 +- hw/ppc/pnv_chiptod.c | 2 +- hw/ppc/pnv_core.c | 4 ++-- hw/ppc/pnv_homer.c | 2 +- hw/ppc/pnv_i2c.c | 2 +- hw/ppc/pnv_lpc.c | 2 +- hw/ppc/pnv_pnor.c | 2 +- hw/ppc/pnv_psi.c | 2 +- hw/ppc/ppc405_uc.c | 2 +- hw/ppc/ppc440_uc.c | 2 +- hw/ppc/ppc4xx_devs.c | 4 ++-- hw/ppc/ppc4xx_sdram.c | 4 ++-- hw/ppc/prep_systemio.c | 2 +- hw/ppc/rs6000_mc.c | 2 +- hw/ppc/spapr_cpu_core.c | 2 +- hw/ppc/spapr_nvdimm.c | 2 +- hw/ppc/spapr_pci.c | 2 +- hw/ppc/spapr_rng.c | 2 +- hw/ppc/spapr_tpm_proxy.c | 2 +- hw/remote/proxy.c | 2 +- hw/riscv/opentitan.c | 2 +- hw/riscv/riscv-iommu-pci.c | 2 +- hw/riscv/riscv-iommu.c | 2 +- hw/riscv/riscv_hart.c | 2 +- hw/riscv/sifive_u.c | 2 +- hw/rtc/allwinner-rtc.c | 2 +- hw/rtc/goldfish_rtc.c | 2 +- hw/rtc/m48t59-isa.c | 2 +- hw/rtc/m48t59.c | 2 +- hw/rtc/mc146818rtc.c | 2 +- hw/rtc/pl031.c | 2 +- hw/rx/rx62n.c | 2 +- hw/s390x/3270-ccw.c | 2 +- hw/s390x/ccw-device.c | 2 +- hw/s390x/css-bridge.c | 2 +- hw/s390x/ipl.c | 2 +- hw/s390x/s390-pci-bus.c | 2 +- hw/s390x/s390-skeys.c | 2 +- hw/s390x/s390-stattrib.c | 2 +- hw/s390x/vhost-scsi-ccw.c | 2 +- hw/s390x/vhost-user-fs-ccw.c | 2 +- hw/s390x/vhost-vsock-ccw.c | 2 +- hw/s390x/virtio-ccw-9p.c | 2 +- hw/s390x/virtio-ccw-balloon.c | 2 +- hw/s390x/virtio-ccw-blk.c | 2 +- hw/s390x/virtio-ccw-crypto.c | 2 +- hw/s390x/virtio-ccw-gpu.c | 2 +- hw/s390x/virtio-ccw-input.c | 2 +- hw/s390x/virtio-ccw-net.c | 2 +- hw/s390x/virtio-ccw-rng.c | 2 +- hw/s390x/virtio-ccw-scsi.c | 2 +- hw/s390x/virtio-ccw-serial.c | 2 +- hw/scsi/megasas.c | 6 +++--- hw/scsi/mptsas.c | 2 +- hw/scsi/scsi-bus.c | 2 +- hw/scsi/scsi-disk.c | 6 +++--- hw/scsi/scsi-generic.c | 2 +- hw/scsi/spapr_vscsi.c | 2 +- hw/scsi/vhost-scsi.c | 2 +- hw/scsi/vhost-user-scsi.c | 2 +- hw/scsi/virtio-scsi.c | 2 +- hw/scsi/vmw_pvscsi.c | 2 +- hw/sd/allwinner-sdhost.c | 2 +- hw/sd/aspeed_sdhci.c | 2 +- hw/sd/sd.c | 6 +++--- hw/sd/sdhci-pci.c | 2 +- hw/sd/sdhci.c | 2 +- hw/sparc/sun4m.c | 2 +- hw/sparc/sun4m_iommu.c | 2 +- hw/sparc64/sun4u.c | 6 +++--- hw/ssi/aspeed_smc.c | 4 ++-- hw/ssi/ibex_spi_host.c | 2 +- hw/ssi/npcm7xx_fiu.c | 2 +- hw/ssi/pnv_spi.c | 2 +- hw/ssi/sifive_spi.c | 2 +- hw/ssi/ssi.c | 2 +- hw/ssi/xilinx_spi.c | 2 +- hw/ssi/xilinx_spips.c | 4 ++-- hw/ssi/xlnx-versal-ospi.c | 2 +- hw/timer/a9gtimer.c | 2 +- hw/timer/allwinner-a10-pit.c | 2 +- hw/timer/arm_mptimer.c | 2 +- hw/timer/arm_timer.c | 2 +- hw/timer/aspeed_timer.c | 2 +- hw/timer/avr_timer16.c | 2 +- hw/timer/grlib_gptimer.c | 2 +- hw/timer/hpet.c | 2 +- hw/timer/i8254_common.c | 2 +- hw/timer/ibex_timer.c | 2 +- hw/timer/mss-timer.c | 2 +- hw/timer/nrf51_timer.c | 2 +- hw/timer/pxa2xx_timer.c | 2 +- hw/timer/renesas_cmt.c | 2 +- hw/timer/renesas_tmr.c | 2 +- hw/timer/sifive_pwm.c | 2 +- hw/timer/slavio_timer.c | 2 +- hw/timer/sse-timer.c | 2 +- hw/timer/stm32f2xx_timer.c | 2 +- hw/timer/xilinx_timer.c | 2 +- hw/tpm/tpm_crb.c | 2 +- hw/tpm/tpm_spapr.c | 2 +- hw/tpm/tpm_tis_i2c.c | 2 +- hw/tpm/tpm_tis_isa.c | 2 +- hw/tpm/tpm_tis_sysbus.c | 2 +- hw/tricore/tc27x_soc.c | 2 +- hw/tricore/tricore_testdevice.c | 2 +- hw/ufs/lu.c | 2 +- hw/ufs/ufs.c | 2 +- hw/usb/bus.c | 2 +- hw/usb/canokey.c | 2 +- hw/usb/ccid-card-emulated.c | 2 +- hw/usb/ccid-card-passthru.c | 2 +- hw/usb/dev-audio.c | 2 +- hw/usb/dev-hid.c | 6 +++--- hw/usb/dev-hub.c | 2 +- hw/usb/dev-mtp.c | 2 +- hw/usb/dev-network.c | 2 +- hw/usb/dev-serial.c | 4 ++-- hw/usb/dev-smartcard-reader.c | 4 ++-- hw/usb/dev-storage-classic.c | 2 +- hw/usb/dev-uas.c | 2 +- hw/usb/hcd-dwc2.c | 2 +- hw/usb/hcd-dwc3.c | 2 +- hw/usb/hcd-ehci-pci.c | 2 +- hw/usb/hcd-ehci-sysbus.c | 2 +- hw/usb/hcd-ohci-pci.c | 2 +- hw/usb/hcd-ohci-sysbus.c | 2 +- hw/usb/hcd-uhci.c | 4 ++-- hw/usb/hcd-xhci-nec.c | 2 +- hw/usb/hcd-xhci-sysbus.c | 2 +- hw/usb/hcd-xhci.c | 2 +- hw/usb/host-libusb.c | 2 +- hw/usb/redirect.c | 2 +- hw/usb/u2f-emulated.c | 2 +- hw/usb/u2f-passthru.c | 2 +- hw/vfio/ap.c | 2 +- hw/vfio/ccw.c | 2 +- hw/vfio/pci.c | 4 ++-- hw/vfio/platform.c | 2 +- hw/virtio/vdpa-dev-pci.c | 2 +- hw/virtio/vdpa-dev.c | 2 +- hw/virtio/vhost-scsi-pci.c | 2 +- hw/virtio/vhost-user-blk-pci.c | 2 +- hw/virtio/vhost-user-device.c | 2 +- hw/virtio/vhost-user-fs-pci.c | 2 +- hw/virtio/vhost-user-fs.c | 2 +- hw/virtio/vhost-user-gpio.c | 2 +- hw/virtio/vhost-user-i2c.c | 2 +- hw/virtio/vhost-user-input.c | 2 +- hw/virtio/vhost-user-rng-pci.c | 2 +- hw/virtio/vhost-user-rng.c | 2 +- hw/virtio/vhost-user-scmi.c | 2 +- hw/virtio/vhost-user-scsi-pci.c | 2 +- hw/virtio/vhost-user-snd-pci.c | 2 +- hw/virtio/vhost-user-snd.c | 2 +- hw/virtio/vhost-user-vsock-pci.c | 2 +- hw/virtio/vhost-user-vsock.c | 2 +- hw/virtio/vhost-vsock-common.c | 2 +- hw/virtio/vhost-vsock-pci.c | 2 +- hw/virtio/vhost-vsock.c | 2 +- hw/virtio/virtio-9p-pci.c | 2 +- hw/virtio/virtio-balloon.c | 2 +- hw/virtio/virtio-blk-pci.c | 2 +- hw/virtio/virtio-crypto-pci.c | 2 +- hw/virtio/virtio-crypto.c | 2 +- hw/virtio/virtio-input-pci.c | 2 +- hw/virtio/virtio-iommu-pci.c | 2 +- hw/virtio/virtio-iommu.c | 2 +- hw/virtio/virtio-mem.c | 2 +- hw/virtio/virtio-mmio.c | 2 +- hw/virtio/virtio-net-pci.c | 2 +- hw/virtio/virtio-nsm.c | 2 +- hw/virtio/virtio-pci.c | 4 ++-- hw/virtio/virtio-pmem.c | 2 +- hw/virtio/virtio-rng-pci.c | 2 +- hw/virtio/virtio-rng.c | 2 +- hw/virtio/virtio-scsi-pci.c | 2 +- hw/virtio/virtio-serial-pci.c | 2 +- hw/virtio/virtio.c | 2 +- hw/watchdog/sbsa_gwdt.c | 2 +- hw/watchdog/wdt_aspeed.c | 2 +- hw/watchdog/wdt_imx2.c | 2 +- hw/xen/xen-bus.c | 2 +- hw/xen/xen-legacy-backend.c | 6 +++--- hw/xen/xen_pt.c | 2 +- target/arm/cpu.c | 26 +++++++++++++------------- target/arm/cpu64.c | 6 +++--- target/arm/tcg/cpu64.c | 2 +- target/avr/cpu.c | 2 +- target/hexagon/cpu.c | 2 +- target/i386/cpu.c | 4 ++-- target/microblaze/cpu.c | 2 +- target/mips/cpu.c | 2 +- target/ppc/cpu_init.c | 6 ------ target/riscv/cpu.c | 2 +- target/s390x/cpu.c | 2 +- target/sparc/cpu.c | 4 ++-- tests/unit/test-qdev-global-props.c | 2 +- docs/devel/migration/compatibility.rst | 4 ++-- docs/devel/virtio-backends.rst | 2 +- 568 files changed, 644 insertions(+), 655 deletions(-)