| Message ID | 2e79be9185cbb0dbe40e670eee996cf290bab0a6.1732264079.git.michal.simek@amd.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] media: ov5640: fix get_light_freq on auto | expand |
Hi Michal, Thanks for the patch. On Fri, Nov 22, 2024 at 09:28:01AM +0100, Michal Simek wrote: > From: Sam Bobrowicz <sam@elite-embedded.com> > > Light frequency was not properly returned when in auto > mode and the detected frequency was 60Hz. > > Fixes: 19a81c1426c1 ("[media] add Omnivision OV5640 sensor driver") > Signed-off-by: Sam Bobrowicz <sam@elite-embedded.com> > Signed-off-by: Michal Simek <michal.simek@amd.com> > Cc: <stable@kernel.org> Cc: stable@vger.kernel.org And right after the Fixes: tag. I fixed it this time. > --- > > Changes in v2: > - add Fixes tag and cc stable > > drivers/media/i2c/ov5640.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c > index c1d3fce4a7d3..8566bc2edde9 100644 > --- a/drivers/media/i2c/ov5640.c > +++ b/drivers/media/i2c/ov5640.c > @@ -1982,6 +1982,7 @@ static int ov5640_get_light_freq(struct ov5640_dev *sensor) > light_freq = 50; > } else { > /* 60Hz */ > + light_freq = 60; > } > } >
Hi Ailus, +Greg On 12/13/24 09:54, Sakari Ailus wrote: > Hi Michal, > > Thanks for the patch. > > On Fri, Nov 22, 2024 at 09:28:01AM +0100, Michal Simek wrote: >> From: Sam Bobrowicz <sam@elite-embedded.com> >> >> Light frequency was not properly returned when in auto >> mode and the detected frequency was 60Hz. >> >> Fixes: 19a81c1426c1 ("[media] add Omnivision OV5640 sensor driver") >> Signed-off-by: Sam Bobrowicz <sam@elite-embedded.com> >> Signed-off-by: Michal Simek <michal.simek@amd.com> >> Cc: <stable@kernel.org> > > Cc: stable@vger.kernel.org > > And right after the Fixes: tag. > > I fixed it this time. Thanks for this. I was trying to find out if this is described anywhere because in stable tree both ways are used. Also Greg's script didn't report any issue with it. Is it a rule for media tree or your rule or described somewhere? I have no problem with that rule but just want to understand where this request is coming from. Thanks, Michal
On Fri, Dec 13, 2024 at 11:30:38AM +0100, Michal Simek wrote: > Hi Ailus, +Greg > > On 12/13/24 09:54, Sakari Ailus wrote: > > Hi Michal, > > > > Thanks for the patch. > > > > On Fri, Nov 22, 2024 at 09:28:01AM +0100, Michal Simek wrote: > > > From: Sam Bobrowicz <sam@elite-embedded.com> > > > > > > Light frequency was not properly returned when in auto > > > mode and the detected frequency was 60Hz. > > > > > > Fixes: 19a81c1426c1 ("[media] add Omnivision OV5640 sensor driver") > > > Signed-off-by: Sam Bobrowicz <sam@elite-embedded.com> > > > Signed-off-by: Michal Simek <michal.simek@amd.com> > > > Cc: <stable@kernel.org> That address is totally acceptable. > > Cc: stable@vger.kernel.org > > > > And right after the Fixes: tag. > > > > I fixed it this time. Neither is required at all. > Thanks for this. I was trying to find out if this is described anywhere > because in stable tree both ways are used. Also Greg's script didn't report > any issue with it. Is it a rule for media tree or your rule or described > somewhere? It's not a rule anywhere, and the use of stable@kernel.org is also documented (it routes to /dev/null and can be used just to tag stuff, no one is going to answer that email at all.) > I have no problem with that rule but just want to understand where this > request is coming from. No idea, I have no such rule, and in fact I use stable@kernel.org all the time for my subsystems. thanks, greg k-h
On 12/13/24 12:12, Greg Kroah-Hartman wrote: > On Fri, Dec 13, 2024 at 11:30:38AM +0100, Michal Simek wrote: >> Hi Ailus, +Greg >> >> On 12/13/24 09:54, Sakari Ailus wrote: >>> Hi Michal, >>> >>> Thanks for the patch. >>> >>> On Fri, Nov 22, 2024 at 09:28:01AM +0100, Michal Simek wrote: >>>> From: Sam Bobrowicz <sam@elite-embedded.com> >>>> >>>> Light frequency was not properly returned when in auto >>>> mode and the detected frequency was 60Hz. >>>> >>>> Fixes: 19a81c1426c1 ("[media] add Omnivision OV5640 sensor driver") >>>> Signed-off-by: Sam Bobrowicz <sam@elite-embedded.com> >>>> Signed-off-by: Michal Simek <michal.simek@amd.com> >>>> Cc: <stable@kernel.org> > > That address is totally acceptable. > >>> Cc: stable@vger.kernel.org >>> >>> And right after the Fixes: tag. >>> >>> I fixed it this time. > > Neither is required at all. > >> Thanks for this. I was trying to find out if this is described anywhere >> because in stable tree both ways are used. Also Greg's script didn't report >> any issue with it. Is it a rule for media tree or your rule or described >> somewhere? > > It's not a rule anywhere, and the use of stable@kernel.org is also > documented (it routes to /dev/null and can be used just to tag stuff, no > one is going to answer that email at all.) Yep. I was checking that recently that stable@kernel.org can be used too. > >> I have no problem with that rule but just want to understand where this >> request is coming from. > > No idea, I have no such rule, and in fact I use stable@kernel.org all > the time for my subsystems. It was more about that stable tag has to immediately follow fixed tag. Thanks for confirmation. Cheers, Michal
Hi Greg, On Fri, Dec 13, 2024 at 12:12:18PM +0100, Greg Kroah-Hartman wrote: > On Fri, Dec 13, 2024 at 11:30:38AM +0100, Michal Simek wrote: > > Hi Ailus, +Greg > > > > On 12/13/24 09:54, Sakari Ailus wrote: > > > Hi Michal, > > > > > > Thanks for the patch. > > > > > > On Fri, Nov 22, 2024 at 09:28:01AM +0100, Michal Simek wrote: > > > > From: Sam Bobrowicz <sam@elite-embedded.com> > > > > > > > > Light frequency was not properly returned when in auto > > > > mode and the detected frequency was 60Hz. > > > > > > > > Fixes: 19a81c1426c1 ("[media] add Omnivision OV5640 sensor driver") > > > > Signed-off-by: Sam Bobrowicz <sam@elite-embedded.com> > > > > Signed-off-by: Michal Simek <michal.simek@amd.com> > > > > Cc: <stable@kernel.org> > > That address is totally acceptable. The documentation (Documentation/process/stable-kernel-rules.rst) tells to use stable@vger.kernel.org nevertheless (we're not discussing the latter option here): To have a patch you submit for mainline inclusion later automatically picked up for stable trees, add this tag in the sign-off area:: Cc: stable@vger.kernel.org Use ``Cc: stable@kernel.org`` instead when fixing unpublished vulnerabilities: it reduces the chance of accidentally exposing the fix to the public by way of 'git send-email', as mails sent to that address are not delivered anywhere. > > > > Cc: stable@vger.kernel.org > > > > > > And right after the Fixes: tag. > > > > > > I fixed it this time. > > Neither is required at all. Right, I must have confused this with Reported-by: and Closes:. > > > Thanks for this. I was trying to find out if this is described anywhere > > because in stable tree both ways are used. Also Greg's script didn't report > > any issue with it. Is it a rule for media tree or your rule or described > > somewhere? > > It's not a rule anywhere, and the use of stable@kernel.org is also > documented (it routes to /dev/null and can be used just to tag stuff, no > one is going to answer that email at all.) > > > I have no problem with that rule but just want to understand where this > > request is coming from. > > No idea, I have no such rule, and in fact I use stable@kernel.org all > the time for my subsystems. > > thanks, > > greg k-h
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index c1d3fce4a7d3..8566bc2edde9 100644 --- a/drivers/media/i2c/ov5640.c +++ b/drivers/media/i2c/ov5640.c @@ -1982,6 +1982,7 @@ static int ov5640_get_light_freq(struct ov5640_dev *sensor) light_freq = 50; } else { /* 60Hz */ + light_freq = 60; } }