| Message ID | 20241211070503.87386-1-jirislaby@kernel.org |
|---|---|
| State | Accepted |
| Commit | 145ac100b63732291c0612528444d7f5ab593fb2 |
| Headers | show |
| Series | efi/esrt: remove esre_attribute::store() | expand |
On Wed, 11 Dec 2024 at 08:05, Jiri Slaby (SUSE) <jirislaby@kernel.org> wrote: > > esre_attribute::store() is not needed since commit af97a77bc01c (efi: > Move some sysfs files to be read-only by root). Drop it. > > Found by https://github.com/jirislaby/clang-struct. > > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> > Cc: Ard Biesheuvel <ardb@kernel.org> > Cc: linux-efi@vger.kernel.org Queued up, thanks. > --- > drivers/firmware/efi/esrt.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c > index 7a81c0ce4780..4bb7b0584bc9 100644 > --- a/drivers/firmware/efi/esrt.c > +++ b/drivers/firmware/efi/esrt.c > @@ -75,8 +75,6 @@ static LIST_HEAD(entry_list); > struct esre_attribute { > struct attribute attr; > ssize_t (*show)(struct esre_entry *entry, char *buf); > - ssize_t (*store)(struct esre_entry *entry, > - const char *buf, size_t count); > }; > > static struct esre_entry *to_entry(struct kobject *kobj) > -- > 2.47.1 >
diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c index 7a81c0ce4780..4bb7b0584bc9 100644 --- a/drivers/firmware/efi/esrt.c +++ b/drivers/firmware/efi/esrt.c @@ -75,8 +75,6 @@ static LIST_HEAD(entry_list); struct esre_attribute { struct attribute attr; ssize_t (*show)(struct esre_entry *entry, char *buf); - ssize_t (*store)(struct esre_entry *entry, - const char *buf, size_t count); }; static struct esre_entry *to_entry(struct kobject *kobj)
esre_attribute::store() is not needed since commit af97a77bc01c (efi: Move some sysfs files to be read-only by root). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> Cc: Ard Biesheuvel <ardb@kernel.org> Cc: linux-efi@vger.kernel.org --- drivers/firmware/efi/esrt.c | 2 -- 1 file changed, 2 deletions(-)