mbox series

[v1,0/5] Support host1x actmon

Message ID 20241210174554.18869-1-johnliu@nvidia.com
Headers show
Series Support host1x actmon | expand

Message

Johnny Liu Dec. 10, 2024, 5:45 p.m. UTC 
Activity monitoring (actmon for short) is a means to dynamically
measure the utilization of units in the system to help drive software
power management policies.

In Tegra, Dynamic Voltage and Frequency Scaling (DVFS) is the primary
dynamic power management mechanism. It uses utilization information
from various units to select the most efficient frequency and thereby,
voltage that the unit should operate while providing the requisite
performance.

Johnny Liu (5):
  dt-bindings: display: tegra: Add actmon information
  arm64: tegra: Add actmon information
  gpu: host1x: Support device monitoring with actmon
  drm/tegra: nvdec: Register the device with actmon
  drm/tegra: vic: Register the device with actmon

 .../display/tegra/nvidia,tegra20-host1x.yaml  |  45 +-
 arch/arm64/boot/dts/nvidia/tegra234.dtsi      |  10 +-
 drivers/gpu/drm/tegra/nvdec.c                 |  82 ++-
 drivers/gpu/drm/tegra/vic.c                   |  39 +-
 drivers/gpu/drm/tegra/vic.h                   |   9 +
 drivers/gpu/host1x/Makefile                   |   1 +
 drivers/gpu/host1x/actmon.c                   | 558 ++++++++++++++++++
 drivers/gpu/host1x/actmon.h                   |  46 ++
 drivers/gpu/host1x/dev.c                      |  71 ++-
 drivers/gpu/host1x/dev.h                      |  59 +-
 drivers/gpu/host1x/hw/actmon.h                |  49 ++
 drivers/gpu/host1x/hw/host1x08.c              |   6 +-
 drivers/gpu/host1x/hw/hw_host1x08_common.h    |  16 +-
 drivers/gpu/host1x/hw/intr_general_hw.c       |  83 +++
 include/linux/host1x.h                        |  30 +-
 15 files changed, 1075 insertions(+), 29 deletions(-)
 create mode 100644 drivers/gpu/host1x/actmon.c
 create mode 100644 drivers/gpu/host1x/actmon.h
 create mode 100644 drivers/gpu/host1x/hw/actmon.h
 create mode 100644 drivers/gpu/host1x/hw/intr_general_hw.c

Comments

Krzysztof Kozlowski Dec. 13, 2024, 10:42 a.m. UTC | #1 
On Tue, Dec 10, 2024 at 09:45:49AM -0800, Johnny Liu wrote:
> Activity monitoring (actmon for short) is a means to dynamically
> measure the utilization of units in the system to help drive software
> power management policies.
> 

Is this a resend or v2? Please always mark your patches appropriately -
see submitting patches document.

b4 diff '20241210174554.18869-1-johnliu@nvidia.com'
Grabbing thread from lore.kernel.org/all/20241210174554.18869-1-johnliu@nvidia.com/t.mbox.gz
---
Analyzing 6 messages in the thread
Could not find lower series to compare against.

But I am sure I saw it somewhere...

Or just use b4, so all this problems disappear.

Best regards,
Krzysztof
Johnny Liu Dec. 13, 2024, 11:17 p.m. UTC | #2 
> On Tue, Dec 10, 2024 at 09:45:49AM -0800, Johnny Liu wrote:
> > Activity monitoring (actmon for short) is a means to dynamically
> > measure the utilization of units in the system to help drive software
> > power management policies.
> >
>
> Is this a resend or v2? Please always mark your patches appropriately -
> see submitting patches document.
>
> b4 diff '20241210174554.18869-1-johnliu@nvidia.com'
> Grabbing thread from lore.kernel.org/all/20241210174554.18869-1-johnliu@nvidia.com/t.mbox.gz
> ---
> Analyzing 6 messages in the thread
> Could not find lower series to compare against.
>
> But I am sure I saw it somewhere...
>
> Or just use b4, so all this problems disappear.

This is a resend actually to include all necessary To/Cc entries based on your comment
in the previous patch series:
lore.kernel.org/linux-tegra/20241209172549.5624-1-johnliu@nvidia.com

Previous one doesn't cover all the required reviewers as you mentioned, so I don't consider
it as a valid patch series. Therefore, I resend it again and include the required folks and
consider it as a brand new patch series.

I would definitely try the b4 tool you recommended and update my workflow. I actually use
vanilla git send-mail and git format-patch currently...


Thanks,
Johnny