mbox series

[v4,0/4] Select CONFIG_64BIT for sandbox64 and x86_64

Message ID 20241125115554.1707080-1-andrew.goodbody@linaro.org
Headers show
Series Select CONFIG_64BIT for sandbox64 and x86_64 | expand

Message

Andrew Goodbody Nov. 25, 2024, 11:55 a.m. UTC 
Picking up a series from Dan Carpenter and applying requested
changes for v2.

I had previously set CONFIG_64BIT for arm64.  This patchset does the
same thing for sandbox and x86_64.  (Mips and riscv were already
doing it).  This CONFIG option is used in the Makefile to determine
if it's a 32 or 64 bit system for the CHECKER.

Makefile
  1052  # the checker needs the correct machine size
  1053  CHECKFLAGS += $(if $(CONFIG_64BIT),-m64,-m32)

Changes in v4:
 - Add help text to describe new symbol CONFIG_SPL_64BIT
 - Split the statement in bloblist.c to be more readable

Changes in v3:
Added a new patch 1/4 to make fixes to the source needed
by the sandbox patch 2/4.
Updated 3/4 to account for x86 being built with a 64 bit
U-Boot proper but a 32 bit SPL.
Added another patch 4/4 to fix an incorrect use of
CONFIG_PHYS_64BIT which should be CONFIG_64BIT at the request
of Tom Rini.

Changes in v2:
Resubmitted by Andrew Goodbody with changes requested by reviewer

Andrew Goodbody (4):
  sandbox: Correct guard around readq/writeq
  sandbox: select CONFIG_64BIT for sandbox
  x86: select CONFIG_64BIT for X86_64
  test: lib: Use CONFIG_64BIT to detect 64 bit compile

 arch/Kconfig                  |  8 ++++++++
 arch/arm/Kconfig              |  1 +
 arch/mips/Kconfig             |  4 ++++
 arch/riscv/Kconfig            |  1 +
 arch/sandbox/Kconfig          |  2 ++
 arch/sandbox/include/asm/io.h |  4 ++--
 arch/x86/Kconfig              |  1 +
 common/bloblist.c             | 11 +++++++----
 include/limits.h              |  3 ++-
 test/lib/str.c                |  8 ++++----
 10 files changed, 32 insertions(+), 11 deletions(-)

Comments

Tom Rini Dec. 13, 2024, 8:09 p.m. UTC | #1 
On Mon, Nov 25, 2024 at 11:55:50AM +0000, Andrew Goodbody wrote:

> Picking up a series from Dan Carpenter and applying requested
> changes for v2.
> 
> I had previously set CONFIG_64BIT for arm64.  This patchset does the
> same thing for sandbox and x86_64.  (Mips and riscv were already
> doing it).  This CONFIG option is used in the Makefile to determine
> if it's a 32 or 64 bit system for the CHECKER.
> 
> Makefile
>   1052  # the checker needs the correct machine size
>   1053  CHECKFLAGS += $(if $(CONFIG_64BIT),-m64,-m32)

Unfortunately this currently fails to build for chromebook_coral
chromebook_samus_tpl qemu-x86_64 and snow platforms.