| Message ID | 20241210233534.614520-7-mailingradian@gmail.com |
|---|---|
| Headers | show |
| Series | Add SDM670 camera subsystem | expand |
On 10/12/2024 23:35, Richard Acayan wrote: > + clocks = <&gcc GCC_CAMERA_AHB_CLK>, > + <&gcc GCC_CAMERA_AXI_CLK>, > + <&camcc CAM_CC_SOC_AHB_CLK>, > + <&camcc CAM_CC_CAMNOC_AXI_CLK>, > + <&camcc CAM_CC_CPAS_AHB_CLK>, > + <&camcc CAM_CC_IFE_0_CSID_CLK>, > + <&camcc CAM_CC_IFE_1_CSID_CLK>, > + <&camcc CAM_CC_IFE_LITE_CSID_CLK>, > + <&camcc CAM_CC_CSIPHY0_CLK>, > + <&camcc CAM_CC_CSI0PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY1_CLK>, > + <&camcc CAM_CC_CSI1PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY2_CLK>, > + <&camcc CAM_CC_CSI2PHYTIMER_CLK>, > + <&camcc CAM_CC_IFE_0_AXI_CLK>, > + <&camcc CAM_CC_IFE_0_CLK>, > + <&camcc CAM_CC_IFE_0_CPHY_RX_CLK>, > + <&camcc CAM_CC_IFE_1_AXI_CLK>, > + <&camcc CAM_CC_IFE_1_CLK>, > + <&camcc CAM_CC_IFE_1_CPHY_RX_CLK>, > + <&camcc CAM_CC_IFE_LITE_CLK>, > + <&camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>; > + clock-names = "gcc_camera_ahb", > + "gcc_camera_axi", > + "soc_ahb", > + "camnoc_axi", > + "cpas_ahb", I think you sorted the regs, interrupts but forgot the clocks ? --- bod
On Tue, Dec 10, 2024 at 11:49:20PM +0000, Bryan O'Donoghue wrote: > On 10/12/2024 23:35, Richard Acayan wrote: > > + clocks = <&gcc GCC_CAMERA_AHB_CLK>, > > + <&gcc GCC_CAMERA_AXI_CLK>, > > + <&camcc CAM_CC_SOC_AHB_CLK>, > > + <&camcc CAM_CC_CAMNOC_AXI_CLK>, > > + <&camcc CAM_CC_CPAS_AHB_CLK>, > > + <&camcc CAM_CC_IFE_0_CSID_CLK>, > > + <&camcc CAM_CC_IFE_1_CSID_CLK>, > > + <&camcc CAM_CC_IFE_LITE_CSID_CLK>, > > + <&camcc CAM_CC_CSIPHY0_CLK>, > > + <&camcc CAM_CC_CSI0PHYTIMER_CLK>, > > + <&camcc CAM_CC_CSIPHY1_CLK>, > > + <&camcc CAM_CC_CSI1PHYTIMER_CLK>, > > + <&camcc CAM_CC_CSIPHY2_CLK>, > > + <&camcc CAM_CC_CSI2PHYTIMER_CLK>, > > + <&camcc CAM_CC_IFE_0_AXI_CLK>, > > + <&camcc CAM_CC_IFE_0_CLK>, > > + <&camcc CAM_CC_IFE_0_CPHY_RX_CLK>, > > + <&camcc CAM_CC_IFE_1_AXI_CLK>, > > + <&camcc CAM_CC_IFE_1_CLK>, > > + <&camcc CAM_CC_IFE_1_CPHY_RX_CLK>, > > + <&camcc CAM_CC_IFE_LITE_CLK>, > > + <&camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>; > > + clock-names = "gcc_camera_ahb", > > + "gcc_camera_axi", > > + "soc_ahb", > > + "camnoc_axi", > > + "cpas_ahb", > > I think you sorted the regs, interrupts but forgot the clocks ? Do you mean the first three clocks placed first? The order was suggested by Vladimir in [1], but I can undo it. [1] https://lore.kernel.org/r/40cd7a52-1c60-40dc-aee6-730b5247b216@linaro.org > > --- > bod
On 11/12/2024 00:30, Richard Acayan wrote: >> I think you sorted the regs, interrupts but forgot the clocks ? > Do you mean the first three clocks placed first? The order was suggested > by Vladimir in [1], but I can undo it. > > [1]https://lore.kernel.org/r/40cd7a52-1c60-40dc-aee6-730b5247b216@linaro.org We've had a long, long discussion on ordering subsequent. Have a look at the sc7280 and align your ordering with that. --- bod
On Wed, Dec 11, 2024 at 11:24:30AM +0000, Bryan O'Donoghue wrote: > On 11/12/2024 00:30, Richard Acayan wrote: > > > I think you sorted the regs, interrupts but forgot the clocks ? > > Do you mean the first three clocks placed first? The order was suggested > > by Vladimir in [1], but I can undo it. > > > > [1]https://lore.kernel.org/r/40cd7a52-1c60-40dc-aee6-730b5247b216@linaro.org > > We've had a long, long discussion on ordering subsequent. > > Have a look at the sc7280 and align your ordering with that. Ok, it seems SC7280 renames the CSID clocks to change their alphabetical sorting so I'll rename them as well. csi0 -> vfe0_csid csi1 -> vfe1_csid csi2 -> vfe_lite_csid