diff mbox series

[libgpiod] bindings: python: fix license tags

Message ID 20241127150529.126896-1-brgl@bgdev.pl
State New
Headers show
Series [libgpiod] bindings: python: fix license tags | expand

Commit Message

Bartosz Golaszewski Nov. 27, 2024, 3:05 p.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Several files under bindings/python/ have wrong license tags.

In general:
- Makefiles should be covered by GPL
- all python sources under bindings/python/gpiod/ and
  bindings/python/tests/ that are part of importable modules should be
  licensed under LGPL
- executable examples should be licensed under GPL

Reported-by: Vincent Fazio <vfazio@xes-inc.com>
Closes: https://github.com/brgl/libgpiod/issues/110
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Kent, Vincent:

This patch doesn't really relicense the code. It just makes the
licensing consistent across the python bindings. However - as the only
two authors of the affected files other than me - could you please leave
your acks?

 bindings/python/gpiod/Makefile.am            | 2 +-
 bindings/python/gpiod/_internal.py           | 2 +-
 bindings/python/gpiod/ext/Makefile.am        | 2 +-
 bindings/python/tests/Makefile.am            | 2 +-
 bindings/python/tests/gpiosim/Makefile.am    | 2 +-
 bindings/python/tests/gpiosim/__init__.py    | 2 +-
 bindings/python/tests/helpers.py             | 2 +-
 bindings/python/tests/system/Makefile.am     | 2 +-
 bindings/python/tests/system/__init__.py     | 2 +-
 bindings/python/tests/tests_line.py          | 2 +-
 bindings/python/tests/tests_line_settings.py | 2 +-
 11 files changed, 11 insertions(+), 11 deletions(-)

Comments

Vincent Fazio Nov. 27, 2024, 3:10 p.m. UTC | #1
> -----Original Message-----
> From: Bartosz Golaszewski <brgl@bgdev.pl>
> Sent: Wednesday, November 27, 2024 9:05 AM
> To: Vincent Fazio <vfazio@xes-inc.com>; Phil Howard <phil@gadgetoid.com>;
> Kent Gibson <warthog618@gmail.com>; Linus Walleij
> <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org; Bartosz Golaszewski
> <bartosz.golaszewski@linaro.org>
> Subject: [External] - [libgpiod][PATCH] bindings: python: fix license tags
> 
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Several files under bindings/python/ have wrong license tags.
> 
> In general:
> - Makefiles should be covered by GPL
> - all python sources under bindings/python/gpiod/ and
>   bindings/python/tests/ that are part of importable modules should be
>   licensed under LGPL
> - executable examples should be licensed under GPL
> 
> Reported-by: Vincent Fazio <vfazio@xes-inc.com>
> Closes: https://github.com/brgl/libgpiod/issues/110
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> Kent, Vincent:
> 
> This patch doesn't really relicense the code. It just makes the licensing
> consistent across the python bindings. However - as the only two authors of
> the affected files other than me - could you please leave your acks?

Acked-by: Vincent Fazio <vfazio@xes-inc.com>
Bartosz Golaszewski Dec. 5, 2024, 12:56 p.m. UTC | #2
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Wed, 27 Nov 2024 16:05:29 +0100, Bartosz Golaszewski wrote:
> Several files under bindings/python/ have wrong license tags.
> 
> In general:
> - Makefiles should be covered by GPL
> - all python sources under bindings/python/gpiod/ and
>   bindings/python/tests/ that are part of importable modules should be
>   licensed under LGPL
> - executable examples should be licensed under GPL
> 
> [...]

I haven't heard from Kent but I doubt he would object so patch applied.

[1/1] bindings: python: fix license tags
      commit: 6d9133a259e64da5e03c7e7784f0f27de7b3e59f

Best regards,
Kent Gibson Dec. 5, 2024, 2:51 p.m. UTC | #3
On Thu, Dec 05, 2024 at 01:56:48PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
>
> On Wed, 27 Nov 2024 16:05:29 +0100, Bartosz Golaszewski wrote:
> > Several files under bindings/python/ have wrong license tags.
> >
> > In general:
> > - Makefiles should be covered by GPL
> > - all python sources under bindings/python/gpiod/ and
> >   bindings/python/tests/ that are part of importable modules should be
> >   licensed under LGPL
> > - executable examples should be licensed under GPL
> >
> > [...]
>
> I haven't heard from Kent but I doubt he would object so patch applied.
>

Sorry - missed this one, but I have no objections.

Cheers,
Kent.
diff mbox series

Patch

diff --git a/bindings/python/gpiod/Makefile.am b/bindings/python/gpiod/Makefile.am
index 49addcc..7e37b8d 100644
--- a/bindings/python/gpiod/Makefile.am
+++ b/bindings/python/gpiod/Makefile.am
@@ -1,4 +1,4 @@ 
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
 
 SUBDIRS = ext
diff --git a/bindings/python/gpiod/_internal.py b/bindings/python/gpiod/_internal.py
index c9b5d28..37f6661 100644
--- a/bindings/python/gpiod/_internal.py
+++ b/bindings/python/gpiod/_internal.py
@@ -1,4 +1,4 @@ 
-# SPDX-License-Identifier: GPL-2.0-or-later
+# SPDX-License-Identifier: LGPL-2.1-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
 
 from datetime import timedelta
diff --git a/bindings/python/gpiod/ext/Makefile.am b/bindings/python/gpiod/ext/Makefile.am
index 9c81b17..3a8a0d1 100644
--- a/bindings/python/gpiod/ext/Makefile.am
+++ b/bindings/python/gpiod/ext/Makefile.am
@@ -1,4 +1,4 @@ 
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
 
 EXTRA_DIST = \
diff --git a/bindings/python/tests/Makefile.am b/bindings/python/tests/Makefile.am
index d6e3ea3..1809206 100644
--- a/bindings/python/tests/Makefile.am
+++ b/bindings/python/tests/Makefile.am
@@ -1,4 +1,4 @@ 
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
 
 SUBDIRS = gpiosim system
diff --git a/bindings/python/tests/gpiosim/Makefile.am b/bindings/python/tests/gpiosim/Makefile.am
index b403f3c..cc8c11a 100644
--- a/bindings/python/tests/gpiosim/Makefile.am
+++ b/bindings/python/tests/gpiosim/Makefile.am
@@ -1,4 +1,4 @@ 
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
 
 EXTRA_DIST = \
diff --git a/bindings/python/tests/gpiosim/__init__.py b/bindings/python/tests/gpiosim/__init__.py
index 64a1551..ddb59be 100644
--- a/bindings/python/tests/gpiosim/__init__.py
+++ b/bindings/python/tests/gpiosim/__init__.py
@@ -1,4 +1,4 @@ 
-# SPDX-License-Identifier: GPL-2.0-or-later
+# SPDX-License-Identifier: LGPL-2.1-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
 
 from .chip import Chip
diff --git a/bindings/python/tests/helpers.py b/bindings/python/tests/helpers.py
index 2126901..ad272a1 100644
--- a/bindings/python/tests/helpers.py
+++ b/bindings/python/tests/helpers.py
@@ -1,4 +1,4 @@ 
-# SPDX-License-Identifier: GPL-2.0-or-later
+# SPDX-License-Identifier: LGPL-2.1-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
 
 from __future__ import annotations
diff --git a/bindings/python/tests/system/Makefile.am b/bindings/python/tests/system/Makefile.am
index dbc8e64..3590be3 100644
--- a/bindings/python/tests/system/Makefile.am
+++ b/bindings/python/tests/system/Makefile.am
@@ -1,4 +1,4 @@ 
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
 
 EXTRA_DIST = \
diff --git a/bindings/python/tests/system/__init__.py b/bindings/python/tests/system/__init__.py
index cba9b92..99fde9c 100644
--- a/bindings/python/tests/system/__init__.py
+++ b/bindings/python/tests/system/__init__.py
@@ -1,4 +1,4 @@ 
-# SPDX-License-Identifier: GPL-2.0-or-later
+# SPDX-License-Identifier: LGPL-2.1-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
 
 from ._ext import check_kernel_version, set_process_name
diff --git a/bindings/python/tests/tests_line.py b/bindings/python/tests/tests_line.py
index c96f6de..5bc742a 100644
--- a/bindings/python/tests/tests_line.py
+++ b/bindings/python/tests/tests_line.py
@@ -1,4 +1,4 @@ 
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
 # SPDX-FileCopyrightText: 2024 Kent Gibson <warthog618@gmail.com>
 
 from unittest import TestCase
diff --git a/bindings/python/tests/tests_line_settings.py b/bindings/python/tests/tests_line_settings.py
index 66e01df..ad70921 100644
--- a/bindings/python/tests/tests_line_settings.py
+++ b/bindings/python/tests/tests_line_settings.py
@@ -1,4 +1,4 @@ 
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
 # SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
 
 import datetime